Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for subproject site requests #3762

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@nikhita
Copy link
Member

commented Jun 3, 2019

  • Moves adding a netlify.toml at the root of the repo to the beginning
    of the process, so that the site can be viewed directly once Netlify is
    configured.

  • Add a note about "Basic Build Settings" getting autopopulated with values
    in netlify.toml.

  • Remove step about explicitly enabling HTTPS. Netlify enables HTTPS
    automatically after DNS records are updated.

  • Some markdown improvements.

/assign @mrbobbytables @cblecker

Update instructions for subproject site requests
- Moves adding a `netlify.toml` at the root of the repo to the beginning
of the process, so that the site can be viewed directly once Netlify is
configured.

- Add a note about "Basic Build Settings" getting autopopulated with values
in netlify.toml.

- Remove step about explicitly enabling HTTPS. Netlify enables HTTPS
automatically after DNS records are updated.

- Some markdown improvements.
@fejta

fejta approved these changes Jun 3, 2019

@jimangel

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

/lgtm

Great stuff, thanks!

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Thanks @nikhita :) 👍

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 605cce2 into kubernetes:master Jun 3, 2019

4 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@nikhita nikhita deleted the nikhita:subproject-site-updates branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.