Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link from PR guide to KEP process guide #3964

Merged
merged 1 commit into from Aug 6, 2019
Merged

Fix broken link from PR guide to KEP process guide #3964

merged 1 commit into from Aug 6, 2019

Conversation

dlipovetsky
Copy link
Contributor

Looks like this link was broken when KEPs moved to their own repo.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/contributor-guide Issues or PRs related to the contributor guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Aug 2, 2019
cblecker
cblecker requested changes Aug 3, 2019
View reviewed changes
contributors/guide/pull-requests.md Outdated Show resolved Hide resolved
@cblecker
Fix broken link from PR guide to KEP process guide
8cbd38c 
Signed-Off-By: Daniel Lipovestky <daniel@platform9.com>
Co-Authored-By: Christoph Blecker <admin@toph.ca>
nikhita
nikhita approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dlipovetsky!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3c7a2ce into kubernetes:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker requested changes

@nikhita nikhita nikhita approved these changes

@castrojo castrojo Awaiting requested review from castrojo

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dlipovetsky @k8s-ci-robot @cblecker @nikhita