Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added security audit final reports and updated README #3975

Closed
wants to merge 7 commits into from

Conversation

@aasmall
Copy link
Contributor

commented Aug 6, 2019

This includes the final reports from Trail of Bits and Atredis Partners, as well as some ancillary content.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Hi @aasmall. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cji

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/ok-to-test
/approve

@cji

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/lgtm

@cji

cji approved these changes Aug 6, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aasmall, cji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 6, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@aasmall looks like a typo wg-security-audit/ancillary-data/rapid-risk-assessments/etcd.md:47:20: "achived" is a misspelling of "achieved"

Also the helpdesk for the CLA stuff is here - https://github.com/kubernetes/community/blob/master/CLA.md#troubleshooting

@cblecker

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Please rebase and squash (this will fix the CLA issue)

@aasmall aasmall closed this Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.