Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psc rename #5597

Merged
merged 5 commits into from
Jun 20, 2021
Merged

Psc rename #5597

merged 5 commits into from
Jun 20, 2021

Conversation

lukehinds
Copy link
Contributor

@lukehinds lukehinds commented Mar 5, 2021 •
edited
Loading

After some discussions, we decided to put it to the steering
committee that a rename may be prudent, as 'Product' can be
confusing (suggests downstream).

The recommendation is Security Response Committee

Which issue(s) this PR fixes:
Ref: #5596

Luke Hinds added 2 commits March 5, 2021 12:32
Rename of Product Security Committee
9df121f 
After some discussions, we decided to put it to the steering
committee that a rename may be prudent, as 'Product' can be
confusing (suggests downstream).

The recommendation is Security Response Committee

Ref: #5596

Signed-off-by: Luke Hinds <lhinds@redhat.com>
Generate docs
c609825 
Signed-off-by: Luke Hinds <lhinds@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2021
@lukehinds
Copy link
Contributor Author

cc @kubernetes/product-security-committee
cc @kubernetes/steering-committee

mrbobbytables
mrbobbytables reviewed Mar 5, 2021
View reviewed changes
sigs.yaml Outdated Show resolved Hide resolved
@dims
Copy link
Member

dims commented Mar 5, 2021

+1 from me (with steering hat on)

cc @kubernetes/sig-security @kubernetes/sig-auth-misc

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 5, 2021
@nikhita
Copy link
Member

nikhita commented Mar 15, 2021

@lukehinds needs spelling fix to make pull-community-verify green + would need to remove the community-product-security directory manually

@nikhita
Copy link
Member

nikhita commented Mar 15, 2021

+1 from me (steering hat on)

cc @kubernetes/steering-committee

@nikhita nikhita added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Mar 15, 2021
Fix spelling mistake
518cfa3 
Signed-off-by: Luke Hinds <lhinds@redhat.com>
@lukehinds
Copy link
Contributor Author

/test pull-community-verify

@dims
Copy link
Member

dims commented Mar 15, 2021

one more step @lukehinds ... https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/community/5597/pull-community-verify/1371422385038692352

@nikhita
Copy link
Member

nikhita commented Mar 15, 2021

@lukehinds needs a run of make :)

@mrbobbytables
Copy link
Member

+1
One thing that will need to follow-up is changing all the various documentation sources - e.g. https://kubernetes.io/docs/reference/issues-security/security/

@liggitt
Copy link
Member

liggitt commented Mar 15, 2021

lgtm

@mrbobbytables mrbobbytables added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 15, 2021
@lukehinds
Copy link
Contributor Author

@lukehinds needs a run of make :)

How do I do that is that a prow command?

@nikhita
Copy link
Member

nikhita commented Mar 23, 2021

How do I do that is that a prow command?

It's not possible via a prow command, you'll need to run make locally

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021
Run make and merge latest
92927b1 
Signed-off-by: Luke Hinds <lhinds@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2021
@tallclair
Copy link
Member

lgtm

I'm a little worried about this causing some confusion in the short term, but I think longer term this name does a much better job of conveying our responsibilities.

How will we abbreviate this? SRC is maybe too common an abbreviation for "source". We could through "Kubernetes" in there to get "KSRC" or just "KSR". But maybe we really just need to avoid the abbreviation jargon...

@tallclair
Copy link
Member

/committee product-security
/remove-sig auth

@k8s-ci-robot k8s-ci-robot added the committee/security-response Denotes an issue or PR intended to be handled by the product security committee. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2021
Fix merge conflict
dc4b17e 
Signed-off-by: Luke Hinds <lhinds@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@lukehinds
Copy link
Contributor Author

@nikhita this should be in order now.

nikhita
nikhita approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold
for more reviews

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2021
@dims
Copy link
Member

dims commented Jun 10, 2021

/approve

@tabbysable
Copy link
Member

/lgtm I think this will make it easier for folks outside the community to find us when they need us

@nikhita
Copy link
Member

nikhita commented Jun 20, 2021

/lgtm

/hold cancel
lots of lgtms :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit ef108be into kubernetes:master Jun 20, 2021
alisondy pushed a commit to alisondy/community that referenced this pull request Jun 23, 2021
@lukehinds @alisondy
Psc rename (kubernetes#5597)
7c533ae 
* Rename of Product Security Committee

After some discussions, we decided to put it to the steering
committee that a rename may be prudent, as 'Product' can be
confusing (suggests downstream).

The recommendation is Security Response Committee

Ref: kubernetes#5596

Signed-off-by: Luke Hinds <lhinds@redhat.com>

* Generate docs

Signed-off-by: Luke Hinds <lhinds@redhat.com>

* Fix spelling mistake

Signed-off-by: Luke Hinds <lhinds@redhat.com>
@lukehinds lukehinds mentioned this pull request Jul 1, 2021
Merged
This was referenced Aug 23, 2021
Closed
Merged
spiffxp added a commit to spiffxp/k8s.io that referenced this pull request Sep 16, 2021
@spiffxp
groups: rename PSC to committee-security-response
f6695ad 
Related:
- Part of: kubernetes/community#5597
- Supercedes: kubernetes#2596
@spiffxp spiffxp mentioned this pull request Sep 16, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lukehinds, nikhita, vagobon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables left review comments

@nikhita nikhita nikhita approved these changes

@alisondy alisondy Awaiting requested review from alisondy

@dims dims Awaiting requested review from dims

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lukehinds @dims @nikhita @mrbobbytables @liggitt @tallclair @tabbysable @k8s-ci-robot