New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw block volume support #805

Closed
wants to merge 1 commit into
base: master
from

Conversation

@erinboyd
Contributor

erinboyd commented Jul 12, 2017

Design proposal for raw block via PV

@feiskyer

This comment has been minimized.

Show comment
Hide comment
@feiskyer

feiskyer Jul 13, 2017

Member

@erinboyd Seems the proposal is overlapping with local persistent storage, which including features like local block devices as a volume and local raw block device.

Member

feiskyer commented Jul 13, 2017

@erinboyd Seems the proposal is overlapping with local persistent storage, which including features like local block devices as a volume and local raw block device.

@fabiand

This proposal also looks pretty rough, and I'm missing details about how the raw block storage is now envisioned.

@erinboyd

This comment has been minimized.

Show comment
Hide comment
@erinboyd

erinboyd Jul 21, 2017

Contributor

@feiskyer @fabiand The local block devices mentioned raw devices are out of scope. The raw block device changes being proposed are for both local and network attached raw devices.

Contributor

erinboyd commented Jul 21, 2017

@feiskyer @fabiand The local block devices mentioned raw devices are out of scope. The raw block device changes being proposed are for both local and network attached raw devices.

@erinboyd

This comment has been minimized.

Show comment
Hide comment
@erinboyd

erinboyd Jul 24, 2017

Contributor

@screeley44 @msau42 @mtanino please review

Contributor

erinboyd commented Jul 24, 2017

@screeley44 @msau42 @mtanino please review

@mtanino

This comment has been minimized.

Show comment
Hide comment
@mtanino
Member

mtanino commented Jul 25, 2017

@mtanino

This comment has been minimized.

Show comment
Hide comment
@mtanino

mtanino Jul 26, 2017

Member

To access this proposal easily, could you update the title from "Raw block"
to like "[Proposal] Raw block volume support"?

Member

mtanino commented Jul 26, 2017

To access this proposal easily, could you update the title from "Raw block"
to like "[Proposal] Raw block volume support"?

@erinboyd erinboyd changed the title from Raw block to Raw block volume support Aug 2, 2017

@erinboyd

This comment has been minimized.

Show comment
Hide comment
@erinboyd

erinboyd Aug 3, 2017

Contributor
Contributor

erinboyd commented Aug 3, 2017

@erinboyd

This comment has been minimized.

Show comment
Hide comment
@erinboyd

erinboyd Aug 3, 2017

Contributor

@msau42 @mtanino @screeley44 please re-review changes according to comments

Contributor

erinboyd commented Aug 3, 2017

@msau42 @mtanino @screeley44 please re-review changes according to comments

@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Aug 3, 2017

Member

/cc

Member

jsafrane commented Aug 3, 2017

/cc

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane Aug 3, 2017

@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Aug 3, 2017

Member

/sig storage

Member

jsafrane commented Aug 3, 2017

/sig storage

Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
***This has implementation details that have yet to be determined. It is included in this proposal for completeness of design ****
## UC6:

This comment has been minimized.

@msau42

msau42 Aug 3, 2017

Member

How is this different from UC3?

@msau42

msau42 Aug 3, 2017

Member

How is this different from UC3?

This comment has been minimized.

@erinboyd

erinboyd Aug 4, 2017

Contributor

@msau42 UC6 uses a Storage Class and UC3 does not

@erinboyd

erinboyd Aug 4, 2017

Contributor

@msau42 UC6 uses a Storage Class and UC3 does not

Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
@jsafrane

I miss some technical details about how will we expose block devices to pods and how we make them usable by non-root processes.

# Non Goals
* Support all storage devices natively in upstream Kubernetes. Non-standard storage devices are expected to be managed using extension
mechanisms.

This comment has been minimized.

@jsafrane

jsafrane Aug 4, 2017

Member

What extension mechanism? flex? CSI?

@jsafrane

jsafrane Aug 4, 2017

Member

What extension mechanism? flex? CSI?

This comment has been minimized.

@erinboyd

erinboyd Aug 4, 2017

Contributor

@jsafrane I don't know. It's a non-goal so we haven't figured that out yet and isn't included in this design.

@erinboyd

erinboyd Aug 4, 2017

Contributor

@jsafrane I don't know. It's a non-goal so we haven't figured that out yet and isn't included in this design.

This comment has been minimized.

@resouer

resouer Oct 10, 2017

Member

For extension, flexvolume is a example.

@erinboyd Hypervisor based container runtime is one of best use cases here I think. xref https://github.com/kubernetes/frakti

@resouer

resouer Oct 10, 2017

Member

For extension, flexvolume is a example.

@erinboyd Hypervisor based container runtime is one of best use cases here I think. xref https://github.com/kubernetes/frakti

This comment has been minimized.

@erinboyd

erinboyd Oct 10, 2017

Contributor

thanks @resouer

@erinboyd

erinboyd Oct 10, 2017

Contributor

thanks @resouer

Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md
Show outdated Hide outdated contributors/design-proposals/raw-block-pv.md

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this pull request Nov 18, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351 

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

sttts pushed a commit to sttts/api that referenced this pull request Nov 18, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this pull request Nov 21, 2017

Merge pull request #55112 from mtanino/pr/BlockVolumesSupport-cmdline
Automatic merge from submit-queue (batch tested with PRs 55112, 56029, 55740, 56095, 55845). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Block volume: Command line printer update

**What this PR does / why we need it**:

Add cmdline printer support changes.

**Which issue this PR fixes**: 
Based on this proposal (kubernetes/community#805 & kubernetes/community#1265) and this feature issue: kubernetes/features#351

**Special notes for your reviewer**:

There are another PRs related to this functionality.

(#50457) API Change
(#53385) VolumeMode PV-PVC Binding change
(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(#55112) Block volume: Command line printer update
Plugins
(#51493) Block volumes Support: FC plugin update
(#54752) Block volumes Support: iSCSI plugin update

**Release note**:

```
NONE
```

/sig storage
/cc @msau42  @jsafrane @saad-ali  @erinboyd @screeley44 
@kubernetes/sig-storage-pr-reviews


- Command results
```
~/sample/storage/fc_loop/file % k get pv,pvc,pod                
NAME              CAPACITY   ACCESS MODES   VOLUME MODE   RECLAIM POLICY   STATUS    CLAIM                       STORAGECLASS   REASON    AGE
pv/block-pv0001   1Gi        RWO            Block         Retain           Bound     default/nginx-block-pvc01   slow                     2m
pv/file-pv0001    1Gi        RWO            Filesystem    Retain           Bound     default/nginx-file-pvc01    slow                     24s

NAME                    STATUS    VOLUME         CAPACITY   ACCESS MODES   VOLUME MODE   STORAGECLASS   AGE
pvc/nginx-block-pvc01   Bound     block-pv0001   1Gi        RWO            Block         slow           2m
pvc/nginx-file-pvc01    Bound     file-pv0001    1Gi        RWO            Filesystem    slow           25s

NAME                 READY     STATUS              RESTARTS   AGE
po/nginx-file-pod1   0/1       ContainerCreating   0          4s
po/nginx-pod1        1/1       Running             0          2m
 ~/sample/storage/fc_loop/file % k get pv,pvc,pod
NAME              CAPACITY   ACCESS MODES   VOLUME MODE   RECLAIM POLICY   STATUS    CLAIM                       STORAGECLASS   REASON    AGE
pv/block-pv0001   1Gi        RWO            Block         Retain           Bound     default/nginx-block-pvc01   slow                     2m
pv/file-pv0001    1Gi        RWO            Filesystem    Retain           Bound     default/nginx-file-pvc01    slow                     40s

NAME                    STATUS    VOLUME         CAPACITY   ACCESS MODES   VOLUME MODE   STORAGECLASS   AGE
pvc/nginx-block-pvc01   Bound     block-pv0001   1Gi        RWO            Block         slow           2m
pvc/nginx-file-pvc01    Bound     file-pv0001    1Gi        RWO            Filesystem    slow           40s

NAME                 READY     STATUS    RESTARTS   AGE
po/nginx-file-pod1   1/1       Running   0          19s
po/nginx-pod1        1/1       Running   0          2m

 ~/sample/storage/fc_loop/file % k describe pv/block-pv0001      
Name:            block-pv0001
Labels:          <none>
Annotations:     pv.kubernetes.io/bound-by-controller=yes
                 volume.beta.kubernetes.io/storage-class=slow
StorageClass:    slow
Status:          Bound
Claim:           default/nginx-block-pvc01
Reclaim Policy:  Retain
Access Modes:    RWO
VolumeMode:      Block
Capacity:        1Gi
Message:         
Source:
    Type:        FC (a Fibre Channel disk)
    TargetWWNs:  28000001ff0414e2
    LUN:         0
    FSType:      
    ReadOnly:    true
Events:          <none>

 ~/sample/storage/fc_loop/file % k describe pv/file-pv0001 
Name:            file-pv0001
Labels:          <none>
Annotations:     pv.kubernetes.io/bound-by-controller=yes
                 volume.beta.kubernetes.io/storage-class=slow
StorageClass:    slow
Status:          Bound
Claim:           default/nginx-file-pvc01
Reclaim Policy:  Retain
Access Modes:    RWO
VolumeMode:      Filesystem
Capacity:        1Gi
Message:         
Source:
    Type:        FC (a Fibre Channel disk)
    TargetWWNs:  28000001ff0414e2
    LUN:         0
    FSType:      
    ReadOnly:    true
Events:          <none>

 ~/sample/storage/fc_loop/file % k describe pvc/nginx-block-pvc01
Name:          nginx-block-pvc01
Namespace:     default
StorageClass:  slow
Status:        Bound
Volume:        block-pv0001
Labels:        <none>
Annotations:   pv.kubernetes.io/bind-completed=yes
               pv.kubernetes.io/bound-by-controller=yes
               volume.beta.kubernetes.io/storage-class=slow
Capacity:      1Gi
Access Modes:  RWO
VolumeMode:    Block
Events:        <none>
 ~/sample/storage/fc_loop/file % k describe pvc/nginx-file-pvc01 
Name:          nginx-file-pvc01
Namespace:     default
StorageClass:  slow
Status:        Bound
Volume:        file-pv0001
Labels:        <none>
Annotations:   pv.kubernetes.io/bind-completed=yes
               pv.kubernetes.io/bound-by-controller=yes
               volume.beta.kubernetes.io/storage-class=slow
Capacity:      1Gi
Access Modes:  RWO
VolumeMode:    Filesystem
Events:        <none>
```

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this pull request Nov 21, 2017

Merge pull request #53385 from screeley44/binding-volumetype
Automatic merge from submit-queue (batch tested with PRs 55938, 56055, 53385, 55796, 55922). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode binding logic update

Adds VolumeMode binding logic to pv-controller for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
this change is dependent on #50457 

cc @msau42 @jsafrane @mtanino @erinboyd

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this pull request Nov 22, 2017

Merge pull request #51494 from mtanino/pr/BlockVolumesSupport-volumem…
…anager

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Block volumes Support: CRI, volumemanager and operationexecutor changes

**What this PR does / why we need it**:
This PR contains following items to enable block volumes support feature.
- container runtime interface change
- volumemanager changes
- operationexecuto changes


**Which issue this PR fixes**:
Based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer**:

There are another PRs related to this functionality.
(#50457) API Change
(#53385) VolumeMode PV-PVC Binding change
(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(#55112) Block volume: Command line printer update
Plugins
(#51493) Block volumes Support: FC plugin update
(#54752) Block volumes Support: iSCSI plugin update

**Release note**:
```
Adds alpha support for block volume, which allows the users to attach raw block volume to their pod without filesystem on top of the volume.
```
/cc @msau42 @liggitt @jsafrane @saad-ali @erinboyd @screeley44

tengqm pushed a commit to tengqm/kubernetes that referenced this pull request Nov 22, 2017

Merge pull request kubernetes#51493 from mtanino/pr/BlockVolumesSuppo…
…rt-fc

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Block volumes Support: FC plugin update

**What this PR does / why we need it**:

Add interface changes to FC volume plugin to enable block volumes support feature.

**Which issue this PR fixes**: 
Based on this proposal (kubernetes/community#805 & kubernetes/community#1265) and this feature issue: kubernetes/features#351

**Special notes for your reviewer**:

This PR temporarily includes following changes except FC plugin change for reviewing purpose.
These changes will be removed from the PR once they are merged.
- (kubernetes#50457) API Change 
- (kubernetes#53385) VolumeMode PV-PVC Binding change
- (kubernetes#51494) Container runtime interface change, volumemanager changes, operationexecutor changes

There are another PRs related to this functionality.
(kubernetes#50457) API Change
(kubernetes#53385) VolumeMode PV-PVC Binding change
(kubernetes#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(kubernetes#55112) Block volume: Command line printer update
Plugins
(kubernetes#51493) Block volumes Support: FC plugin update
(kubernetes#54752) Block volumes Support: iSCSI plugin update

**Release note**:

```
FC plugin: Support for block volume 
- This enables uses to allow attaching raw block volume to their pod without filesystem through FC plugin.
```
@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Nov 23, 2017

Contributor

This PR hasn't been active in 30 days. It will be closed in 59 days (Jan 22, 2018).

cc @erinboyd @msau42

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

Contributor

k8s-merge-robot commented Nov 23, 2017

This PR hasn't been active in 30 days. It will be closed in 59 days (Jan 22, 2018).

cc @erinboyd @msau42

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

sttts pushed a commit to sttts/api that referenced this pull request Nov 27, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

sttts pushed a commit to sttts/api that referenced this pull request Nov 28, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

sttts pushed a commit to sttts/api that referenced this pull request Nov 28, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

sttts pushed a commit to sttts/api that referenced this pull request Nov 28, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

sttts pushed a commit to sttts/api that referenced this pull request Nov 28, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

k8s-publishing-bot pushed a commit to k8s-publishing-bot/api that referenced this pull request Nov 29, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc

k8s-publishing-bot pushed a commit to k8s-publishing-bot/api that referenced this pull request Dec 7, 2017

Merge pull request #50457 from screeley44/volumetype-api
Automatic merge from submit-queue (batch tested with PRs 50457, 55558, 53483, 55731, 52842). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

VolumeMode and VolumeDevice api

**What this PR does / why we need it:**
Adds volumeType api to PV and PVC for local block support based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer:**
There are other PR changes coming, this just simply creates the api fields
#53385  - binding logic changes dependent on this change

**Release note:**

NONE

Notes will be added in subsequents PR with the volume plugin changes, CRI, etc...

cc @msau42 @liggitt @jsafrane @mtanino @saad-ali @erinboyd

Kubernetes-commit: 5b32e4d24dd65573fc79b654c99f7c7f46de4ebc
@erinboyd

This PR has broken GitHub and has been duplicated to #1265

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this pull request Jan 10, 2018

Merge pull request #54752 from mtanino/pr/BlockVolumesSupport-iscsi
Automatic merge from submit-queue (batch tested with PRs 54230, 58100, 57861, 54752). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Block volumes Support: iSCSI plugin update

**What this PR does / why we need it**:

Add interface changes to iSCSI volume plugin to enable block volumes support feature.

**Which issue this PR fixes**: 
Based on this proposal (kubernetes/community#805 & kubernetes/community#1265) and this feature issue: kubernetes/features#351

**Special notes for your reviewer**:

This PR temporarily includes following changes except iSCSI plugin change for reviewing purpose.
These changes will be removed from the PR once they are merged.
- (#50457) API Change 
- (#51494) Container runtime interface change, volumemanager changes, operationexecutor changes

There are another PRs related to this functionality.
(#50457) API Change
(#53385) VolumeMode PV-PVC Binding change
(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(#55112) Block volume: Command line printer update
Plugins
(#51493) Block volumes Support: FC plugin update
(#54752) Block volumes Support: iSCSI plugin update

**Release note**:

```
NONE
```

@erinboyd erinboyd closed this Mar 5, 2018

dims pushed a commit to dims/openstack-cloud-controller-manager that referenced this pull request Mar 7, 2018

Merge pull request #51494 from mtanino/pr/BlockVolumesSupport-volumem…
…anager

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Block volumes Support: CRI, volumemanager and operationexecutor changes

**What this PR does / why we need it**:
This PR contains following items to enable block volumes support feature.
- container runtime interface change
- volumemanager changes
- operationexecuto changes


**Which issue this PR fixes**:
Based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer**:

There are another PRs related to this functionality.
(#50457) API Change
(#53385) VolumeMode PV-PVC Binding change
(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(#55112) Block volume: Command line printer update
Plugins
(#51493) Block volumes Support: FC plugin update
(#54752) Block volumes Support: iSCSI plugin update

**Release note**:
```
Adds alpha support for block volume, which allows the users to attach raw block volume to their pod without filesystem on top of the volume.
```
/cc @msau42 @liggitt @jsafrane @saad-ali @erinboyd @screeley44

dims pushed a commit to dims/openstack-cloud-controller-manager that referenced this pull request Mar 7, 2018

Merge pull request #51494 from mtanino/pr/BlockVolumesSupport-volumem…
…anager

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Block volumes Support: CRI, volumemanager and operationexecutor changes

**What this PR does / why we need it**:
This PR contains following items to enable block volumes support feature.
- container runtime interface change
- volumemanager changes
- operationexecuto changes


**Which issue this PR fixes**:
Based on this proposal (kubernetes/community#805) and this feature issue: kubernetes/features#351

**Special notes for your reviewer**:

There are another PRs related to this functionality.
(#50457) API Change
(#53385) VolumeMode PV-PVC Binding change
(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(#55112) Block volume: Command line printer update
Plugins
(#51493) Block volumes Support: FC plugin update
(#54752) Block volumes Support: iSCSI plugin update

**Release note**:
```
Adds alpha support for block volume, which allows the users to attach raw block volume to their pod without filesystem on top of the volume.
```
/cc @msau42 @liggitt @jsafrane @saad-ali @erinboyd @screeley44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment