This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
iptables: adapt for new iptables mode #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the new "iptables" mode of kube-proxy, packets addressed for a node port will get DNAT'ed to one of the endpoints. If that endpoint does not reside on the node, then flannel needs to be able to do the proxying to the endpoint. We generalize and add flannel rules for this. If the endpoint does reside on the node, then the packet will be addressed to the docker bridge, in which case we need to allow it. We modify the node rules for this.
jlebon
force-pushed
the
pr/adapt-for-iptables-mode
branch
from
835539a
to
a171eb6
Compare
|
Modified to keep the previous rules as well so that we support both userspace and iptables proxy modes. In the bigger picture, this might be something that should be offloaded to kube-proxy during startup. |
|
I just tested this w/ centos atomic & it works for me. Thanks! LGTM |
|
@redhat-k8s-bot test please |
|
Automatic merge from submit-queue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new "iptables" mode of kube-proxy, packets addressed for a node
port will get DNAT'ed to one of the endpoints. If that endpoint does not
reside on the node, then flannel needs to be able to do the proxying to
the endpoint. We generalize and add flannel rules for this.
If the endpoint does reside on the node, then the packet will be
addressed to the docker bridge, in which case we need to allow it. We
modify the node rules for this. The previous node rules there are no
longer needed (they were only relevant in the "userspace" mode).
This change is