New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial add of the scale-demo #226

Merged
merged 2 commits into from Nov 12, 2015

Conversation

Projects
None yet
3 participants
@brendandburns
Contributor

brendandburns commented Nov 10, 2015

@bgrant0607 for api object style
@kelseyhightower for demo guide

@googlebot googlebot added the cla: yes label Nov 10, 2015

Show outdated Hide outdated scale-demo/README.md
You can see what version you are running by running:
```console

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

console format looks for the $. Use shell if command only.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

console format looks for the $. Use shell if command only.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done.

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
kind: ReplicationController
metadata:
labels:
app: aggregator

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Several fields could be set by default, such as these labels.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Several fields could be set by default, such as these labels.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
app: aggregator
track: alpha
name: aggregator
namespace: default

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
name: aggregator
namespace: default
spec:
replicas: 1

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done.

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
spec:
replicas: 1
selector:
app: aggregator

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
template:
metadata:
name: aggregator
namespace: default

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
track: alpha
template:
metadata:
name: aggregator

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could elide.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
spec:
containers:
- command:
- /aggregator

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could be one line

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could be one line

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
- -sleep=1s
- -address=0.0.0.0:8080
image: gcr.io/google_containers/aggregator:2015-11-10-34b976a
imagePullPolicy: IfNotPresent

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could be elided.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Could be elided.

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
- -address=0.0.0.0:8080
image: gcr.io/google_containers/aggregator:2015-11-10-34b976a
imagePullPolicy: IfNotPresent
name: aggregator

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Probably should be first,

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Probably should be first,

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
imagePullPolicy: IfNotPresent
name: aggregator
ports:
- name: status

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

could be elided

@bgrant0607

bgrant0607 Nov 11, 2015

Member

could be elided

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/aggregator-rc.yaml
- name: status
containerPort: 8080
resources:
limits:

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

requests

@bgrant0607

bgrant0607 Nov 11, 2015

Member

requests

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

@brendandburns

brendandburns Nov 11, 2015

Contributor

done

Show outdated Hide outdated scale-demo/nginx-rc.yaml
kind: ReplicationController
metadata:
labels:
run: nginx

This comment has been minimized.

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Why not use run?

@bgrant0607

bgrant0607 Nov 11, 2015

Member

Why not use run?

This comment has been minimized.

@brendandburns

brendandburns Nov 11, 2015

Contributor

run doesn't allow you to set a custom request CPU. I could use --override, I suppose, but I think that's uglier.

@brendandburns

brendandburns Nov 11, 2015

Contributor

run doesn't allow you to set a custom request CPU. I could use --override, I suppose, but I think that's uglier.

@brendandburns

This comment has been minimized.

Show comment
Hide comment
@brendandburns

brendandburns Nov 11, 2015

Contributor

Comments addressed. I need to add the vegeta godep, I'll do that shortly.

Contributor

brendandburns commented Nov 11, 2015

Comments addressed. I need to add the vegeta godep, I'll do that shortly.

@bgrant0607

This comment has been minimized.

Show comment
Hide comment
@bgrant0607

bgrant0607 Nov 11, 2015

Member

Looks fine, thanks.

Member

bgrant0607 commented Nov 11, 2015

Looks fine, thanks.

@brendandburns

This comment has been minimized.

Show comment
Hide comment
@brendandburns

brendandburns Nov 12, 2015

Contributor

merging.

Contributor

brendandburns commented Nov 12, 2015

merging.

brendandburns added a commit that referenced this pull request Nov 12, 2015

Merge pull request #226 from brendandburns/fix
Initial add of the scale-demo

@brendandburns brendandburns merged commit 2c8a49a into kubernetes:master Nov 12, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
cla/google All necessary CLAs are signed

This was referenced Nov 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment