Don't claim copyright for future years #3233
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/unassign |
build/script.js
Outdated
| @@ -242,7 +242,7 @@ function patchBuildInformation() { | |||
| patterns: [ | |||
| {match: 'BUILD_GIT_COMMIT', replacement: commit}, | |||
| {match: 'BUILD_DASHBOARD_VERSION', replacement: conf.deploy.version.release}, | |||
| {match: 'BUILD_YEAR', replacement: new Date().getFullYear()}, | |||
| {match: 'BUILD_YEAR', replacement: "2018"}, | |||
There was a problem hiding this comment.
Instead of hard-coding the date here, instead I'd put it in build/conf.js and reference the new variable. Since this seems tied to the release/commit, look for the "version" variable and maybe add a "buildDate" attribute?
There was a problem hiding this comment.
actually, I think the 'build' part in the name can be misleading. It is meant to contain the date/year of the last source change.
Just wanted to keep the patch simple for the start.
Will push an update for using conf.js
When building the kubernetes-dashboard openSUSE package in future years, files differed because they contained something like this.latestCopyrightYear="2033" See https://reproducible-builds.org/ for why this matters. And https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated suggests that expiry should not be a concern anyway. kubernetes/kubernetes#59172 fixed this for kubernetes.
Codecov Report
@@ Coverage Diff @@
## master #3233 +/- ##
=======================================
Coverage 54.62% 54.62%
=======================================
Files 565 565
Lines 12424 12424
=======================================
Hits 6786 6786
Misses 5377 5377
Partials 261 261Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmwiedemann, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
When building the kubernetes-dashboard openSUSE package
in future years, files differed because they contained
something like
this.latestCopyrightYear="2033"
See https://reproducible-builds.org/ for why this matters.
And https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated suggests that expiry should not be a concern anyway.
kubernetes/kubernetes#59172 fixed this for kubernetes.