Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Security fix (CVE-2018-18264) #3400
Thanks to #3077 most of the work has been already done.
left a comment
thanks for the updates. a couple more comments, then this looks good to me. note that I haven't swept all callers, or verified there are no code paths that use the internal client to look up data to serve external requests
@@ Coverage Diff @@ ## master #3400 +/- ## ========================================== + Coverage 54.6% 54.66% +0.06% ========================================== Files 565 565 Lines 12434 12466 +32 ========================================== + Hits 6790 6815 +25 - Misses 5382 5389 +7 Partials 262 262
referenced this pull request
Dec 13, 2018
This improves the current state, though the comments at https://github.com/kubernetes/dashboard/pull/3400/files#discussion_r241135916 are still relevant
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing