Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend dependencies to support Kubernetes 1.13 and rewrite scaling functionality #3476

Merged
merged 11 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@maciaszczykm
Copy link
Member

commented Jan 3, 2019

Closes #3475.

@maciaszczykm maciaszczykm self-assigned this Jan 3, 2019

@maciaszczykm maciaszczykm changed the title Update backend dependencies to support Kubernetes 1.13 [WIP] Update backend dependencies to support Kubernetes 1.13 Jan 3, 2019

@k8s-ci-robot k8s-ci-robot requested review from cupofcat and PeWu Jan 3, 2019

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/S labels Jan 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 3, 2019

Codecov Report

Merging #3476 into master will decrease coverage by 0.05%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3476      +/-   ##
==========================================
- Coverage   47.94%   47.89%   -0.06%     
==========================================
  Files         164      164              
  Lines        7970     8016      +46     
  Branches       43       43              
==========================================
+ Hits         3821     3839      +18     
- Misses       3875     3899      +24     
- Partials      274      278       +4
Impacted Files Coverage Δ
src/app/backend/resource/deployment/deploy.go 45.11% <ø> (ø) ⬆️
src/app/backend/client/manager.go 65.26% <0%> (ø) ⬆️
src/app/backend/handler/apihandler.go 27.15% <0%> (-0.07%) ⬇️
src/app/backend/resource/pod/detail.go 56.25% <0%> (-1.2%) ⬇️
...c/app/backend/validation/validateimagereference.go 100% <100%> (ø) ⬆️
src/app/backend/settings/manager.go 54.16% <0%> (-15.84%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8452ee...d1fd750. Read the comment docs.

@maciaszczykm

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

Tested it doing stuff like:

  • deployment
  • search
  • viewing pod with environment variables
  • scaling deployments
  • scaling replica sets
  • scaling jobs
  • scaling stateful sets

I will create issues to cover the most important things coming in the next release (we need to replace dynamic client etc.).

maciaszczykm added some commits Jan 3, 2019

@maciaszczykm maciaszczykm changed the title [WIP] Update backend dependencies to support Kubernetes 1.13 Update backend dependencies to support Kubernetes 1.13 and rewrite scaling functionality Jan 3, 2019

@maciaszczykm maciaszczykm requested review from floreks and removed request for cupofcat and PeWu Jan 3, 2019

@maciaszczykm

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

Got it done. Tests might need some adjustments but everything works like before 🙂

maciaszczykm added some commits Jan 3, 2019

@maciaszczykm

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

@floreks PTAL

@floreks

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Jan 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floreks floreks merged commit b30e01f into kubernetes:master Jan 10, 2019

2 of 5 checks passed

codecov/patch 6.66% of diff hit (target 47.94%)
Details
codecov/project 47.89% (-0.06%) compared to d8452ee
Details
tide Not mergeable. Jobs codecov/patch, codecov/project have not succeeded.
Details
cla/linuxfoundation maciaszczykm authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maciaszczykm maciaszczykm deleted the maciaszczykm:vendor-update branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.