Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: requestes -> requests #4171

Merged
merged 5 commits into from Aug 7, 2019

Conversation

@kirillDanshin
Copy link
Contributor

commented Aug 6, 2019

No description provided.

kirillDanshin added some commits Aug 6, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 6, 2019

Welcome @kirillDanshin!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 6, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kirillDanshin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

I signed CLA

@kirillDanshin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Travis build is failed, but I don't think it's related to the change

@shu-mutou

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

/lgtm
I will restart travis job. The errors seem just networking issue.

@kirillDanshin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@shu-mutou Thanks.

Seems like github is currently unstable, maybe that's the reason why Travis build failed last time
Github 504

/assign @konryd

@codecov

This comment has been minimized.

Copy link

commented Aug 7, 2019

Codecov Report

Merging #4171 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
- Coverage   46.19%   46.18%   -0.02%     
==========================================
  Files         194      194              
  Lines        8999     8999              
  Branches       83       83              
==========================================
- Hits         4157     4156       -1     
- Misses       4586     4587       +1     
  Partials      256      256
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da372d...1e89167. Read the comment docs.

@jeefy

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, kirillDanshin, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1cb48fa into kubernetes:master Aug 7, 2019

3 of 5 checks passed

codecov/project 46.18% (-0.02%) compared to 8da372d
Details
tide Not mergeable.
Details
cla/linuxfoundation kirillDanshin authorized
Details
codecov/patch Coverage not affected when comparing 8da372d...1e89167
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.