Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use select component as theme picker #5789

Merged
merged 2 commits into from Feb 4, 2021
Merged

Use select component as theme picker #5789

merged 2 commits into from Feb 4, 2021

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Feb 4, 2021 •
edited

Zrzut ekranu 2021-02-4 o 16 03 08

Zrzut ekranu 2021-02-4 o 16 02 59

Zrzut ekranu 2021-02-4 o 16 02 53

Closes #5783.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2021
@maciaszczykm
Copy link
Member Author

/assign @floreks

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2021
@floreks
Copy link
Member

floreks commented Feb 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2021
@maciaszczykm maciaszczykm added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited

Codecov Report

Merging #5789 (462fe49) into master (b130997) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5789   +/-   ##
=======================================
  Coverage   43.81%   43.81%           
=======================================
  Files         215      215           
  Lines        9164     9164           
  Branches      112      112           
=======================================
  Hits         4015     4015           
  Misses       4883     4883           
  Partials      266      266

@k8s-ci-robot k8s-ci-robot merged commit 65a4428 into kubernetes:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefuly handle bigger amount of themes
3 participants
@maciaszczykm @floreks @k8s-ci-robot