From c4635161b3029d73d635b97c70b0540c694dfa3c Mon Sep 17 00:00:00 2001 From: Andrew Sy Kim Date: Tue, 12 Feb 2019 16:44:21 -0500 Subject: [PATCH] Revert "Improve cloud provider docs KEP" --- .../0019-cloud-provider-documentation.md | 182 ++++++++++++++++++ .../20180731-cloud-provider-documentation.md | 158 --------------- 2 files changed, 182 insertions(+), 158 deletions(-) create mode 100644 keps/sig-cloud-provider/0019-cloud-provider-documentation.md delete mode 100644 keps/sig-cloud-provider/20180731-cloud-provider-documentation.md diff --git a/keps/sig-cloud-provider/0019-cloud-provider-documentation.md b/keps/sig-cloud-provider/0019-cloud-provider-documentation.md new file mode 100644 index 00000000000..0e12c4fe4a0 --- /dev/null +++ b/keps/sig-cloud-provider/0019-cloud-provider-documentation.md @@ -0,0 +1,182 @@ +--- +kep-number: 0019 +title: Cloud Provider Documentation +authors: + - "@d-nishi" + - "@hogepodge" +owning-sig: sig-cloud-provider +participating-sigs: + - sig-docs + - sig-cluster-lifecycle + - sig-aws + - sig-azure + - sig-gcp + - sig-openstack + - sig-vmware +reviewers: + - "@andrewsykim" + - "@calebamiles" + - "@hogepodge" + - "@jagosan" +approvers: + - "@andrewsykim" + - "@hogepodge" + - "@jagosan" +editor: TBD +creation-date: 2018-07-31 +last-updated: 2018-11-16 +status: implementable +--- +## Transfer the responsibility of maintaining valid documentation for Cloud Provider Code to the Cloud Provider + +### Table of Contents + +* [Summary](#summary) +* [Motivation](#motivation) + * [Goals](#goals) + * [Non-Goals](#non-goals) +* [Proposal](#proposal) +* [User Stories [optional]](#user-stories) + * [Story 1](#story-1) + * [Story 2](#story-2) +* [Implementation Details/Notes/Constraints [optional]](#implementation-detailsnotesconstraints) +* [Risks and Mitigations](#risks-and-mitigations) +* [Graduation Criteria](#graduation-criteria) +* [Implementation History](#implementation-history) +* [Alternatives [optional]](#alternatives) + +### Summary +This KEP describes the documentation requirements for both in-tree and out-of-tree cloud controller managers. +These requirements are meant to capture critical usage documentation that is common between providers, set requirements for individual documentation, and create consistent standards across provider documentation. The scope of this document is limited to in-tree code that interfaces with kube-controller-manager, and out-of-tree code that interfaces with cloud-controller-manager + +### Motivation +Currently documentation for cloud providers for both in-tree and out-of-tree managers is limited in both scope, consistency, and quality. This KEP describes requirements, to be reached in the 1.12 release cycle, to create and maintain consistent documentation across all cloud provider manager code. By establishing these standards, SIG-Cloud-Provider will benefit the user-community by offering a single discoverable source of reliable documentation while relieving the SIG-Docs team from the burden of maintaining out-dated duplicated documentation. + +#### Goals +* Produce a common document that describes how to configure any in-tree cloud provider that can be reused by tools such as kubeadm, to create minimum viable Kubernetes clusters. + * Create documentation requirements on how to configure in-tree cloud providers. + * Produce documentation for every in-tree cloud provider. +* Provide a common document that describes how to configure any out-of-tree cloud-controller-manager by provider. + * Create documentation requirements on how to configure out-of-tree cloud providers. + * Produce documentation for every out-of-tree cloud provider. +* Maintain developer documentation for anyone wanting to build a new cloud-controller-manager. +* Generate confidence in SIG-docs to confidently link to SIG-Cloud-Provider documentation for all future releases. + +#### Non-Goals +This KEP is limited to documenting requirements for control plane components for in-tree implementation and cloud-controller-manager for out-of-tree implementation. It is not currently meant to document provider-specific drivers or code (example: Identity & access management: Keystone for Openstack, IAM for AWS etc). +SIG-Docs is not expected to produce or maintain any of this documentation. + +### Proposal + +#### In-Tree Documetation +Produce common documentation that describes how to configure any in-tree cloud provider that can be reused by tools such as kubeadm, to create minimum viable Kubernetes clusters. + +Kubernetes documentation lists details of current cloud-provider [here](https://kubernetes.io/docs/concepts/cluster-administration/cloud-providers/). Additional documentation [(1),](https://kubernetes.io/docs/concepts/services-networking/service/) [(2)](https://kubernetes.io/docs/tasks/administer-cluster/developing-cloud-controller-manager/) that link to cloud-provider code currently remains detached and poorly maintained. + +#### Requirement 1: +Provide validated manifests for kube-controller-manager, kubelet and kube-apiserver to enable a Kubernetes administrator to run cloud-provider= in-tree as is feasible today. Example manifests should be in the following directories: + +* kubernetes/kubernetes/pkg/cloudprovider/myprovider/docs/example-manifests/ + * [kube-apiserver.manifest](https://gist.github.com/d-nishi/1109fec153930e8de04a1bf160cacffb) + * [kube-controller-manager.manifest](https://gist.github.com/d-nishi/a41691cdf50239986d1e725af4d20033) + * [kubelet.manifest](https://gist.github.com/d-nishi/289cb82367580eb0cb129c9f967d903d) with [kubelet flags](https://gist.github.com/d-nishi/d7f9a1b59c0441d476646dc7cce7e811) + +The examples above are from a cluster running on AWS. + +#### Requirement 2: +Provide validated/tested descriptions with examples of controller features (annotations or labels) that are cloud-provider dependent that can be reused by any Kubernetes administrator to run `cloud-provider-` in-tree with `kube-controller-manager` as is described in the code Example: aws.go +These manifests should be regularly tested and updated post testing in the relevant provider location: + + +* kubernetes/kubernetes/pkg/cloudprovider/myprovider/docs/controllers/ + * node/ + * annotations.md - outlines what annotations the controller sets or reads from a node resource + * labels.md - outlines what labels the controller sets or read from a node resource + * README.md - outlines the purpose of this controller + * service/ + * annotations.md - outlines what annotations the controller sets or reads when managing a load balancer + * labels.md - outlines what labels the controller sets or read when managing a load balancer + * README.md - outlines the purpose of this controller + * persistentvolumelabel/ + * annotations.md - outlines what annotations the controller sets or read when managing persistent volumes + * labels.md - outlines what labels the controller sets when managing persistent volumes (previously known as PersistentVolumeLabel admission controller) + * README.md - outlines the purpose of this controller + * ... + +#### Out-of-Tree Documetation +Provide a common document that describes how to configure a Kubernetes cluster on any out-of-tree cloud provider. + +#### Requirement 1: + +Provide validated manifests for kube-controller-manager, kubelet, kube-apiserver and cloud-controller-manager to enable a Kubernetes administrator to run cloud-provider= out-of-tree as is feasible today. Example manifests should be in the following directories: + +* /path/to/out-of-tree-provider/docs/example-manifests/ + * [apiserver manifest](https://gist.github.com/andrewsykim/a7938e185d45e1c0ef760c375005fdef) + * [kube-controller-manager manifest](https://gist.github.com/andrewsykim/56ee2da95ade8386d3123e982d72aca9) + * [kubelet manifest](https://gist.github.com/andrewsykim/ac954b1657eb0e6a2e95af516594e2bd) + * [cloud controller manager DaemonSet](https://gist.github.com/andrewsykim/26e22e36471c1774e3626a70d2b7465f) + +The following examples are from provisioning a cluster on DigitalOcean using kops. + +#### Requirement 2: +List out the latest annotations or tags that are cloud-provider dependent and will be used by the Kubernetes administrator to run `cloud-provider-` out-of-tree with `cloud-controller-manager`. These manifests should be regularly tested and updated in the relevant provider location: + +* /path/to/out-of-tree-provider/docs/controllers/ + * node/ + * annotations.md - outlines what annotations the controller sets or reads from a node resource + * labels.md - outlines what labels the controller sets or read from a node resource + * README.md - outlines the purpose of this controller + * service/ + * annotations.md - outlines what annotations the controller sets or reads when managing a load balancer + * labels.md - outlines what labels the controller sets or read when managing a load balancer + * README.md - outlines the purpose of this controller + * persistentvolumelabel/ + * annotations.md - outlines what annotations the controller sets or read when managing persistent volumes + * labels.md - outlines what labels the controller sets when managing persistent volumes (previously known as PersistentVolumeLabel admission controller) + * README.md - outlines the purpose of this controller + * Other provider-specific-Controller e.g. Route controller for GCP + +### User Stories [optional] + +#### Story 1 +Sally is a devops engineer wants to run Kubernetes clouds across her on-premise environment and public cloud sites. She wants to use ansible or terraform to bring up Kubernetes v1.11. She references the cloud-provider documentation to understand how to enable in-tree provider code, and has a consistent set of documentation to help her write automation to target each individual cloud. + +#### Story 2 +Sam wants to add advanced features to external cloud provider. By consulting the external cloud provider documents, they are able to set up a development and test environment. Where previously documentation was inconsistent and spread across multiple sources, there is a single document that allows them to immediately launch provider code within their target cloud. + +### Implementation Details/Notes/Constraints [optional] +The requirements set forward need to accomplish several things: +* Identify and abstract common documentation across all providers. +* Create a consistent format that makes it easy to switch between providers. +* Allow for provider-specific documentation, quirks, and features. + +### Risks and Mitigations +This proposal relies heavily on individual cloud-provider developers to provide expertise in document generation and maintenance. Documentation can easily drift from implementation, making for a negative user experience. +To mitigate this, SIG-Cloud-Provider membership will work with developers to keep their documentation up to date. This will include a review of documents along release-cycle boundaries, and adherence to release-cycle deadlines. +SIG-Cloud-Provider will work with SIG-Docs to establish quality standards and with SIG-Node and SIG Cluster Lifecycle to keep common technical documentation up-to-date. + +### Graduation Criteria +This KEP represents an ongoing effort for the SIG-Cloud-Provider team. +* Immediate success is measured by the delivery of all goals outlined in the Goals (1) section. +* Long Term success is measured by the delivery of goals outlined in the Goals (2) section. +* Long Term success is also measured by the regular upkeep of all goals in Goals (1) and (2) sections. + +### Implementation History +Major milestones in the life cycle of a KEP should be tracked in Implementation History. Major milestones might include: +* the Summary and Motivation sections being merged signaling SIG acceptance +* the Proposal section being merged signaling agreement on a proposed design +* the date implementation started - July 25 2018 +* the first Kubernetes release where an initial version of the KEP was available - v1.12 +* the version of Kubernetes where the KEP graduated to general availability - v1.14 +* the date when the KEP was retired or superseded - NA + +### Alternatives [optional] +The Alternatives section is used to highlight and record other possible approaches to delivering the value proposed by a KEP. +* SIG docs could tag cloudprovider documentation as a blocking item for Kubernetes releases +* SIG docs could also assign SIG- leads to unblock cloudprovider documentation in the planning phase for the release. + +## Implementation History + +- July 31st 2018: KEP is merged as a signal of acceptance. Cloud providers should now be looking to add documentation for their provider according to this KEP. +- Nov 19th 2018: KEP has been in implementation stage for roughly 4 months with Alibaba Cloud, Azure, DigitalOcean, OpenStack and vSphere having written documentation for their providers according to this KEP. + diff --git a/keps/sig-cloud-provider/20180731-cloud-provider-documentation.md b/keps/sig-cloud-provider/20180731-cloud-provider-documentation.md deleted file mode 100644 index 0db5650cfbf..00000000000 --- a/keps/sig-cloud-provider/20180731-cloud-provider-documentation.md +++ /dev/null @@ -1,158 +0,0 @@ ---- -title: Cloud Provider Documentation -authors: - - "@d-nishi" - - "@hogepodge" - - "@andrewsykim" -owning-sig: sig-cloud-provider -participating-sigs: - - sig-docs - - sig-cluster-lifecycle - - sig-aws - - sig-azure - - sig-gcp - - sig-openstack - - sig-vmware -reviewers: - - "@andrewsykim" - - "@calebamiles" - - "@hogepodge" - - "@jagosan" -approvers: - - "@andrewsykim" - - "@hogepodge" - - "@jagosan" -editor: TBD -creation-date: 2018-07-31 -last-updated: 2019-02-12 -status: implementable ---- - -## Documentation Requirements for Kubernetes Cloud Providers - -### Table of Contents - -* [Documentation Requirements for Kubernetes Cloud Providers](#documentation-requirements-for-kubernetes-cloud-providers) - * [Table of Contents](#table-of-contents) - * [Summary](#summary) - * [Motivation](#motivation) - * [Goals](#goals) - * [Non-Goals](#non-goals) - * [Proposal](#proposal) - * [Proposed Format for Documetation](#proposed-format-for-documetation) - * [Requirement 1: Example Manifests](#requirement-1-example-manifests) - * [Requirement 2: Resource Management](#requirement-2-resource-management) - * [Requirement 3: Kubeadm Setup Guide](#requirement-3-kubeadm-setup-guide) - * [User Stories [optional]](#user-stories-optional) - * [Implementation Details/Notes/Constraints [optional]](#implementation-detailsnotesconstraints-optional) - * [Risks and Mitigations](#risks-and-mitigations) - * [Graduation Criteria](#graduation-criteria) - * [Alternatives [optional]](#alternatives-optional) -* [Implementation History](#implementation-history) - -### Summary -This KEP describes the documentation requirements for both in-tree and out-of-tree cloud providers. -These requirements are meant to ensure the usage and integration of cloud providers with the rest of the Kubernetes ecosystem is concise and clear and that documentation layout across providers is consistent. - -### Motivation -Currently documentation for cloud providers for both in-tree and out-of-tree managers is limited in both scope, consistency, and quality. This KEP describes requirements to create and maintain consistent documentation across all cloud providers. By establishing these standards, SIG Cloud Provider will benefit the user-community by offering a single discoverable source of reliable documentation while relieving the SIG-Docs team from the burden of maintaining content from various cloud providers across many Kubernetes versions. - -#### Goals - -* Create a single source of truth that outlines what documentation from each provider should cover. -* Ensure all Kubernetes cloud providers adhere to this doc format to provide a consistent experience for all users. -* Ensure SIG Docs can confidently link to documentation by any Kubernetes cloud provider on any future releases. - -#### Non-Goals - -* Where in the Kubernetes website the cloud provider documentation will be hosted. This should be a decision made by SIG Docs based on the content given by each cloud provider. -* Cloud provider documentation outside the scope of Kubernetes. - -### Proposal - -#### Proposed Format for Documetation - -The following is a proposed format of how docs should be added to `k8s.io/cloud-provider-*` repositorties. - -#### Requirement 1: Example Manifests - -Provide validated manifests for every componeont required for both in-tree and out-of-tree versions of your cloud provider. The contents of the manifest should contain a DaemonSet resource that runs these components on the control plane nodes or a systemd unit file. The goal of the example manifests is to provide enough details on how each component in the cluster should be configured. This should provide enough context for users to build their own manifests if desired. - -``` -cloud-provider-foobar/ -├── ... -├── ... -├── docs -│   └── example-manifests -│   └── in-tree/ -│   ├── apiserver.manifest -│   ├── kube-controller-manager.manifest -│   ├── kubelet.manifest -│   └── out-of-tree/ -│   ├── apiserver.manifest -│   ├── kube-controller-manager.manifest -│   ├── cloud-controller-manager.manifest -│   ├── kubelet.manifest -``` - -#### Requirement 2: Resource Management - -List the latest annotations and labels that are cloud-provider dependent and can be used by the Kubernetes administrator. The contents of these files should be kept up-to-date as annotations/labels are deprecated/removed/added/updated. Labels and annotations should be grouped based on the resource they are applied to. For example the label `beta.kubernetes.io/instance-type` is applied to nodes so it should be added to `k8s.io/cloud-provider-foobar/docs/node/labels.md`. - -``` -cloud-provider-foobar/ -├── ... -├── ... -├── docs -│   └── resources -│   └── node/ -│   ├── labels.md # outlines what annotations that can be used on a Node resource -│   ├── annotations.md # outlines what annotations that can be used on a Node resource -│   ├── README.md # outlines any other cloud provider specific details worth mentioning regarding Nodes -│   └── service/ -│   ├── labels.md # outlines what annotations that can be used on a Service resource -│   ├── annotations.md # outlines what annotations that can be used on a Service resource -│   ├── README.md # outlines any other cloud provider specific details worth mentioning regarding Services -│   └── persistentvolumes/ -│   ├── ... -│   └── ... -│   └── ... -``` - -#### Requirement 3: Kubeadm Setup Guide - -Add a setup guide on how to configure your cloud provider with kubeadm. The setup guide may reference another blog post or tutorial that covers how to do this. -``` -cloud-provider-foobar/ -├── ... -├── ... -├── docs -│   └── kubeadm/ -│   ├── setup.md # instructions on how to setup kubeadm with cloud provider enabled (both in-tree and out-of-tree) -``` - -### User Stories [optional] - -### Implementation Details/Notes/Constraints [optional] - -The requirements above lists the bare minimum documentation that any cloud provider in the Kubernetes ecosystem should have. Cloud providers may choose to add more contents under the `docs/` directory as they see fit. - -### Risks and Mitigations - -There are no risks and mitigation with respect to adding documentation for cloud providers. If there are any, they would already exist in the various places the cloud provider docs exists today and implementing this KEP would not increase those risks. - -### Graduation Criteria - -* All cloud providers have written docs that adhere to the format specified in this KEP. -* SIG Docs is consuming docs written by each provider in a way that is easily consumable for Kubernetes' users. - -### Alternatives [optional] - -* SIG Docs can be solely responsible for writing documentation around integrating Kubernetes with the existing cloud providers. This alternative would not be efficient because it would require SIG Docs to understand the context/scope of any cloud provider work that happens upstream. Developers who work with cloud provider integrations are most fit to write the cloud provider integration docs. - -## Implementation History - -- July 31st 2018: KEP is merged as a signal of acceptance. Cloud providers should now be looking to add documentation for their provider according to this KEP. -- Nov 19th 2018: KEP has been in implementation stage for roughly 4 months with Alibaba Cloud, Azure, DigitalOcean, OpenStack and vSphere having written documentation for their providers according to this KEP. -- Feb 12th 2019: KEP has been updated to state the implementation details and goals more clearly -