Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CRI-ContainerD on Windows #1001

Closed
20 of 26 tasks
PatrickLang opened this issue Apr 25, 2019 · 73 comments
Closed
20 of 26 tasks

Support CRI-ContainerD on Windows #1001

PatrickLang opened this issue Apr 25, 2019 · 73 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@PatrickLang
Copy link
Contributor

PatrickLang commented Apr 25, 2019

Enhancement Description

  • One-line enhancement description: Support CRI-ContainerD on Windows
  • KEP: 20190424-windows-cri-containerd
  • Primary contact (assignee): @marosset
  • Responsible SIGs: sig-windows, sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.18
    • Beta release target (x.y): 1.19 or later
    • Stable release target (x.y): 1.20 or later

PRs & Bugs

The most up-to-date list is on this project board https://github.com/orgs/kubernetes/projects/34.

PRs for 1.18 alpha

Completed PRs/Issues - these span work in 1.17/18

PRs for beta

PRs for GA

Bugs for beta (presumably 1.19)

Bugs for GA

Bugs requiring Windows OS fixes

Tests

Based on Windows Server 2019

/sig windows
/sig node
/kind feature

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 25, 2019

/milestone v1.15
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 25, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 25, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @PatrickLang

@kacole2
Copy link
Member

kacole2 commented Apr 29, 2019

@PatrickLang , Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@makoscafee
Copy link
Member

makoscafee commented May 10, 2019

Hey, @PatrickLang 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@kacole2
Copy link
Member

kacole2 commented May 28, 2019

Hi @PatrickLang . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@kacole2
Copy link
Member

kacole2 commented May 30, 2019

Hi @PatrickLang , today is code freeze. I do not see a reply for any PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@PatrickLang PatrickLang added this to Backlog in SIG-Windows May 30, 2019
@PatrickLang PatrickLang moved this from Backlog to Backlog (v1.16) in SIG-Windows May 30, 2019
@PatrickLang
Copy link
Contributor Author

PatrickLang commented May 30, 2019

/milestone v1.16
Still not ready. PRs and testing are still in progress. Pushing out.

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.15, v1.16 May 30, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 31, 2019
@evillgenius75
Copy link

evillgenius75 commented Jul 8, 2019

Hi @PatrickLang , I'm a 1.16 Enhancement Shadow. Is this feature going to be released in alpha stage in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jul 9, 2019
@PatrickLang
Copy link
Contributor Author

PatrickLang commented Jul 30, 2019

/milestone v1.17
Not likely to complete in 1.16, still having issues getting containerd work on Windows moving forward.

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.16, v1.17 Jul 30, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 30, 2019
@marosset
Copy link
Contributor

marosset commented Sep 11, 2020

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 11, 2020
@lippertmarkus
Copy link

lippertmarkus commented Sep 17, 2020

Is there a documentation similar to https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes/ on how to set up a node with containerd with a CNI and join it to the cluster? I was able to install containerd and join the node by kubeadm join with --cri-socket "npipe:////./pipe/containerd-containerd" but after adding flannel as CNI I get the following when scheduling a workload:

Warning  FailedCreatePodSandBox  4m1s                 kubelet, minion    Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf": error while ProvisionEndpoint(2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf_flannel.4096,7BB417A4-9BC3-4006-9374-D9EC6DA41D32,2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf): failed to find HNSEndpoint 2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf_flannel.4096: Endpoint 2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf_flannel.4096 not found

When using host-local CNI instead the pods at least start successfully but don't have any network adapters when running ipconfig.

@TBBle
Copy link

TBBle commented Sep 17, 2020

That doesn't look like a containerd-related issue, but that Flannel was unable to set up the endpoint. Check the logs of the kube-flannel-ds-windows-amd64 pod to see if it gave you any useful HNS-related failure messages.

@jsturtevant
Copy link
Contributor

jsturtevant commented Sep 17, 2020

@lippertmarkus Could you open up a separate issue to discuss? Don't want to pollute the enhancement issue.

@MorrisLaw
Copy link
Member

MorrisLaw commented Sep 27, 2020

Hey @PatrickLang @marosset 👋 -- 1.20 Enhancements Shadow here. Just a friendly reminder that the Enhancements Freeze deadline is October 6th.

Do we still plan on graduating this to GA in 1.20?

Also, if time permits, can we please update the KEP to match the new format detailed in https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template?

Thanks for all of your hard work everyone!

Regards,
Jeremy

@marosset
Copy link
Contributor

marosset commented Sep 28, 2020

@MorrisLaw - Yes we plan to go GA in 1.20.
I can update the KEP to match the new format this week.

@MorrisLaw
Copy link
Member

MorrisLaw commented Oct 12, 2020

Hi @marosset,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best,
Jeremy

@marosset
Copy link
Contributor

marosset commented Oct 12, 2020

Thanks @MorrisLaw!
I updated the initial issue comment to include PRs/bugfixes needed for GA.

@eagleusb
Copy link
Member

eagleusb commented Oct 22, 2020

Hello @marosset 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@eagleusb
Copy link
Member

eagleusb commented Nov 2, 2020

Hi @marosset 👋

The docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

Thanks !

@marosset
Copy link
Contributor

marosset commented Nov 3, 2020

Hi @eagleusb Here is the doc PR for graduating to stable
kubernetes/website#24862

@MorrisLaw
Copy link
Member

MorrisLaw commented Nov 10, 2020

Hey @marosset 👋

Is this PR the last PR remaining to get this to GA in 1.20 or are there some other PRs that we should explicitly link to this issue?

Please keep in mind that we have these upcoming dates:

If we miss the the code freeze, an exception will need to be made if we want to include it in the 1.20 milestone.

If there are some relevant k/k PRs, please link it here so we can accurately track them. Thank you Mark!

@marosset
Copy link
Contributor

marosset commented Nov 10, 2020

@MorrisLaw I linked one more PR for 1.20 (kubernetes/kubernetes#96396)
This is approved and I'm finishing up a little bit of extra manual validation around this right now.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Hi @marosset

It looks like all the PRs are finished. How does kubernetes/kubernetes#70189 fit in?

Are you expecting to fix this as well? Or fix at a later date?

Thanks!
Kirsten

@marosset
Copy link
Contributor

marosset commented Nov 12, 2020

Hi @kikisdeliveryservice We will need to address that at a later date as fixing this requires an Windows OS fix that is not yet released yet. This functionality also doesn't work with any other container runtimes on Windows so we are not treating it as a blocker from declaring containerD support on Windows stable.

The OS fixes are expected to be available in Nov or Dec 2020 so we'll target fixing kubernetes/kubernetes#70189 in v1.21

@michmike - FYI

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Great thanks for the update!

@marosset
Copy link
Contributor

marosset commented Dec 9, 2020

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2020

@marosset: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG-Windows automation moved this from In Progress (v1.21) to Done (v1.21) Dec 9, 2020
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests