Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving kubectl package code to staging #1020

Closed
soltysh opened this issue Apr 30, 2019 · 53 comments
Closed

Moving kubectl package code to staging #1020

soltysh opened this issue Apr 30, 2019 · 53 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@soltysh
Copy link
Contributor

soltysh commented Apr 30, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Moving kubectl package code to staging
  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
    https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/kubectl-staging.md
  • Primary contact (assignee): seans3, soltysh, pwittrock
  • Responsible SIGs: sig-cli
  • Enhancement target (which target equals to which milestone):
    There are no particular milestones to be achieved here, the end goal is to split kubectl into a separate repository but that will be outlined in separate enhancement.
@soltysh soltysh added this to the v1.15 milestone Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 30, 2019
@soltysh soltysh added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 30, 2019
@soltysh soltysh added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Apr 30, 2019

/stage stable
/kind feature

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status kind/feature Categorizes issue or PR as related to a new feature. labels Apr 30, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 30, 2019
@makoscafee
Copy link
Member

makoscafee commented May 10, 2019

Hey, @soltysh 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@kacole2
Copy link
Member

kacole2 commented May 28, 2019

Hi @soltysh . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@kacole2
Copy link
Member

kacole2 commented May 30, 2019

Hi @soltysh , today is code freeze. I do not see a reply for any PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@kacole2
Copy link
Member

kacole2 commented May 31, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 31, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 8, 2019

Hi @soltysh , We're beginning the 1.16 Enhancement collection. Is this going to be moving to stable in 1.16? Enhancement Freeze is 7/30.

@kcmartin
Copy link

kcmartin commented Oct 2, 2019

Hello @soltysh -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

Monday, September 23 - Release Cycle Begins
Tuesday, October 15, EOD PST - Enhancements Freeze
Thursday, November 14, EOD PST - Code Freeze
Tuesday, November 19 - Docs must be completed and reviewed
Monday, December 9 - Kubernetes 1.17.0 Released

@fejta-bot
Copy link

fejta-bot commented Dec 31, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@palnabarun
Copy link
Member

palnabarun commented Jan 9, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jan 15, 2020

Hey there @soltysh -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be implemented in 1.18?

The current release schedule is:

Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

@soltysh
Copy link
Contributor Author

soltysh commented Jan 21, 2020

@johnbelamaric this is still on-going work, it's not finished but we're actively working on it. It described in details in https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/kubectl-staging.md

@palnabarun palnabarun added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 29, 2020
@palnabarun palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jul 8, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @soltysh !

Enhancements Lead here, do you still intend to target this for stable in 1.20?

Thanks!
Kirsten

@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 24, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 24, 2020

Moving this to tracked since after digging I see that there is an active PR: kubernetes/kubernetes#92507

@kikisdeliveryservice kikisdeliveryservice removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 27, 2020
@MorrisLaw
Copy link
Member

MorrisLaw commented Sep 28, 2020

Hi @soltysh, do we still plan to target this for stable in 1.20? I notice there is a do-not-merge/hold tag on the previously mentioned PR: kubernetes/kubernetes#92507.

Also, time permitting, can we please update the KEP to the new format detailed here https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template? The Enhancements Freeze deadline for that update would be October 6th.

Thank you everyone for your work on this!

Regards,
Jeremy

@soltysh
Copy link
Contributor Author

soltysh commented Sep 29, 2020

Hi @soltysh, do we still plan to target this for stable in 1.20? I notice there is a do-not-merge/hold tag on the previously mentioned PR: kubernetes/kubernetes#92507.

This is in-progress, it's currently waiting for the repo creation which should happen in the next few days.

Overall - yes, once the above merges we're hoping to split the code that's blocking us and should move to staging fully.

/milestone v1.20

@soltysh
Copy link
Contributor Author

soltysh commented Sep 29, 2020

Updated KEP to the new template is in #2027

@MorrisLaw
Copy link
Member

MorrisLaw commented Oct 1, 2020

Thank you for updating the KEP to the new format @soltysh ! I just saw that it merged 💯

@MorrisLaw
Copy link
Member

MorrisLaw commented Oct 12, 2020

Hi @soltysh ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Regards,
Jeremy

@soltysh
Copy link
Contributor Author

soltysh commented Oct 13, 2020

Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline

No docs are required for this particular enhacement. This is only about internal code organization.

@somtochiama
Copy link
Member

somtochiama commented Oct 21, 2020

Hello @soltysh @seans3 @pwittrock, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@soltysh
Copy link
Contributor Author

soltysh commented Oct 22, 2020

Like mentioned before, we're not planning any doc changes, this is modifying internal code.

@somtochiama
Copy link
Member

somtochiama commented Oct 26, 2020

All right. Noted!

@annajung
Copy link
Member

annajung commented Nov 2, 2020

Hi @soltysh

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@soltysh
Copy link
Contributor Author

soltysh commented Nov 3, 2020

@MorrisLaw
Copy link
Member

MorrisLaw commented Nov 10, 2020

Hey @soltysh 👋

Friendly reminder that, in order to make the 1.20 milestone, we have to have k/k PR #96190 in by code freeze or an exception will need to be made.

Important upcoming date:

Thank you!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

@soltysh looks like kubernetes/kubernetes#96190 is fully approved and passing, does it need to be rekicked or something to merge? Actually looking closer it's rerunning bazel test I guess..

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

The above PR merged! Looks like this is finished for 1.20 code freeze. 👍

@annajung
Copy link
Member

annajung commented Jan 7, 2021

Hi @soltysh 1.21 Enhancement Lead here.

Can you update the kep.yaml to reflect a status of implemented:

Once that merges, we can close out this issue.

@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Jan 21, 2021

I'll be updating that next week.

@annajung
Copy link
Member

annajung commented Feb 16, 2021

Hey @soltysh, a friendly reminder to update the kep.yaml to close this issue out. thanks!

@soltysh
Copy link
Contributor Author

soltysh commented Feb 17, 2021

@annajung just updated, see linked PR where I also tagged you.

@annajung
Copy link
Member

annajung commented Feb 17, 2021

Looks like it was just merged! Thank you @soltysh
closing out this issue now since this enhancement is complete.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 17, 2021

@annajung: Closing this issue.

In response to this:

Looks like it was just merged! Thank you @soltysh
closing out this issue now since this enhancement is complete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests