Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotas for Ephemeral Storage #1029

Open
RobertKrawitz opened this issue Apr 30, 2019 · 67 comments
Open

Quotas for Ephemeral Storage #1029

RobertKrawitz opened this issue Apr 30, 2019 · 67 comments
Assignees
@pacoxu
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone
v1.25

Comments

@RobertKrawitz
Copy link
Contributor

RobertKrawitz commented Apr 30, 2019 •
edited by kikisdeliveryservice

Enhancement Description

  • Use filesystem quotas to monitor local ephemeral storage utilization
  • Kubernetes Enhancement Proposal: 1029-ephemeral-storage-quotas
  • Primary contact (assignee): @RobertKrawitz
  • Responsible SIGs: SIG-Node
  • Reviewer(s) - @dashpole @derekwaynecarr
  • Approver: #derekwaynecarr @dchen1107
  • Enhancement target (which target equals to which milestone):
    • Alpha release target 1.15
    • Beta release target TBD
    • Stable release target TBD
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 30, 2019
@RobertKrawitz
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2019
@derekwaynecarr
Copy link
Member

per sig-node discussion, this is good.

the kep will merge here: #646

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 30, 2019
@kacole2
Copy link
Member

kacole2 commented May 1, 2019

@RobertKrawitz This is OK to track for 1.15. However, please update the KEP with established graduation criteria for Beta and Alpha when possible.

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 1, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 1, 2019
@makoscafee
Copy link
Member

Hey, @RobertKrawitz @derekwaynecarr 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@RobertKrawitz
Copy link
Contributor Author

Yes, this will require new documentation.

I will open the website PR today.

@kacole2
Copy link
Member

kacole2 commented May 28, 2019

Hi @RobertKrawitz @derekwaynecarr . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@makoscafee
Copy link
Member

Hey, @RobertKrawitz @derekwaynecarr .Just a friendly reminder we're looking for at least a draft/placeholder PR against k/website (branch dev-1.15) due by Thursday, May 30th 2019 @ EOD PST.

@RobertKrawitz
Copy link
Contributor Author

@makoscafee The k/website PR is kubernetes/website#14268

@kacole2
Copy link
Member

kacole2 commented May 30, 2019 •
edited

Hi @RobertKrawitz @derekwaynecarr , today is code freeze. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@RobertKrawitz
Copy link
Contributor Author

The PR for this is kubernetes/kubernetes#66928

@RobertKrawitz
Copy link
Contributor Author

/hold cancel

@Random-Liu Random-Liu mentioned this issue Jun 11, 2019
Closed
This was referenced Jun 14, 2019
Closed
Closed
@kacole2
Copy link
Member

kacole2 commented Jul 8, 2019 •
edited

Hi @RobertKrawitz , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 kacole2 modified the milestones: v1.15, v1.16 Jul 15, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 15, 2019
@kacole2 kacole2 removed this from the v1.16 milestone Jul 15, 2019
@kcmartin
Copy link

kcmartin commented Oct 2, 2019

Hello @RobertKrawitz -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@palnabarun
Copy link
Member

/remove-lifecycle stale

@pacoxu
Copy link
Member

pacoxu commented Jun 21, 2022

Thanks, @Priyankasaggu11929
The KEP update is waiting for review from sig-node. The PRR review was passed.
@kubernetes/sig-node-feature-requests

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 21, 2022
@Priyankasaggu11929
Copy link
Member

Hey @pacoxu, thanks for the prompt update. The Open PR still misses updating the Test Plan Section as per required details mentioned here

Could you please update the PR with the same. Thank you so much! 🙂

@pacoxu
Copy link
Member

pacoxu commented Jun 21, 2022

Updated in 45a80c4. Thanks.

@Priyankasaggu11929
Copy link
Member

With KEP PR #2697 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as Tracked. Thank you so much! 🙂

@sethmccombs
Copy link

Hello @pacoxu! 👋,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 21, 2022 •
edited

Hi @pacoxu 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@pacoxu
Copy link
Member

pacoxu commented Jul 26, 2022 •
edited

@Priyankasaggu11929 Thanks for reminding me.
The PR is waiting for approval. And there is a small log improvement pr in kubernetes/kubernetes#107490 for this feature as well.

@pacoxu
Copy link
Member

pacoxu commented Jul 29, 2022

The PRs were merged. I will open a website update pr later.

@Priyankasaggu11929
Copy link
Member

Thank you so much for the update, @pacoxu.

With the PRs merged, the enhancement is ready for 1.25 code freeze. The status is now marked as tracked. 🚀

Merged
@pacoxu
Copy link
Member

pacoxu commented Aug 27, 2022

Openshift team meet a bug with this feature after we enable it by default in kubernetes/kubernetes#112076. And @rphillips raise a pr to revert this feature to alpha.

@kikisdeliveryservice
Copy link
Member

@pacoxu Please update the enhancement as it still shows it as being beta in 1.25: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1029-ephemeral-storage-quotas/kep.yaml

cc: @sftim

Merged
kikisdeliveryservice added a commit to kikisdeliveryservice/k8s-website that referenced this issue Aug 29, 2022
@kikisdeliveryservice
Revert: promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta
96a8fde 
This feature has been reverted to alpha in master and 1.25.
Related-to: kubernetes/kubernetes#112076
Related-to: kubernetes/kubernetes#112078
Related-to: kubernetes/enhancements#1029
Merged
kikisdeliveryservice added a commit to kikisdeliveryservice/k8s-website that referenced this issue Aug 30, 2022
@kikisdeliveryservice
Revert: promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta
04f9794 
This feature has been reverted to alpha in master and 1.25.
Related-to: kubernetes/kubernetes#112076
Related-to: kubernetes/kubernetes#112078
Related-to: kubernetes/enhancements#1029
@pacoxu
Copy link
Member

pacoxu commented Aug 30, 2022

Wasn't it reverted to beta because of problems?

I have tried to promote it to beta in v1.25 and openshift found a regression issue on it. Currently, v1.25.1 and v1.26 will revert it to alpha. Only this feature is in beta only in v1.25.0.

@pacoxu pacoxu mentioned this issue Aug 30, 2022
Merged
@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@pacoxu pacoxu mentioned this issue Sep 21, 2022
Open
10 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2022
@pacoxu
Copy link
Member

pacoxu commented Dec 20, 2022

/remove-lifecycle stale
A related issue: kubernetes/kubernetes#114506

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2022
@pacoxu
Copy link
Member

pacoxu commented Jan 13, 2023

If kubernetes/kubernetes#112624 can fix the bug we meet in v1.25.0, can we re-promote this feature to beta?

@pacoxu
Copy link
Member

pacoxu commented Feb 2, 2023 •
edited

There are some discussions about this feature in the last sig node meetings.

Why do we have this feature?: we don’t have an efficient way to track disk usage

I prefer to promote this feature if the blocking bugs(kubernetes/kubernetes#112081) are fixed. The reason is that du in some scenarios will hang or take too much time. It happens in our customers' clusters and we want to alter it to a stable quick way for that. This is one of the solutions.

Of course, there may be some other ways.

@rphillips: user can change the project id of a directory which becomes a security problem.

This is one of the reasons that @rphillips asked for deprecating this feature as it is not promoted to beta for a long time. Should we open an issue to track this security problem?

This was referenced Feb 2, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacoxu pacoxu

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Milestone
v1.25
Development

No branches or pull requests