Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable Fields API #1101

Open
apelisse opened this issue Jun 12, 2019 · 49 comments
Open

Immutable Fields API #1101

apelisse opened this issue Jun 12, 2019 · 49 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@apelisse
Copy link
Member

apelisse commented Jun 12, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Ability to mark fields as immutable in APIs with automatic verification.
  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR): api-machinery: KEP for immutable fields #1265
  • Primary contact (assignee): apelisse
  • Responsible SIGs: sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) N/A
    • Beta release target (x.y) 1.16
    • Stable release target (x.y) 1.18
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 12, 2019
@apelisse
Copy link
Member Author

apelisse commented Jun 12, 2019

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 12, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

@apelisse is this going to go straight to Beta in 1.16?

/milestone v1.16
/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 9, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 9, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 29, 2019

@apelisse this is a reminder that Enhancement Freeze is tomorrow and this KEP #1099 needs to be merged by EOD. If not, it will be removed from the milestone. Thanks

@apelisse
Copy link
Member Author

apelisse commented Jul 29, 2019

Thanks for the reminder Kendrick, work is actually going-on (apelisse#1) and mostly driven by @sttts
We'll try to mark it implementable before tomorrow!

@kacole2
Copy link
Member

kacole2 commented Jul 31, 2019

@apelisse @sttts

Enhancement Freeze has passed for 1.16. The KEP at #1099 was never merged and now this is being removed from the 1.16 milestone. If this would like to be re-added, please file an exception and it will require approval from the release lead.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Jul 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 31, 2019
@apelisse
Copy link
Member Author

apelisse commented Jul 31, 2019

Thanks Kendrick, we've decided to take our time and do it well! We're planning to do it for the next release

@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Hey there @apelisse , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@sttts
Copy link
Contributor

sttts commented Oct 2, 2019

Yes, please add it to the tracking sheet. We are on it.

@palnabarun
Copy link
Member

palnabarun commented Oct 2, 2019

Awesome. 🎉

Just FYI, for the enhancement to be accepted into the release:

  1. KEP PR must be merged
  2. KEP should be in an implementable state
  3. KEP should have test plans and graduation criteria.

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 2, 2019
@palnabarun palnabarun added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 2, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 10, 2019

Hi @sttts @apelisse , just a friendly reminder. We are just 5 days away from the Enhancements Freeze.

I see that the KEP PR is still not merged and is in the provisional state.

For the KEP to be considered for 1.17,

  1. KEP PR must be merged
  2. KEP should be in an implementable state
  3. KEP should have test plans and graduation criteria.

@palnabarun
Copy link
Member

palnabarun commented Oct 16, 2019

@sttts @apelisse -- Unfortunately the deadline for the 1.17 Enhancement freeze has passed and the KEP is still not merged and in the provisional state. For now, this is being removed from the milestone and 1.17 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 16, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 16, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.17 milestone Oct 16, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 17, 2019

@stts @apelisse Since, the exception request filed here was accepted, I'm adding back the enhancement to the tracking sheet.

@palnabarun
Copy link
Member

palnabarun commented Oct 17, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 17, 2019
@apelisse
Copy link
Member Author

apelisse commented Apr 29, 2020

Hi there, we're not planning on promoting this feature this cycle, thank you!

@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

Thank you @apelisse for the update. I will update the tracking sheet accordingly. 👍

@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/milestone clear

@fejta-bot
Copy link

fejta-bot commented Jul 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2020
@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @apelisse

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@apelisse
Copy link
Member Author

apelisse commented Sep 14, 2020

Hopefully next release

@fejta-bot
Copy link

fejta-bot commented Dec 13, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2020
@apelisse
Copy link
Member Author

apelisse commented Dec 14, 2020

This is on my backlog, and I believe we can have a new discussion around this since we changed the null semantics.
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2020
@fejta-bot
Copy link

fejta-bot commented Mar 14, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2021
@apelisse
Copy link
Member Author

apelisse commented Mar 16, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 16, 2021
@fejta-bot
Copy link

fejta-bot commented Mar 16, 2021

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Mar 16, 2021
@fejta-bot
Copy link

fejta-bot commented Jun 14, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2021
@fejta-bot
Copy link

fejta-bot commented Jul 14, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 14, 2021
@apelisse
Copy link
Member Author

apelisse commented Jul 14, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

9 participants