Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSI plugins in Windows #1122

Closed
ddebroy opened this issue Jun 28, 2019 · 81 comments
Closed

Support CSI plugins in Windows #1122

ddebroy opened this issue Jun 28, 2019 · 81 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
Milestone

Comments

@ddebroy
Copy link
Member

ddebroy commented Jun 28, 2019

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 28, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Jun 28, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 28, 2019
@ddebroy ddebroy added this to Backlog (v1.16) in SIG-Windows Jul 2, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Jul 2, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 2, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Jul 2, 2019

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jul 2, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 8, 2019

/stage alpha
/milestone v1.16

@ddebroy As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. Please link to the KEP when it's created. Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Thanks

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jul 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 8, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 8, 2019
@PatrickLang
Copy link
Contributor

PatrickLang commented Jul 16, 2019

KEP #1141

@mrbobbytables
Copy link
Member

mrbobbytables commented Jul 29, 2019

@ddebroy @PatrickLang one of the 1.16 Enhancement shadows here -- Just as a general reminder -- the Enhancement freeze is End-of-Day tomorrow (7/30).

The KEP must be merged and in an implementable state with graduation criteria to be considered a part of the release. For now it is being labeled as At Risk and will be dropped from the milestone if it's not merged tomorrow.

Thanks!

@ddebroy
Copy link
Member Author

ddebroy commented Jul 29, 2019

A provisional version of the KEP has been merged: #1141 and description updated with a link to it.

I will have the PR to move to implementable by EOD and seek approval from approvers.

@ddebroy
Copy link
Member Author

ddebroy commented Jul 30, 2019

PR to move KEP to implementable: #1184

@sethmccombs
Copy link

sethmccombs commented Aug 4, 2019

Hey @ddebroy

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@ddebroy
Copy link
Member Author

ddebroy commented Aug 12, 2019

@sethmccombs, yes there will be docs changes for this feature. I will open a place holder PR to track the docs work against this.

@PatrickLang PatrickLang moved this from Backlog (v1.16) to In Progress (v1.16) in SIG-Windows Aug 13, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Aug 20, 2019

1.16 PRs for this in-tree:
kubernetes/kubernetes#81397
out-of-tree:
kubernetes-csi/node-driver-registrar#47
everything under: https://github.com/kubernetes-csi/csi-proxy

@ddebroy
Copy link
Member Author

ddebroy commented Aug 22, 2019

Placeholder docs PR: kubernetes/website#16017
cc @sethmccombs

@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

@ddebroy friendly reminder that code freeze for 1.16 is on Thursday 8/29. We will be watching kubernetes/kubernetes#81397 to be merged by then.

@ddebroy
Copy link
Member Author

ddebroy commented Aug 28, 2019

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 22, 2019

Hey there @ddebroy -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Sep 22, 2019
@mrbobbytables mrbobbytables removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 22, 2019
@palnabarun
Copy link
Member

palnabarun commented May 14, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2021
@JamesLaverack JamesLaverack removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 14, 2021
@xing-yang
Copy link
Contributor

xing-yang commented May 14, 2021

@JamesLaverack We are fine from SIG-Storage side. Thanks for the reminder!

@ddebroy
Copy link
Member Author

ddebroy commented May 14, 2021

Sorry for missing the prior three posts here @JamesLaverack . All the remaining changes to reach GA/stable will be out of tree in https://github.com/kubernetes-csi/csi-proxy . Michelle Au from sig-storage did review the APIs for csi-proxy and we will be addressing that feedback (already reflected in the KEP) before GA.

@PI-Victor
Copy link
Member

PI-Victor commented May 18, 2021

Hello @ddebroy 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@JamesLaverack
Copy link
Member

JamesLaverack commented Jun 23, 2021

Hey @ddebroy. I'm aware that you're out of tree so you don't have any k/k PRs, but your PRs against https://github.com/kubernetes-csi/csi-proxy (or any other repositories) still need to be merged by code freeze for your enhancement to remain in the release. Can you confirm what PRs are included in this enhancement?

@JamesLaverack
Copy link
Member

JamesLaverack commented Jul 3, 2021

Hey @ddebroy, with enhancements freeze coming up in five days on Thursday 8th July at 18:00 PDT, how are your PRs looking for this enhancement? I'm aware you don't have any k/k PRs, but I haven't been able to find any PRs against k-csi/csi-proxy. Can you point me towards your implementation PRs for v1.22?

As an additional reminder, the docs placeholder PR deadline is a day after code freeze on Friday 9th July.

@JamesLaverack
Copy link
Member

JamesLaverack commented Jul 7, 2021

Hey all, friendly reminder that code freeze is tomorrow at 18:00 PDT on the 8th of July. At the moment this enhancement is at risk because we've not gotten confirmation about which k/k PRs are related to this enhancement in v1.22.

Additionally, please remember that the docs placeholder PR is the day after code freeze.

@ddebroy
Copy link
Member Author

ddebroy commented Jul 7, 2021

hey @JamesLaverack sorry for the late reply. As you noted, we do not have any k/k PRs at this point and all changes target https://github.com/kubernetes-csi/csi-proxy.

The major PRs for v1.22 targeting csi-proxy are the following:
kubernetes-csi/csi-proxy#155
kubernetes-csi/csi-proxy#146
kubernetes-csi/csi-proxy#143
kubernetes-csi/csi-proxy#140
kubernetes-csi/csi-proxy#138
All of the above are merged.

The final step remaining is creating the csi-proxy v1.0 release branch and tag in the k-csi/csi-proxy repository this week.

@JamesLaverack
Copy link
Member

JamesLaverack commented Jul 7, 2021

Thank you for the update @ddebroy. With all of those merged this enhancement is ready for code-freeze. Please do remember the docs placeholder deadline on Friday though.

@PI-Victor
Copy link
Member

PI-Victor commented Jul 9, 2021

@ddebroy

Hello @ddebroy 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@ddebroy Today is the docs placeholder PR deadline, please submit a docs placeholder PR by EOD today!

@ddebroy
Copy link
Member Author

ddebroy commented Jul 9, 2021

docs placeholder PR: kubernetes-csi/csi-proxy#163

@PI-Victor
Copy link
Member

PI-Victor commented Jul 12, 2021

@ddebroy Ah, let me ask you something, is this feature in any way documented on https://docs.kubernetes.io?
If it's not, then we don't track it, we only track documentation that goes in the official website.

@sftim
Copy link
Contributor

sftim commented Jul 12, 2021

@sftim
Copy link
Contributor

sftim commented Jul 12, 2021

If this support is going to graduate to stable for v1.22 I'd expect to see a Task page that explains how to deploy csi-proxy on each relevant Node - for example, as a DaemonSet.

We should also [plan to] update https://github.com/kubernetes-csi/csi-proxy if any of that README's contents are out of date or will be on graduation.

@PI-Victor
Copy link
Member

PI-Victor commented Jul 12, 2021

@ddebroy Please address @sftim concern by opening a docs placeholder PR in k/website by EOD today, this enhancement is late for docs and the deadline was 9th of July. As said above, this PR can be only a draft for now.
thanks!

@marosset
Copy link
Contributor

marosset commented Jul 12, 2021

Hi @PI-Victor and @sftim
Sorry for the delays here (I'm just ramping back up after 2 months of PTO).
I can own updating the docs on k/website for this and will open up a draft PR in a few minutes.

@marosset
Copy link
Contributor

marosset commented Jul 12, 2021

I opened up the draft PR in k/website and will address @sftim 's comments early this week.

@ddebroy
Copy link
Member Author

ddebroy commented Jul 19, 2021

If this support is going to graduate to stable for v1.22 I'd expect to see a Task page that explains how to deploy csi-proxy on each relevant Node - for example, as a DaemonSet.

Aside from https://github.com/kubernetes-csi/csi-proxy#installation and https://github.com/kubernetes-csi/csi-proxy#setup-for-csi-driver-deployment covering how to install csi-proxy and configure a deamonset to invoke it, kubernetes-csi/docs#362 for doc updates around csi-proxy in k-csi docs will also cover this aspect.

@ddebroy
Copy link
Member Author

ddebroy commented Jul 19, 2021

There already are docs: https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/#csi-plugins
Are these still correct?

Updates for that section in kubernetes/website#28914

@ddebroy
Copy link
Member Author

ddebroy commented Jul 20, 2021

Main csi-proxy API docs PR: kubernetes-csi/csi-proxy#165 (supersedes kubernetes-csi/csi-proxy#163)

@ddebroy
Copy link
Member Author

ddebroy commented Jul 20, 2021

To summarize, here are the doc PRs:

  1. k/website: Doc updates for promoting csi plugins on windows to stable website#28914 [minor updates + mark feature is stable]
  2. k-csi/docs: Add csi-proxy project kubernetes-csi/docs#362 [how to use and deploy csi-proxy as a plugin developer]
  3. k-csi/csi-proxy: Add Docs for v1 APIs kubernetes-csi/csi-proxy#165 [specifics of each API group in v1]

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Jul 24, 2021

k/website feature blogpost: kubernetes/website#29105

@marosset marosset moved this from Backlog (v1.22) to Done (v1.22) in SIG-Windows Jul 29, 2021
@ddebroy
Copy link
Member Author

ddebroy commented Aug 9, 2021

This issue is now complete! https://kubernetes.io/blog/2021/08/09/csi-windows-support-with-csi-proxy-reaches-ga/
Many thanks to all those who contributed!!

@ddebroy ddebroy closed this as completed Aug 9, 2021
@msau42
Copy link
Member

msau42 commented Aug 9, 2021

@ddebroy can you also update the KEP status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
SIG-Windows
  
Done (v1.22)
Development

No branches or pull requests