Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of node-role labels within Kubernetes and migrate old components #1143

Closed
smarterclayton opened this issue Jul 17, 2019 · 62 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 17, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Clarify that the node-role.kubernetes.io/* label is for use only by users and external projects and may not be used to vary Kubernetes behavior. Define migration process for all internal consumers of these labels.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 17, 2019
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Jul 17, 2019

/sig architecture
/sig testing
/sig network
/sig node

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 17, 2019
@timothysc
Copy link
Member

timothysc commented Jul 17, 2019

@kubernetes/sig-cluster-lifecycle
cc @luxas @justinsb @neolit123 @fabriziopandini

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Aug 2, 2019

Would like to get an exception for 1.16, trying to get approval on the KEP (Jordan and Justin were primary reviewers, Derek helped take a look from sig-node). Will follow up early next week.

smarterclayton added a commit to smarterclayton/kubernetes.github.io that referenced this issue Aug 30, 2019
Provide documentation for the new alpha labels.

kubernetes/enhancements#1143
k8s-ci-robot pushed a commit to kubernetes/website that referenced this issue Sep 5, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this issue Sep 9, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Hey there @smarterclayton , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Oct 1, 2019

Yes, this will be alpha in 1.17.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Oct 1, 2019

KEP is updated with plan starting as alpha in 1.17

@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Thank you for the swift response. :)

Added this to 1.17 release.

/stage alpha
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 1, 2019
@palnabarun palnabarun added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 1, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Just FYI, all enhancements should have a KEP, the KEP PR should be merged, the KEP should be in an implementable state, have a testing plan and graduation criteria.

I see that you have updated your KEP with #1268. Please make sure that it is merged before the Enhancements Freeze.

@daminisatya
Copy link
Member

daminisatya commented Oct 30, 2019

Hello, @smarterclayton I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@daminisatya
Copy link
Member

daminisatya commented Nov 4, 2019

Hello @smarterclayton,

Please let us know if this enhancement requires docs. If so, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 5, 2019

@palnabarun
Copy link
Member

palnabarun commented Nov 5, 2019

Hi @smarterclayton

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#80238 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 7, 2019

@palnabarun
Copy link
Member

palnabarun commented Nov 8, 2019

@smarterclayton Thank you for the updates. :)

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 7, 2020

Hey there @smarterclayton , 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18?

The current release schedule is:

Monday, January 6 - Release Cycle Began
Tuesday, January 28, EOD PST - Enhancements Freeze
Thursday, March 5, EOD PST - Code Freeze
Monday, March 16- Docs must be completed and reviewed
Tuesday, March 24 - Kubernetes 1.18.0 Released

If you do, I'll add it to the 1.17 tracking sheet (http://bit.ly/k8s-1-18-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@fejta-bot
Copy link

fejta-bot commented Feb 4, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 4, 2021
@fejta-bot
Copy link

fejta-bot commented Mar 7, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Member

pacoxu commented Apr 2, 2021

/remove-lifecycle rotten
/reopen
kubernetes/kubernetes#100776 will fix it in 1.22

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 2, 2021

@pacoxu: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen
kubernetes/kubernetes#100776 will fix it in 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Apr 2, 2021
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 2, 2021
@spiffxp
Copy link
Member

spiffxp commented May 12, 2021

/assign @ehashman @dims @neolit123 @spiffxp
assigning to arbitrary chairs from each of the labeled SIGs... is this something that we are actively planning to tackle for v1.22?

@spiffxp
Copy link
Member

spiffxp commented May 12, 2021

Like, I don't know enough about this to know what needs to happen beyond "land kubernetes/kubernetes#100776".

I also don't know if this is at a state where it's already been announced in a changelog, GA'ed, and we just forgot to clean stuff up?

@neolit123
Copy link
Member

neolit123 commented May 12, 2021

kubernetes/kubernetes#100776 is the only remaining action, according to the KEP.

Release 5 (1.22):
The LegacyNodeRoleBehavior gate and all feature-level gates are removed, components that attempt to set these gates will fail to start.
Code that references node-roles within Kubernetes will be removed.

In Release 5 (which could be as early as 1.21) this KEP will be considered complete.

https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/1143-node-role-labels#migrating-existing-deployments

@ehashman
Copy link
Member

ehashman commented May 12, 2021

/assign @ehashman @dims @neolit123 @spiffxp
assigning to arbitrary chairs from each of the labeled SIGs... is this something that we are actively planning to tackle for v1.22?

I am not a chair of one of the labelled SIGs.

/cc @liggitt
who I think know more about where this is at

@dims
Copy link
Member

dims commented May 12, 2021

+1 to land kubernetes/kubernetes#100776 and close this up in 1.22.

@thockin thockin added this to New (not evaluated) in SIG-Network KEPs via automation May 22, 2021
@thockin thockin moved this from New (not evaluated) to GA (merged, gate not removed) in SIG-Network KEPs Jun 1, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 10, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2021
@BenTheElder
Copy link
Member

BenTheElder commented Aug 11, 2021

+1 to land kubernetes/kubernetes#100776 and close this up in 1.22.

kubernetes/kubernetes#100776 landed, shall we close then?

@neolit123
Copy link
Member

neolit123 commented Aug 11, 2021

I think we can close this now.
Please reopen if needed.

@thockin thockin removed this from GA (merged, gate not removed) in SIG-Network KEPs Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests