-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify use of node-role labels within Kubernetes and migrate old components #1143
Comments
/sig architecture |
@kubernetes/sig-cluster-lifecycle |
Would like to get an exception for 1.16, trying to get approval on the KEP (Jordan and Justin were primary reviewers, Derek helped take a look from sig-node). Will follow up early next week. |
Provide documentation for the new alpha labels. kubernetes/enhancements#1143
Provide documentation for the new alpha labels. kubernetes/enhancements#1143
Provide documentation for the new alpha labels. kubernetes/enhancements#1143
Hey there @smarterclayton , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17? The current release schedule is:
If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍 Thanks! |
Yes, this will be alpha in 1.17. |
KEP is updated with plan starting as alpha in 1.17 |
Thank you for the swift response. :) Added this to 1.17 release. /stage alpha |
Just FYI, all enhancements should have a KEP, the KEP PR should be merged, the KEP should be in an implementable state, have a testing plan and graduation criteria. I see that you have updated your KEP with #1268. Please make sure that it is merged before the Enhancements Freeze. |
Hello, @smarterclayton I'm 1.17 docs lead. Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so) If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions! |
Hello @smarterclayton, Please let us know if this enhancement requires docs. If so, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left) |
The docs have already been merged in 1.16.
…On Mon, Nov 4, 2019 at 12:46 PM Damini Satya ***@***.***> wrote:
Hello @smarterclayton <https://github.com/smarterclayton>,
Please let us know if this enhancement requires docs. If so, We're hoping
to have a placeholder Docs PR against k/website (branch dev-1.17) by
Friday, Nov 8th. (4 more days left)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1143?email_source=notifications&email_token=AAI37J4QNP24WNQZ7KZC2NTQSBNWZA5CNFSM4IEJLH5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDADQWA#issuecomment-549468248>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI37J5NXIXIMWNDA5JCCMTQSBNWZANCNFSM4IEJLH5A>
.
|
I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#80238 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here? Thank you in advance 😄 |
This required no changes in 1.17 to go to alpha. It is ready.
…On Tue, Nov 5, 2019 at 2:13 PM Nabarun Pal ***@***.***> wrote:
Hi @smarterclayton <https://github.com/smarterclayton>
I am one of the Enhancements Shadow for the 1.17 Release Team. We are very
near to the Code Freeze (Nov 14th) for this release cycle. Just checking in
about the progress of this enhancement. I see that
kubernetes/kubernetes#80238
<kubernetes/kubernetes#80238> was filed in
relation to this. Is there any other PR related to this enhancement? If
yes, can you please link them here?
Thank you in advance 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1143?email_source=notifications&email_token=AAI37JYD7C73UIWMWSTJNVLQSHAT5A5CNFSM4IEJLH5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDD7EKY#issuecomment-549974571>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI37J5DNQNVUZFJCB2SNZLQSHAT5ANCNFSM4IEJLH5A>
.
|
@smarterclayton Thank you for the updates. :) |
Hey there @smarterclayton , 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18? The current release schedule is: Monday, January 6 - Release Cycle Began If you do, I'll add it to the 1.17 tracking sheet (http://bit.ly/k8s-1-18-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍 Thanks! |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@pacoxu: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ehashman @dims @neolit123 @spiffxp |
Like, I don't know enough about this to know what needs to happen beyond "land kubernetes/kubernetes#100776". I also don't know if this is at a state where it's already been announced in a changelog, GA'ed, and we just forgot to clean stuff up? |
kubernetes/kubernetes#100776 is the only remaining action, according to the KEP.
|
I am not a chair of one of the labelled SIGs. /cc @liggitt |
+1 to land kubernetes/kubernetes#100776 and close this up in 1.22. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
kubernetes/kubernetes#100776 landed, shall we close then? |
I think we can close this now. |
Enhancement Description
Clarify that the
node-role.kubernetes.io/*
label is for use only by users and external projects and may not be used to vary Kubernetes behavior. Define migration process for all internal consumers of these labels.The text was updated successfully, but these errors were encountered: