Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove SelfLink #1164

Closed
wojtek-t opened this issue Jul 23, 2019 · 47 comments · Fixed by #3301
Closed

Deprecate and remove SelfLink #1164

wojtek-t opened this issue Jul 23, 2019 · 47 comments · Fixed by #3301
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Jul 23, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Deprecate and remove SelfLink fields
  • Kubernetes Enhancement Proposal: KEP
  • Primary contact (assignee): wojtek-t
  • Responsible SIGs: sig-apimachinery, sig-scalability
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.16)
    • Beta release target (1.20)
    • Stable release target (1.24)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@wojtek-t wojtek-t added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 23, 2019
@wojtek-t wojtek-t self-assigned this Jul 23, 2019
@wojtek-t wojtek-t added this to the v1.16 milestone Jul 23, 2019
@sethmccombs
Copy link

sethmccombs commented Aug 4, 2019

Hey @wojtek-t

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@wojtek-t
Copy link
Member Author

wojtek-t commented Aug 5, 2019

It will require some updates in the existing doc - I will open a PR closer to the time.

@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

@wojtek-t code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha? Looks like kubernetes/kubernetes#80978 is merged. Thanks for tagging that.

@wojtek-t
Copy link
Member Author

wojtek-t commented Aug 26, 2019

Yes - everything required is merged.

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 22, 2019

Hey there @wojtek-t -- 1.17 Enhancements lead here. I know the plan is to follow the deprecation policy and target the 1.20/1.21 release for future work, but I just wanted to confirm it for tracking purposes 👍

Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Sep 22, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 22, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 23, 2019

Yes - next steps are planned for 1.20.

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 23, 2019
@fejta-bot
Copy link

fejta-bot commented Dec 22, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Dec 30, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2019
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jan 14, 2020

Hey there @wojtek-t -- 1.18 Enhancements shadow here. Just wanted to double check that this is not slated for 1.18? The 1.20 milestone is still correct?

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 14, 2020

Yes - 1.20 is correct.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jan 14, 2020

thanks @wojtek-t !

@fejta-bot
Copy link

fejta-bot commented Apr 13, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2020
@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 11, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 11, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 17, 2022

Hello @wojtek-t 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting stable for 1.24 and it's a deprecation enhancement, are these correct?

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
    • Looks like the kep.yaml need updating to reflect current stage.
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.
    • Could you please confirm if this enhancement require a PRR approval?

The status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 17, 2022

@Priyankasaggu11929 - the PR to update the KEP is already out-for-review: #3118 (this should address the remaining bits from your above list).

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 18, 2022

Thanks @wojtek-t for the update! 🙂

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 19, 2022

@Priyankasaggu11929 - that PR was just approved. Let me know if there is anything else missing for the feature freeze here.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 19, 2022

@wojtek-t, thanks for the update. With the KEP PR merged, this enhancement is ready to go for the enhancements freeze. 🙂

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @wojtek-t 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@wojtek-t
Copy link
Member Author

wojtek-t commented Feb 15, 2022

@mehabhalodiya - kubernetes/website#31756 is already opened for review

@wojtek-t wojtek-t added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Feb 15, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 15, 2022

Hello @wojtek-t 👋

With 1.24 Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, I'm just checking in once more.

With all the above check-boxes completed, this enhancement is all good for the upcoming 1.24 code freeze. 🚀 For note, the status of this enhancement is marked as tracked.

Kindly Please let me know if I'm missing any PRs other than the ones I linked above.

Also please link all the milestone PRs in the above issue description (for tracking purposes). Thank you so much!

@wojtek-t
Copy link
Member Author

wojtek-t commented Mar 21, 2022

@Priyankasaggu11929 - the above is correct - everything we need merged is merged

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @wojtek-t 👋, 1.25 Enhancements team here.

Since this feature has been fully deprecated now in K8s version 1.24.

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.