Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced configurations with kubeadm (using Kustomize). #1177

Closed
neolit123 opened this issue Jul 29, 2019 · 33 comments
Closed

Advanced configurations with kubeadm (using Kustomize). #1177

neolit123 opened this issue Jul 29, 2019 · 33 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@neolit123
Copy link
Member

neolit123 commented Jul 29, 2019

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

k/kubeadm tracking issue:
kubernetes/kubeadm#1379

2019-07-29:

2019-08-22:

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 29, 2019
@neolit123 neolit123 added this to the v1.16 milestone Jul 29, 2019
@neolit123 neolit123 added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 29, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 29, 2019
@neolit123 neolit123 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 29, 2019
@neolit123 neolit123 added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 29, 2019
@neolit123
Copy link
Member Author

neolit123 commented Jul 29, 2019

@kacole2 hi, i've just added this issue / feature to tracked/yes. please update if needed.
the KEP just merged #1159

@kacole2
Copy link
Member

kacole2 commented Jul 29, 2019

@neolit123 I got you. thanks!

@fabriziopandini
Copy link
Member

fabriziopandini commented Jul 30, 2019

@neolit123 thanks for taking care of creating this issue!

@sethmccombs
Copy link

sethmccombs commented Aug 4, 2019

Hey @neolit123 @fabriziopandini

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@neolit123
Copy link
Member Author

neolit123 commented Aug 4, 2019

hi @sethmccombs

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

yes, it does require docs.

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

i've added a placeholder docs PRs: TODO note in the OP.
we will definitely create place holder PRs before the 23rd.

thanks for the heads up!

@neolit123
Copy link
Member Author

neolit123 commented Aug 22, 2019

@sethmccombs

hi, we spoke about whether this requires docs again during the office hours of kubeadm (Wed 21Aug) and decided to not add any documentation for this feature's Alpha stage.

i will defer to @fabriziopandini if we decide to change our mind later down the line.

i've also updated the OP with some WIP/merged PRs.
thanks

@simplytunde
Copy link
Member

simplytunde commented Aug 22, 2019

@neolit123 I am the 1.16 Docs Lead. I will go ahead and put this down as docs-not-required. @fabriziopandini Please let me change of this changes before the end of Aug 23.

@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

@neolit123 code freeze for 1.16 is on Thursday 8/29. Looks like all PRs here have been merged. If that's the case, congrats on getting this in for Alpha!

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 22, 2019

Hey there @neolit @fabianofranz -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Sep 22, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 22, 2019
@fejta-bot
Copy link

fejta-bot commented Dec 21, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2019
@neolit123
Copy link
Member Author

neolit123 commented Dec 21, 2019

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 21, 2019
@fejta-bot
Copy link

fejta-bot commented Dec 21, 2019

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 21, 2019
@fabriziopandini
Copy link
Member

fabriziopandini commented Jan 9, 2020

@neolit123 what about moving to beta in 1.18?

@neolit123
Copy link
Member Author

neolit123 commented Jan 9, 2020

@fabriziopandini from the KEP:

This proposal in its initial version covers only the creation of a new alpha feature. Graduation criteria will be defined in the following iterations on this proposal and consider user feedback as well.

do you think it would be best to present the changes you wish to make in the kubeadm office hours and update the KEP if people agree?

@palnabarun
Copy link
Member

palnabarun commented Jan 13, 2020

Hey there @neolit123 @fabriziopandini -- 1.18 Enhancements shadow here. I see that there has been traction on this enhancement. Let us know about the consensus from the kubeadm office hours whether this will go to beta.

The current release schedule is:

  • Monday, January 6th - Release Cycle Begins
  • Tuesday, January 28th EOD PST - Enhancements Freeze
  • Thursday, March 5th, EOD PST - Code Freeze
  • Monday, March 16th - Docs must be completed and reviewed
  • Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

@fabriziopandini
Copy link
Member

fabriziopandini commented Jan 13, 2020

@neolit123 I'm +1 for moving to beta in 1.18. Opinions?

@neolit123
Copy link
Member Author

neolit123 commented Jan 13, 2020

@fabriziopandini
as commented here:
#1177 (comment)

i think, it would be best to talk about this in the office hours this week and decide if we want to target the enhancement freeze of 28th.

@fabriziopandini
Copy link
Member

fabriziopandini commented Jan 15, 2020

@palnabarun
As discussed in the kubeadm office hours today, we decided to keep this feature in alpha for some more time. no changes planned for the v1.18 cycle

@palnabarun
Copy link
Member

palnabarun commented Jan 15, 2020

Thank you @fabriziopandini for the updates. I will remove this enhancement from the tracking sheet,

@fejta-bot
Copy link

fejta-bot commented Apr 14, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2020
@neolit123
Copy link
Member Author

neolit123 commented Apr 14, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2020
@msedzins
Copy link

msedzins commented Apr 29, 2020

Hey there @fabriziopandini -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@neolit123
Copy link
Member Author

neolit123 commented Apr 29, 2020

@msedzins hi, we are not going to make changes related to this in 1.19.

@msedzins
Copy link

msedzins commented May 1, 2020

Thank you @neolit123 for letting me know.

@fejta-bot
Copy link

fejta-bot commented Jul 30, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2020
@neolit123
Copy link
Member Author

neolit123 commented Jul 30, 2020

/remove-lifecycle stale

@palnabarun
Copy link
Member

palnabarun commented Jul 30, 2020

/remove-lifecycle stale

(trying again)

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @neolit123

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@neolit123
Copy link
Member Author

neolit123 commented Sep 14, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 7, 2020

Hi @neolit123

Any update on closing this issue?

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 7, 2020

+1 to close this, the code was removed by kubernetes/kubernetes#94871

@neolit123
Copy link
Member Author

neolit123 commented Oct 7, 2020

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2020

@neolit123: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests