Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production readiness review process #1194

Closed
johnbelamaric opened this issue Jul 31, 2019 · 14 comments
Closed

Production readiness review process #1194

johnbelamaric opened this issue Jul 31, 2019 · 14 comments
Assignees
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team

Comments

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jul 31, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Introduces a production readiness review process for Kubernetes features
  • Kubernetes Enhancement Proposal: Introduce KEP for production readiness review #1193
  • Primary contact (assignee): @johnbelamaric
  • Responsible SIGs: sig-architecture, sig-release
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 31, 2019
@fejta-bot
Copy link

fejta-bot commented Oct 29, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2019
@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Oct 29, 2019

/remove-lifecycle stale
/sig architecture

does this really need an issue in addition to the KEP? It's a process / tooling change not a user-facing change...does that matter?

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 29, 2019
@fejta-bot
Copy link

fejta-bot commented Jan 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2020
@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Jan 28, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2020
@johnbelamaric johnbelamaric self-assigned this Jan 28, 2020
@fejta-bot
Copy link

fejta-bot commented Apr 27, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2020
@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Apr 27, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2020
@palnabarun palnabarun added the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label May 12, 2020
@LappleApple
Copy link
Contributor

LappleApple commented Jun 20, 2020

Hiya, is this still needed, especially given #1707?

@wojtek-t
Copy link
Member

wojtek-t commented Jun 22, 2020

We're not closing enhancement issues until they are completed. This one isn't e.g. because PRR is not enforced on each KEP. So it is needed.

@fejta-bot
Copy link

fejta-bot commented Sep 20, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Sep 21, 2020

/remove-lifecycle stale

@johnbelamaric - given we're going to enforce PRR for 1.20, I think we need to update some doc maybe? and close this one?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2020
@fejta-bot
Copy link

fejta-bot commented Dec 20, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Jan 7, 2021

/remove-lifecycle stale

Some more discussion was requested here - will happen next week. @johnbelamaric

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2021
@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Feb 16, 2021

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 16, 2021

@johnbelamaric: Closing this issue.

In response to this:

This has been implemented: https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/1194-prod-readiness

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

6 participants