Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configurable default constraint to PodTopologySpread #1258

Closed
alculquicondor opened this issue Sep 25, 2019 · 82 comments
Closed

Add a configurable default constraint to PodTopologySpread #1258

alculquicondor opened this issue Sep 25, 2019 · 82 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Sep 25, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 25, 2019
@alculquicondor
Copy link
Member Author

alculquicondor commented Sep 25, 2019

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 25, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 25, 2019

Hey there @alculquicondor -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

Just a reminder that for it to be accepted -- the KEP must be merged, in an implementable state and have both a test plan and graduation criteria defined before the Enhancement Freeze.

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do think it'll make it, please let me know.

Thanks!

@mrbobbytables mrbobbytables added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 25, 2019
@alculquicondor
Copy link
Member Author

alculquicondor commented Sep 26, 2019

Hi Bob. I believe I'll have it ready before the Enhancements Freeze.

/assign

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 26, 2019

great, thanks @alculquicondor I'll add it to the tracking sheet :)
/stage alpha
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 26, 2019
@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 26, 2019
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 9, 2019

Hey @alculquicondor, friendly reminder that enhancement freeze is quickly approaching (EOD PT, October 15th). Your KEP will need to be updated to the implementable state in order for us to include it in the release. It looks like it was merged, but is still listed as provisional.

@alculquicondor
Copy link
Member Author

alculquicondor commented Oct 9, 2019

Thanks @jeremyrickard. We already have a PR to set that flag.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 9, 2019

👍 great @alculquicondor.

@alculquicondor
Copy link
Member Author

alculquicondor commented Oct 11, 2019

It's now marked as implementable.

@daminisatya
Copy link
Member

daminisatya commented Oct 30, 2019

Hello, @alculquicondor I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@alculquicondor
Copy link
Member Author

alculquicondor commented Oct 31, 2019

@daminisatya
Copy link
Member

daminisatya commented Nov 1, 2019

Thank you @alculquicondor Make sure you open a Docs PR against k/website (branch dev-1.17) due by Friday, November 8th.

@daminisatya
Copy link
Member

daminisatya commented Nov 4, 2019

Hello @alculquicondor

Just a friendly reminder, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

@alculquicondor
Copy link
Member Author

alculquicondor commented Nov 4, 2019

Done kubernetes/website#17409

@palnabarun
Copy link
Member

palnabarun commented Nov 5, 2019

Hi @alculquicondor

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#84606 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

@alculquicondor
Copy link
Member Author

alculquicondor commented Nov 6, 2019

1/2: kubernetes/kubernetes#84874

@palnabarun
Copy link
Member

palnabarun commented Nov 8, 2019

@alculquicondor Awesome! Thank you for the updates. :) Please let us know if and when 2/2 is filed.

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

Hi @alculquicondor , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PR has not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@alculquicondor
Copy link
Member Author

alculquicondor commented Nov 13, 2019

Hello @palnabarun even though the API changes got approved, we hit several blockers in the implementation. I don't think we can make it before the freeze. Could you please take it out of the release?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 30, 2021

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member Author

alculquicondor commented Sep 30, 2021

/reopen

I'm gonna graduate this feature to GA in 1.24

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 30, 2021

@alculquicondor: Reopened this issue.

In response to this:

/reopen

I'm gonna graduate this feature to GA in 1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Sep 30, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 30, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 30, 2021

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member Author

alculquicondor commented Jan 5, 2022

/reopen

/help

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 5, 2022

@alculquicondor: Reopened this issue.

In response to this:

/reopen

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jan 5, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Jan 5, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 5, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Jan 6, 2022

/assign @gavinfish

/remove help

@alculquicondor
Copy link
Member Author

alculquicondor commented Jan 6, 2022

/remove-help

@kerthcet
Copy link
Member

kerthcet commented Mar 1, 2022

DefaultPodTopologySpread is GA in kubernetes/kubernetes#108278 already. Should we updated the description and whether any works remaining? @alculquicondor

@alculquicondor
Copy link
Member Author

alculquicondor commented Mar 1, 2022

You need to update the state of the feature in the website https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/#internal-default-constraints

@k8s-triage-robot
Copy link

k8s-triage-robot commented May 30, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented May 30, 2022

Thanks @kerthcet for graduating this feature!

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 30, 2022

@alculquicondor: Closing this issue.

In response to this:

Thanks @kerthcet for graduating this feature!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests