Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RuntimeClass on Windows #1301

Closed
3 of 4 tasks
PatrickLang opened this issue Oct 11, 2019 · 43 comments
Closed
3 of 4 tasks

Implement RuntimeClass on Windows #1301

PatrickLang opened this issue Oct 11, 2019 · 43 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team

Comments

@PatrickLang
Copy link
Contributor

PatrickLang commented Oct 11, 2019

Enhancement Description

This is closely related to #1001 but covers some much more specific use cases.

PRs

/sig windows
/sig node

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2019
@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 14, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 14, 2019

Thanks @PatrickLang I'll add it to the Enhancement tracking sheet. Just a reminder, the KEP must be merged, in an implementable state with a test plan and graduation criteria defined by EoD tomorrow at 5pm PT.

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Oct 15, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 15, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 16, 2019

@PatrickLang Thanks for going ahead and filing an exception request, we'll follow up there for review 👍

For now it's being removed from the milestone and flagged as tracked/no. If approved it'll be added back in.

@mrbobbytables mrbobbytables removed this from the v1.17 milestone Oct 16, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 16, 2019
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 17, 2019

@guineveresaenger approved the exception, so I am adding this back to the 1.17 milestone.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Oct 17, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 17, 2019
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 17, 2019
@daminisatya
Copy link
Member

daminisatya commented Oct 30, 2019

Hello, @PatrickLang I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@daminisatya
Copy link
Member

daminisatya commented Nov 4, 2019

Hello, @PatrickLang

Please let us know if this enhancement requires docs. If so, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

@palnabarun
Copy link
Member

palnabarun commented Nov 5, 2019

Hi @PatrickLang

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. Can you please link the PR's related to this enhancement here?

Thank you in advance 😄

@daminisatya
Copy link
Member

daminisatya commented Nov 6, 2019

Hello @PatrickLang

Just a friendly reminder, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (2 more days left)

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Nov 6, 2019

@palnabarun @daminisatya @jeremyrickard - PRs attached. There may be additional code PRs as the current one is a WIP and under active discussion and review with SIG-Node before proceeding with the next steps.

@PatrickLang PatrickLang added this to In Progress (v1.17) in SIG-Windows Nov 6, 2019
@palnabarun
Copy link
Member

palnabarun commented Nov 6, 2019

@PatrickLang Thank you for the updates 😀

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

Hi @PatrickLang , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

/assign @PatrickLang

@PatrickLang
Copy link
Contributor Author

PatrickLang commented Nov 15, 2019

This has one of the use cases complete and merged. I will update the doc bug tomorrow for that. The other use case related to multiple OS versions on the same node will be moved out.

How do you want to track this? Keep this open and move to 1.18?

@palnabarun palnabarun added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 20, 2020
@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 20, 2020
@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 20, 2020
@mikejoh
Copy link

mikejoh commented May 26, 2020

Hello, @PatrickLang ! 👋 I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

I saw that this docs PR was merged kubernetes/website#16697 a couple of months ago.

Regards,
Mikael.

@marosset marosset assigned marosset and unassigned PatrickLang Jun 4, 2020
@palnabarun
Copy link
Member

palnabarun commented Jun 11, 2020

@marosset -- As per our conversation on Slack, I have updated the tracking sheet. Thanks for the pro-active ping. 👍

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone Jun 11, 2020
@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 11, 2020
@marosset
Copy link
Contributor

marosset commented Jun 11, 2020

Thanks @palnabarun!
Unfortunately I don't think we'll be finished with the work for this to go to alpha for 1.19.

@marosset marosset moved this from Backlog (v1.19) to Backlog (v1.20) in SIG-Windows Jun 26, 2020
@fejta-bot
Copy link

fejta-bot commented Sep 9, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @PatrickLang @marosset

Enhancements Lead here, do you still intend to go alpha in 1.20?

Thanks!
Kirsten

@marosset
Copy link
Contributor

marosset commented Sep 11, 2020

@kikisdeliveryservice I'm starting a discussion with SIG-Windows leads about this now.

@kikisdeliveryservice kikisdeliveryservice removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Sounds good, please keep us updated!

@marosset
Copy link
Contributor

marosset commented Sep 18, 2020

Hi @kikisdeliveryservice - I spoke with sig-windows leads and since we don't foresee needing any implementation PRs in k/k we didn't think tracking this as an enhancement makes sense.
Pretty much all of the remaining work here is making sure there is adequate test coverage in periodic jobs on testgrid as well as documentation.
Should I close this issue for now and re-open if the situation changes?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 18, 2020

@marosset that sounds good to me!

@kikisdeliveryservice kikisdeliveryservice added the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label Sep 30, 2020
@fejta-bot
Copy link

fejta-bot commented Oct 30, 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 30, 2020
@fejta-bot
Copy link

fejta-bot commented Nov 29, 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 29, 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG-Windows automation moved this from Backlog (v1.20) to Done (v1.20) Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
None yet
Development

No branches or pull requests