Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RuntimeClass on Windows #1301

Open
PatrickLang opened this issue Oct 11, 2019 · 26 comments
Open

Implement RuntimeClass on Windows #1301

PatrickLang opened this issue Oct 11, 2019 · 26 comments
Assignees
Projects
Milestone

Comments

@PatrickLang
Copy link
Contributor

@PatrickLang PatrickLang commented Oct 11, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Use RuntimeClass and labels to support multiple Windows versions in the same cluster, and same node with Hyper-V isolation
  • Kubernetes Enhancement Proposal: #1302
  • Primary contact (assignee): @PatrickLang
  • Responsible SIGs: SIG-Windows, SIG-Node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.17)
    • Beta release target (1.18)
    • Stable release target (1.19)

This is closely related to #1001 but covers some much more specific use cases.

PRs

/sig windows
/sig node
/milestone v1.17

@mrbobbytables

This comment has been minimized.

Copy link
Member

@mrbobbytables mrbobbytables commented Oct 14, 2019

Thanks @PatrickLang I'll add it to the Enhancement tracking sheet. Just a reminder, the KEP must be merged, in an implementable state with a test plan and graduation criteria defined by EoD tomorrow at 5pm PT.

@PatrickLang

This comment has been minimized.

Copy link
Contributor Author

@PatrickLang PatrickLang commented Oct 15, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 15, 2019
@mrbobbytables

This comment has been minimized.

Copy link
Member

@mrbobbytables mrbobbytables commented Oct 16, 2019

@PatrickLang Thanks for going ahead and filing an exception request, we'll follow up there for review 👍

For now it's being removed from the milestone and flagged as tracked/no. If approved it'll be added back in.

@mrbobbytables mrbobbytables removed this from the v1.17 milestone Oct 16, 2019
@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Oct 17, 2019

@guineveresaenger approved the exception, so I am adding this back to the 1.17 milestone.

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Oct 17, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 17, 2019
@daminisatya

This comment has been minimized.

Copy link
Member

@daminisatya daminisatya commented Oct 30, 2019

Hello, @PatrickLang I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@daminisatya

This comment has been minimized.

Copy link
Member

@daminisatya daminisatya commented Nov 4, 2019

Hello, @PatrickLang

Please let us know if this enhancement requires docs. If so, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Nov 5, 2019

Hi @PatrickLang

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. Can you please link the PR's related to this enhancement here?

Thank you in advance 😄

@daminisatya

This comment has been minimized.

Copy link
Member

@daminisatya daminisatya commented Nov 6, 2019

Hello @PatrickLang

Just a friendly reminder, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (2 more days left)

@PatrickLang

This comment has been minimized.

Copy link
Contributor Author

@PatrickLang PatrickLang commented Nov 6, 2019

@palnabarun @daminisatya @jeremyrickard - PRs attached. There may be additional code PRs as the current one is a WIP and under active discussion and review with SIG-Node before proceeding with the next steps.

@PatrickLang PatrickLang added this to In Progress (v1.17) in SIG-Windows Nov 6, 2019
@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Nov 6, 2019

@PatrickLang Thank you for the updates 😀

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Nov 13, 2019

Hi @PatrickLang , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Nov 13, 2019

/assign @PatrickLang

@PatrickLang

This comment has been minimized.

Copy link
Contributor Author

@PatrickLang PatrickLang commented Nov 15, 2019

This has one of the use cases complete and merged. I will update the doc bug tomorrow for that. The other use case related to multiple OS versions on the same node will be moved out.

How do you want to track this? Keep this open and move to 1.18?

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Nov 15, 2019

How do you want to track this? Keep this open and move to 1.18?

We generally keep enhancement issues open until the Stable milestone is complete. So, yes this will remain open for the time being.

Regarding the pending PR and the use case yet to be implemented, I think that you should probably push it to 1.18 and fully graduate to Alpha in 1.18, making it feature complete.

Please let us know what are your thoughts about this.

@mrbobbytables

This comment has been minimized.

Copy link
Member

@mrbobbytables mrbobbytables commented Nov 25, 2019

/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 25, 2019
@PatrickLang PatrickLang moved this from In Progress (v1.17) to Backlog (v1.18) in SIG-Windows Dec 5, 2019
@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Jan 7, 2020

Hey @PatrickLang

1.18 enhancements team reaching out 👋 How is this looking for 1.18? Do you plan on going to Alpha in the 1.18 release? Code freeze will be on March 5th

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Jan 23, 2020

Confirmed with @PatrickLang this should be tracked for 1.18

@iheanyi1

This comment has been minimized.

Copy link

@iheanyi1 iheanyi1 commented Feb 4, 2020

Hello @PatrickLang ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time.
Warm regards,

chima

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Feb 11, 2020

Hey @PatrickLang

Just a friendly reminder that code freeze for 1.18 is March 05, 2020.

As we track toward code freeze, please list out/link to any PRs you are working on toward graduating this enhancement!

@iheanyi1

This comment has been minimized.

Copy link

@iheanyi1 iheanyi1 commented Feb 17, 2020

Hello @PatrickLang ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time.

@PatrickLang

This comment has been minimized.

Copy link
Contributor Author

@PatrickLang PatrickLang commented Feb 26, 2020

The user-facing change (node labels) was completed in 1.17 - PRs above.

What we're doing for 1.18 is a change to CRI. It won't be user-visible in 1.18 immediately as we need to make some updates to ContainerD. The end goal is to have different RuntimeClasses supported so that someone can run containers for multiple versions on the same node, instead of requiring different nodes per Windows version

@VineethReddy02

This comment has been minimized.

Copy link

@VineethReddy02 VineethReddy02 commented Feb 27, 2020

@PatrickLang So can I update the docs tracking sheet that we don't need any docs under k8s/website repo for this enhancement for release 1.18?

@PatrickLang

This comment has been minimized.

Copy link
Contributor Author

@PatrickLang PatrickLang commented Feb 27, 2020

Yes, no docs needed for 1.18. thanks for checking

@marosset

This comment has been minimized.

Copy link

@marosset marosset commented Mar 17, 2020

/milestone 1.19

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 17, 2020

@marosset: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SIG-Windows
  
Backlog (v1.19)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.