Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of mixed protocols in Services with type=LoadBalancer #1435

Open
janosi opened this issue Jan 7, 2020 · 117 comments
Open

Support of mixed protocols in Services with type=LoadBalancer #1435

janosi opened this issue Jan 7, 2020 · 117 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@janosi
Copy link
Contributor

janosi commented Jan 7, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): This feature enables the creation of a LoadBalancer Service that has different port definitions with different protocols.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1435-mixed-protocol-lb
  • Primary contact (assignee): Laszlo Janosi (@janosi)
  • Responsible SIGs: Network, Cloud Provider
  • Enhancement target (which target equals to which milestone):
    • Alpha release target 1.18
    • Beta release target 1.19
    • Stable release target 1.20

KEP document: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20200103-mixed-protocol-lb.md

GA k/k PR in v1.26: kubernetes/kubernetes#112895

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 7, 2020
@janosi
Copy link
Contributor Author

janosi commented Jan 7, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 7, 2020
@janosi
Copy link
Contributor Author

janosi commented Jan 7, 2020

Original issue: kubernetes/kubernetes#23880

@helayoty
Copy link
Member

helayoty commented Jan 15, 2020

Hey there @janosi -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@janosi
Copy link
Contributor Author

janosi commented Jan 17, 2020

Hello @helayoty, thank you for your guidance! I really hope we can make it in 1.18. Let's hope we can have an agreed design plan via the KEP on time, and then the implementation can be finished.

The relevant PR in k/k: kubernetes/kubernetes#75831

@helayoty
Copy link
Member

helayoty commented Jan 17, 2020

Thanks, @janosi for the update. Would you please include the KEP PR if any?

@helayoty
Copy link
Member

helayoty commented Jan 17, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
@helayoty helayoty added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2020
@janosi
Copy link
Contributor Author

janosi commented Jan 18, 2020

Would you please include the KEP PR if any?

@helayoty Yes, of course. I added the ref to the KEP PR to the initial description of this issue.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jan 28, 2020

Hi @janosi as a reminder: today is the deadline for Enhancements Freeze for 1.18. If you need any help from the release team's side please let us know.

@janosi
Copy link
Contributor Author

janosi commented Jan 28, 2020

@kikisdeliveryservice Yeah, thank you! Actually I wait for a go/no go statement on the KEP PR from the SIG Network members @thockin @caseydavenport @andrewsykim

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

Hey @janosi, unfortunately since the KEP didn't merge before enhancement freeze, we're going to need to remove it from the milestone. If you can get the KEP merged, you can file an Exception Request and we can add it back to the milestone.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Jan 29, 2020
@jeremyrickard jeremyrickard added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 29, 2020
@fejta-bot
Copy link

fejta-bot commented Apr 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

Hi @janosi -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@janosi
Copy link
Contributor Author

janosi commented Apr 30, 2020

Hi @palnabarun , The situation is same here as with the SCTP feature. I do not know what will happen. The KEP waits for more comments as there was an alternative proposal for the control of the solution. That is the last update that happened 28 days ago.

@thockin @andrewsykim

@kenperkins
Copy link

kenperkins commented May 3, 2020

What's needed here? This appears to have stalled; I'd love to help if there's anything I can do.

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

@janosi -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@janosi
Copy link
Contributor Author

janosi commented Aug 15, 2020

PR: kubernetes/kubernetes#94028

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 29, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 29, 2022

/label tracked/yes
/remove-label tracked/no
/stage stable

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 29, 2022
@janosi
Copy link
Contributor Author

janosi commented Sep 30, 2022

@thockin @rhockenbury @bridgetkromhout I am sorry for being away from this this long. I can help in moving this forward, if you think so.

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Hello @janosi 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@janosi
Copy link
Contributor Author

janosi commented Oct 3, 2022

Hello @rhockenbury, thank you for the list of TODOs.

I wonder, when changing the feature flag, should I

  • remove the flag from k/k; or
  • change the flag to MixedProtocolLBService: {Default: true, PreRelease: featuregate.GA}; or
  • change the flag to MixedProtocolLBService: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}

@janosi
Copy link
Contributor Author

janosi commented Oct 3, 2022

@bowei @robscott @rtheis this feature would go GA in 1.26
IBM Cloud Provider: according to an earlier comment here #1435 (comment) the validation of mixed protocol services has been merged into the CPI implementation. I have seen that this validation was removed from the code 4 days ago here IBM-Cloud/cloud-provider-ibm@094d71b Is it OK to remove the feature flag in 1.26?

GCP: Some "work" was mentioned in an earlier comment here at the time of beta graduation #1435 (comment) I would like to ask whether the feature can go GA in 1.26.

Thank you!

@rtheis
Copy link

rtheis commented Oct 3, 2022

@janosi I defer to John Kasperski to answer your question.

@jckasper
Copy link

jckasper commented Oct 3, 2022

@janosi Mixed protocol LB support was initially disabled for the IBM Cloud managed Kubernetes environments because we did not have a chance to investigate or test this mixed LB support with our underlying infrastructure. That investigation is now complete. We have enabled mixed protocol (TCP + UDP only) for both our Classic and VPC environments for the Kubernetes 1.25 release. IBM Cloud is OK with removing this feature flag in 1.26.

@janosi
Copy link
Contributor Author

janosi commented Oct 4, 2022

Cloud status changes when comparing to the beta situation here: #1435 (comment)

@janosi
Copy link
Contributor Author

janosi commented Oct 4, 2022

@rhockenbury I am working on the KEP update. I have some difficulties with the initiating the PR due to our contribution processes, but I hope I can open the PR tomorrow.

Meanwhile could you please check my question here #1435 (comment) Thank you!

@rhockenbury
Copy link

rhockenbury commented Oct 5, 2022

Hello @rhockenbury, thank you for the list of TODOs.

I wonder, when changing the feature flag, should I

  • remove the flag from k/k; or
  • change the flag to MixedProtocolLBService: {Default: true, PreRelease: featuregate.GA}; or
  • change the flag to MixedProtocolLBService: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}

The third one - typically owners will also throw in a comment to specify the milestone for removal. Here's an example.

@andrewsykim
Copy link
Member

andrewsykim commented Oct 5, 2022

Meanwhile could you please check my question here #1435 (comment) Thank you!

@janosi when taking this feature to GA, we should: change the flag to MixedProtocolLBService: {Default: true, PreRelease: featuregate.GA, LockToDefault: true} and remove all references to the feature gate. Also leave a comment to remove the flag two releases after GA.

@janosi
Copy link
Contributor Author

janosi commented Oct 5, 2022

@rhockenbury @andrewsykim Thank you for your answers!

Meanwhile I could open the KEP PR here #3587

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

I'll mark it as Tracked once #3587 is merged.

@janosi
Copy link
Contributor Author

janosi commented Oct 6, 2022

KEP-1435 GA PR to k/k kubernetes/kubernetes#112895

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

With #3587 merged, this is now tracked for v1.26. Thanks.

@Atharva-Shinde
Copy link

Atharva-Shinde commented Oct 31, 2022

Hey @janosi @thockin @bridgetkromhout 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

As always, we are here to help should questions come up.
Thanks :)

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @janosi ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@janosi
Copy link
Contributor Author

janosi commented Nov 2, 2022

@Atharva-Shinde The only k/k PR is the kubernetes/kubernetes#112895
@katmutua I started working on the documentation, too.

@janosi
Copy link
Contributor Author

janosi commented Nov 2, 2022

@katmutua The doc PR is kubernetes/website#37676

@janosi
Copy link
Contributor Author

janosi commented Nov 3, 2022

@Atharva-Shinde k/k PR kubernetes/kubernetes#112895 has been merged.

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in SIG-Network KEPs Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
GA (merged, gate not removed)
Development

No branches or pull requests