Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl debug #1441

Open
soltysh opened this issue Jan 9, 2020 · 46 comments
Open

kubectl debug #1441

soltysh opened this issue Jan 9, 2020 · 46 comments

Comments

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 9, 2020

Enhancement Description

@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Jan 9, 2020

/stage alpha
/kind feature
/sig cli
/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig label Jan 9, 2020
@verb verb mentioned this issue Jan 10, 2020
7 of 17 tasks complete
@jeremyrickard
Copy link
Contributor

@jeremyrickard jeremyrickard commented Jan 14, 2020

Hey there @soltysh can you confirm that this will be in the 1.18 release? To make it into the release, the KEP will need to be merged as implementablewith a Test Plan (looks like that's a TODO) by enhancements freeze, which is going to be end of day (pacific time) on January 28th

@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Jan 15, 2020

@jeremyrickard yup, I confirm. The KEP should be merged later today after SIG-CLI call, then we'll start with the implementation right away.

@jeremyrickard
Copy link
Contributor

@jeremyrickard jeremyrickard commented Jan 16, 2020

Thanks for getting the KEP in @soltysh 🎊

@palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 29, 2020

Updated the issue description with KEP link.

@VineethReddy02
Copy link

@VineethReddy02 VineethReddy02 commented Feb 5, 2020

Hello, @soltysh, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@verb
Copy link
Contributor

@verb verb commented Feb 6, 2020

@VineethReddy02 ack, this will include doc updates and we will open a placeholder PR by Feb 28. Thanks!

@helayoty
Copy link
Member

@helayoty helayoty commented Mar 4, 2020

Hi @soltysh @verb We're only a few days out from code freeze now. It does not look like your PRs have merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

@verb
Copy link
Contributor

@verb verb commented Mar 4, 2020

@helayoty I expect this to merge in time.

@3k8
Copy link

@3k8 3k8 commented Mar 29, 2020

Add support for override image command & args for debug some error between container starting?
such as

kubectl run nginx --image nginx --debug
apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    run: nginx
  name: nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      run: nginx
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        run: nginx
    spec:
      containers:
      - image: nginx
        name: nginx
        command: ["sleep"]
        args: ["1d"]
        resources: {}
@verb
Copy link
Contributor

@verb verb commented Mar 30, 2020

@cnk8s This is indeed included in the proposal. See Pod Troubleshooting by Copy

@verb
Copy link
Contributor

@verb verb commented Apr 3, 2020

@aylei Are you interested in working on Pod Troubleshooting by Copy for 1.19? or anything else related to debug?

@aylei
Copy link
Contributor

@aylei aylei commented Apr 7, 2020

@verb Absolutely

@aylei
Copy link
Contributor

@aylei aylei commented Apr 7, 2020

I will draft a PR this week

@zanetworker
Copy link

@zanetworker zanetworker commented Apr 10, 2020

@verb reading the KEP, I still don't get how pod-troubleshooting by copy would work, what does copy mean in this case?

@verb
Copy link
Contributor

@verb verb commented Sep 24, 2020

Hi @kikisdeliveryservice,

There's been a change of plans. After chatting with sig-cli in the last meeting we've decided to pursue graduation to beta in 1.20. (cc @soltysh).

Thanks!

@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Sep 24, 2020

That is correct!

@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Sep 24, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 24, 2020
@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Sep 24, 2020

/stage beta

@kikisdeliveryservice
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice commented Sep 24, 2020

Thank you for the update!

@MorrisLaw
Copy link
Member

@MorrisLaw MorrisLaw commented Sep 28, 2020

Hey @soltysh -- 1.20 Enhancements Shadow here 👋

Friendly reminder that the Enhancements Freeze deadline is October 6th and I've noticed that the KEP is following the old format. Time permitting, can we please update the KEP to be in the new directory format and include a kep.yaml. That would be extremely helpful! The new format is detailed here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Regards,
Jeremy

@verb
Copy link
Contributor

@verb verb commented Sep 28, 2020

Hi @MorrisLaw,

#2007 updates the KEP to the new format, and @soltysh and I plan on merging before October 6.

Thanks,

@MorrisLaw
Copy link
Member

@MorrisLaw MorrisLaw commented Oct 12, 2020

Hi @verb ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best,
Jeremy

@SomtochiAma
Copy link

@SomtochiAma SomtochiAma commented Oct 21, 2020

Hello @soltysh @verb, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@verb
Copy link
Contributor

@verb verb commented Oct 21, 2020

@SomtochiAma ack, will open PR against dev-1.20 branch by Nov 6.

@SomtochiAma
Copy link

@SomtochiAma SomtochiAma commented Oct 31, 2020

Hi @verb
The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

Thank you!

@verb
Copy link
Contributor

@verb verb commented Nov 2, 2020

Pending PRs for 1.20:

@MorrisLaw
Copy link
Member

@MorrisLaw MorrisLaw commented Nov 2, 2020

Thank you for the PR links @verb !

@verb
Copy link
Contributor

@verb verb commented Nov 3, 2020

Opened remaining 1.20 PR and updated list.

@MorrisLaw
Copy link
Member

@MorrisLaw MorrisLaw commented Nov 10, 2020

Hey @verb is this the last PR that had to be merged? k/k #96264: Bugfix for --set-image

Are there any other k/k PRs?

Just a reminder regarding upcoming dates:

@verb
Copy link
Contributor

@verb verb commented Nov 10, 2020

Hi @MorrisLaw,

That was the last. We have no more k/k PRs planned for 1.20.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung added tracked/no and removed tracked/yes labels Jan 7, 2021
@verb
Copy link
Contributor

@verb verb commented Jan 12, 2021

We have some minor improvements to kubectl debug in the works for 1.21, namely kubernetes/kubernetes#97887 to support configurable capabilities and supporting #1690 if it merges, but nothing major.

@soltysh shall we plan for stable release in 1.22 if nothing else comes up?

@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Jan 25, 2021

@soltysh shall we plan for stable release in 1.22 if nothing else comes up?

Yeah, that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet