Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP 1441 - kubectl debug #1441

Open
2 of 3 tasks
soltysh opened this issue Jan 9, 2020 · 82 comments
Open
2 of 3 tasks

KEP 1441 - kubectl debug #1441

soltysh opened this issue Jan 9, 2020 · 82 comments
Assignees
Labels
kind/feature sig/cli stage/beta

Comments

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 9, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig label Jan 9, 2020
@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Jan 9, 2020

/stage alpha
/kind feature
/sig cli
/milestone v1.18

@k8s-ci-robot k8s-ci-robot added stage/alpha kind/feature sig/cli labels Jan 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig label Jan 9, 2020
@verb verb mentioned this issue Jan 10, 2020
21 tasks
@jeremyrickard
Copy link
Contributor

@jeremyrickard jeremyrickard commented Jan 14, 2020

Hey there @soltysh can you confirm that this will be in the 1.18 release? To make it into the release, the KEP will need to be merged as implementablewith a Test Plan (looks like that's a TODO) by enhancements freeze, which is going to be end of day (pacific time) on January 28th

@jeremyrickard jeremyrickard added the tracked/no label Jan 14, 2020
@soltysh
Copy link
Contributor Author

@soltysh soltysh commented Jan 15, 2020

@jeremyrickard yup, I confirm. The KEP should be merged later today after SIG-CLI call, then we'll start with the implementation right away.

@jeremyrickard jeremyrickard added tracked/yes and removed tracked/no labels Jan 16, 2020
@jeremyrickard
Copy link
Contributor

@jeremyrickard jeremyrickard commented Jan 16, 2020

Thanks for getting the KEP in @soltysh 🎊

@palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 29, 2020

Updated the issue description with KEP link.

@VineethReddy02
Copy link

@VineethReddy02 VineethReddy02 commented Feb 5, 2020

Hello, @soltysh, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@verb
Copy link
Contributor

@verb verb commented Feb 6, 2020

@VineethReddy02 ack, this will include doc updates and we will open a placeholder PR by Feb 28. Thanks!

@helayoty
Copy link
Member

@helayoty helayoty commented Mar 4, 2020

Hi @soltysh @verb We're only a few days out from code freeze now. It does not look like your PRs have merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

@verb
Copy link
Contributor

@verb verb commented Mar 4, 2020

@helayoty I expect this to merge in time.

@3k8
Copy link

@3k8 3k8 commented Mar 29, 2020

Add support for override image command & args for debug some error between container starting?
such as

kubectl run nginx --image nginx --debug
apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    run: nginx
  name: nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      run: nginx
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        run: nginx
    spec:
      containers:
      - image: nginx
        name: nginx
        command: ["sleep"]
        args: ["1d"]
        resources: {}

@verb
Copy link
Contributor

@verb verb commented Mar 30, 2020

@cnk8s This is indeed included in the proposal. See Pod Troubleshooting by Copy

@verb
Copy link
Contributor

@verb verb commented Apr 3, 2020

@aylei Are you interested in working on Pod Troubleshooting by Copy for 1.19? or anything else related to debug?

@aylei
Copy link
Contributor

@aylei aylei commented Apr 7, 2020

@verb Absolutely

@aylei
Copy link
Contributor

@aylei aylei commented Apr 7, 2020

I will draft a PR this week

@zanetworker
Copy link

@zanetworker zanetworker commented Apr 10, 2020

@verb reading the KEP, I still don't get how pod-troubleshooting by copy would work, what does copy mean in this case?

@verb
Copy link
Contributor

@verb verb commented Oct 1, 2021

@jlbutler Ack. Placeholder PR is kubernetes/website#29876. Thanks!

@Priyankasaggu11929
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 commented Nov 8, 2021

Hello @soltysh & @verb 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thank you so much! 🙂

@verb
Copy link
Contributor

@verb verb commented Nov 16, 2021

@Priyankasaggu11929 @soltysh @knight42

We're making progress on this feature, but it won't merge by the freeze. Let's opt-out for 1.23. Thanks!

@Priyankasaggu11929
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 commented Nov 16, 2021

We're making progress on this feature, but it won't merge by the freeze. Let's opt-out for 1.23. Thanks!

Thank you so much for the update @verb.

I'll remove the milestone for now, as you suggested. Please let us know, if we could be of any help. 🙂

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Nov 16, 2021
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no and removed tracked/yes labels Nov 16, 2021
@gracenng gracenng added this to the v1.24 milestone Jan 14, 2022
@gracenng gracenng added tracked/yes and removed tracked/no labels Jan 14, 2022
@gracenng
Copy link
Member

@gracenng gracenng commented Jan 18, 2022

Hi @verb ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting beta for 1.24, is that correct?.
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as tracked. I see that in the kep.yaml , beta milestone is for 1.20. Is this feature already in beta?
Thanks!

@verb
Copy link
Contributor

@verb verb commented Jan 18, 2022

Hi @gracenng, KEP author here. This feature is already in beta. We revised the KEP last cycle to address user feedback, and we're implementing it this cycle. The feature is not graduating in 1.24. Thanks!

@gracenng
Copy link
Member

@gracenng gracenng commented Jan 19, 2022

Hi @verb , does this mean the feature will opt-in for the 1.24 release but remain in beta

@verb
Copy link
Contributor

@verb verb commented Jan 19, 2022

Hi @gracenng, I'm sensing that this isn't fitting into the standard procedure. That's not my intention, so I'm probably not using the correct process/terminology. I'm sorry that I don't know what "opt-in" means in this context.

For the 1.24 cycle we would like to:

  1. Merge PRs that implement features described in the KEP
  2. Have those changes released in kubectl version 1.24.
  3. remain at the existing maturity level (i.e. beta)

Please let me know the process I should follow to make this happen. Thanks!

@gracenng
Copy link
Member

@gracenng gracenng commented Jan 20, 2022

Hi @verb , "opt-in" means that you would like the feature to be released in the 1.24 version. All good here!

PS: If you could list the code PR's here, it'd be very helpful for the enhancements team. Thanks!

@gracenng
Copy link
Member

@gracenng gracenng commented Jan 22, 2022

Hi @verb , the Enhancements team received 2 KEP records for this issue. Could you please confirm if it needs docs or not?
Thanks :D
image

@verb
Copy link
Contributor

@verb verb commented Jan 24, 2022

Hi @gracenng, we'll need docs. Thanks!

@johnbelamaric
Copy link
Contributor

@johnbelamaric johnbelamaric commented Jan 28, 2022

Hi @verb. Can you review the PRR questions and make sure that none of the new changes in 1.24 require updates to those questions?

Thanks.

@verb
Copy link
Contributor

@verb verb commented Feb 4, 2022

Hi @johnbelamaric, 👍 I've reviewed the PRR questions to confirm that nothing will change with what we have planned. FYI, it's the same basic functionality, just an additional flag to tweak the config of the pods we're generating, and it will be backwards compatible.

@chrisnegus
Copy link

@chrisnegus chrisnegus commented Feb 11, 2022

Hi @verb 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@verb
Copy link
Contributor

@verb verb commented Mar 14, 2022

@chrisnegus 👋 I opened kubernetes/website#32265 as a 1.24 placeholder.

@gracenng
Copy link
Member

@gracenng gracenng commented Mar 15, 2022

Hi @verb 1.24 Enhancements Team here,
With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

(Update)
Open Implementation k/k PR:

@katcosgrove
Copy link

@katcosgrove katcosgrove commented Mar 21, 2022

Hey y'all! We're approaching last call for feature blogs, as the freeze is Wednesday, March 23. If you would like to have a feature blog for this, please add it to the tracking sheet and reach out to me if you have any questions. Thank you!

@verb
Copy link
Contributor

@verb verb commented Mar 28, 2022

Hi @gracenng, We didn't get this finished in time. Let's please slip this to 1.25. Thanks!

@gracenng gracenng removed the tracked/yes label Mar 29, 2022
@gracenng gracenng removed this from the v1.24 milestone Mar 29, 2022
@soltysh soltysh changed the title kubectl debug KEP 1441 - kubectl debug May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature sig/cli stage/beta
Projects
None yet
Development

No branches or pull requests