Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE PD in-tree to CSI driver migration #1488

Closed
2 tasks done
davidz627 opened this issue Jan 21, 2020 · 57 comments
Closed
2 tasks done

GCE PD in-tree to CSI driver migration #1488

davidz627 opened this issue Jan 21, 2020 · 57 comments
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@davidz627
Copy link
Contributor

davidz627 commented Jan 21, 2020

Enhancement Description

Parent enhancement: #625
Public Migration testing CI: https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver#Migration%20Kubernetes%20Master%20Driver%20Latest

TODO

  • Replace design/KEP with specific one if needed
    • Not necessary as PD Migration is standard and does not require additional work
  • Link public migration testing CI
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2020
@davidz627
Copy link
Contributor Author

davidz627 commented Jan 21, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2020
@jeremyrickard jeremyrickard added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 23, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 23, 2020

Hey @davidz627 just to clarify this is NOT for v1.18 correct?

@davidz627
Copy link
Contributor Author

davidz627 commented Jan 23, 2020

Right, our planned GA is 1.19

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 23, 2020

Awesome! I'll mark it as deferred to 1.19 in the release tracking stuff so we reach out early next release!
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 23, 2020
@fejta-bot
Copy link

fejta-bot commented Apr 22, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 27, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

Hi @davidz627 -- 1.19 Enhancements Lead here, I wanted to confirm if this enhancement is going to graduate to Stable in 1.19 as planned above?


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@palnabarun
Copy link
Member

palnabarun commented May 11, 2020

Hi @davidz627, pinging back as a reminder for the above. 🙂

@palnabarun
Copy link
Member

palnabarun commented May 18, 2020

Hi @davidz627,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

@davidz627 -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone May 20, 2020
@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @davidz627

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 24, 2020

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? To be included in the milestone:
The KEP must be merged in an implementable state
The KEP must have test plans (missing: need this for beta->GA)
The KEP must have graduation criteria

If you could please update to the new template and include the missing sections noted above that would be great. See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

I also note that the implementation history of the KEP also needs to be updated.

Thanks!
Kirsten

@msau42
Copy link
Member

msau42 commented Oct 2, 2020

/assign @mattcary
We do not have plans to move this feature to GA in 1.20

@fejta-bot
Copy link

fejta-bot commented Dec 31, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2020
@mattcary
Copy link
Contributor

mattcary commented Jan 4, 2021

/remove-lifecycle stale

We are evaluating whether this will be in 1.21 or 1.22.

@xing-yang
Copy link
Contributor

xing-yang commented May 23, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@rhockenbury rhockenbury added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 4, 2022
@rhockenbury
Copy link

rhockenbury commented Jun 4, 2022

👋 Hello @davidz627,

1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@mattcary
Copy link
Contributor

mattcary commented Jun 6, 2022

@rhockenbury fyi I can take point on this, I think David has moved on.

I'll update the test plan in the kep. A question about procedure, though. It looks like this kep is already approved for stable; after I update the test plan what is the next step to do?

@rhockenbury
Copy link

rhockenbury commented Jun 7, 2022

Hi @mattcary - Yes, the PRR looks to be all set. Once the test plan section is updated, that will take care of all requirements on this KEP for enhancement freeze and this enhancement will be tracked for the release. After enhancement freeze, the next deadline is code freeze on 18:00 PDT Tues 2nd Aug where all code for k/k needs to be merged. Let me know if you have any more questions.

@mattcary
Copy link
Contributor

mattcary commented Jun 7, 2022

Makes sense. #3351 created

@Jiawei0227
Copy link
Contributor

Jiawei0227 commented Jun 7, 2022

I think another action item is to lock down the feature gate. And enable intreeGCEUnregistry on by default?

@rhockenbury
Copy link

rhockenbury commented Jun 15, 2022

With #3351 merged, I have marked this as tracked for the v1.25 cycle. Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 19, 2022

Apologies for the noise ^

Hello @mattcary 👋, we would require mentioning the unit-tests in the format specified in the updated test plan section template.

Could you please update the Test Plan section in the merged KEP as per the format required?

Please plan to get it finished by the enhancements freeze on Thursday, June 23rd, 2022. Thank you so much!

@mattcary
Copy link
Contributor

mattcary commented Jun 22, 2022

No problem, does #3421 do the right thing? (we can move the conversation over there)

@krol3
Copy link

krol3 commented Jul 6, 2022

Hello @mattcary 👋, 1.25 Release Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

@rhockenbury
Copy link

rhockenbury commented Jul 21, 2022

👋 Hey @mattcary,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze:
[ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
[ ] All PRs are fully merged by the code freeze deadline.

Looks like there is one PR in k/k for the graduation for this enhancement to stable. Let me know if I missed any other PRs that need to be tracked.

As always, we are here to help should questions come up. Thanks!!

@rhockenbury
Copy link

rhockenbury commented Jul 27, 2022

Gentle reminder that we are about a week from code freeze, and all k/k PRs need to be merged before code freeze for this enhancement to be included in v1.25. Please also let me know if there are any other PRs we should be tracking.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

With k/k PR kubernetes/kubernetes#111301 now merged, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @mattcary.

@cathchu
Copy link

cathchu commented Aug 4, 2022

Hey there @mattcary 👋, 1.25 Release Docs Shadow here!

This enhancement is still marked as ‘Needs Docs’ for 1.25 release.

Tomorrow (August 4th) is the deadline for opening a placeholder PR against dev-1.25 branch in the k/website repo.

Please follow the steps detailed in the documentation to open the PR. This PR can be just a placeholder at this for now, as final docs PRs are due August 9th.

For more info, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

@mattcary
Copy link
Contributor

mattcary commented Aug 4, 2022

Hey @cathchu , I started kubernetes/website#35684 but then learned that it's covered by kubernetes/website#35685. So I think we're okay here?

Let me know if I've misinterpreted and need to do something.

/cc @xing-yang

@cathchu
Copy link

cathchu commented Aug 4, 2022

@mattcary, I see now!

We'll track the one opened against dev-1.25.

Thanks so much!

@rhockenbury
Copy link

rhockenbury commented Sep 11, 2022

@davidz627 Can we close this since it's graduated to stable?

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@mattcary
Copy link
Contributor

mattcary commented Sep 12, 2022

I think so. @Jiawei0227 any objections?

@Jiawei0227
Copy link
Contributor

Jiawei0227 commented Sep 13, 2022

no, sgtm

@rhockenbury
Copy link

rhockenbury commented Sep 13, 2022

Thanks all.

/milestone clear
/close

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Sep 13, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 13, 2022

@rhockenbury: Closing this issue.

In response to this:

Thanks all.

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
No open projects
Development

No branches or pull requests