GCE PD in-tree to CSI driver migration

[davidz627]

Enhancement Description

• One-line enhancement description (can be used as a release note): Migrate the internals of in-tree GCE PD Plugin to call out to the PD CSI Driver while maintaining the original API
• Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md
• Primary contact (assignee): @davidz627
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release: 1.14
  • Beta release: 1.17
  • Stable release target (x.y): 1.19

Parent enhancement: #625
Public Migration testing CI: https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver#Migration%20Kubernetes%20Master%20Driver%20Latest

TODO

• Replace design/KEP with specific one if needed
  • Not necessary as PD Migration is standard and does not require additional work
• Link public migration testing CI

[davidz627]

/sig storage

[jeremyrickard]

Hey @davidz627 just to clarify this is NOT for v1.18 correct?

[davidz627]

Right, our planned GA is 1.19

[jeremyrickard]

Awesome! I'll mark it as deferred to 1.19 in the release tracking stuff so we reach out early next release!
/milestone v1.19

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[palnabarun]

Hi @davidz627 -- 1.19 Enhancements Lead here, I wanted to confirm if this enhancement is going to graduate to Stable in 1.19 as planned above?

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[palnabarun]

Hi @davidz627, pinging back as a reminder for the above. 🙂

[palnabarun]

Hi @davidz627,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

[palnabarun]

@davidz627 -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[palnabarun]

/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @davidz627

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[kikisdeliveryservice]

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? To be included in the milestone:
The KEP must be merged in an implementable state
The KEP must have test plans (missing: need this for beta->GA)
The KEP must have graduation criteria

If you could please update to the new template and include the missing sections noted above that would be great. See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

I also note that the implementation history of the KEP also needs to be updated.

Thanks!
Kirsten

[msau42]

/assign @mattcary
We do not have plans to move this feature to GA in 1.20

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[mattcary]

/remove-lifecycle stale

We are evaluating whether this will be in 1.21 or 1.22.

[rhockenbury]

Hi @mattcary - Yes, the PRR looks to be all set. Once the test plan section is updated, that will take care of all requirements on this KEP for enhancement freeze and this enhancement will be tracked for the release. After enhancement freeze, the next deadline is code freeze on 18:00 PDT Tues 2nd Aug where all code for k/k needs to be merged. Let me know if you have any more questions.

[mattcary]

Makes sense. #3351 created

[Jiawei0227]

I think another action item is to lock down the feature gate. And enable intreeGCEUnregistry on by default?

[rhockenbury]

With #3351 merged, I have marked this as tracked for the v1.25 cycle. Thanks!

[Priyankasaggu11929]

Apologies for the noise ^

Hello @mattcary 👋, we would require mentioning the unit-tests in the format specified in the updated test plan section template.

Could you please update the Test Plan section in the merged KEP as per the format required?

Please plan to get it finished by the enhancements freeze on Thursday, June 23rd, 2022. Thank you so much!

[mattcary]

No problem, does #3421 do the right thing? (we can move the conversation over there)

[krol3]

Hello @mattcary 👋, 1.25 Release Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

[rhockenbury]

👋 Hey @mattcary,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze:
[ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
[ ] All PRs are fully merged by the code freeze deadline.

Looks like there is one PR in k/k for the graduation for this enhancement to stable. Let me know if I missed any other PRs that need to be tracked.

As always, we are here to help should questions come up. Thanks!!

[rhockenbury]

Gentle reminder that we are about a week from code freeze, and all k/k PRs need to be merged before code freeze for this enhancement to be included in v1.25. Please also let me know if there are any other PRs we should be tracking.

[Priyankasaggu11929]

With k/k PR kubernetes/kubernetes#111301 now merged, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @mattcary.

[cathchu]

Hey there @mattcary 👋, 1.25 Release Docs Shadow here!

This enhancement is still marked as ‘Needs Docs’ for 1.25 release.

Tomorrow (August 4th) is the deadline for opening a placeholder PR against dev-1.25 branch in the k/website repo.

Please follow the steps detailed in the documentation to open the PR. This PR can be just a placeholder at this for now, as final docs PRs are due August 9th.

For more info, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

[mattcary]

Hey @cathchu , I started kubernetes/website#35684 but then learned that it's covered by kubernetes/website#35685. So I think we're okay here?

Let me know if I've misinterpreted and need to do something.

/cc @xing-yang

[cathchu]

@mattcary, I see now!

We'll track the one opened against dev-1.25.

Thanks so much!

[rhockenbury]

@davidz627 Can we close this since it's graduated to stable?

[mattcary]

I think so. @Jiawei0227 any objections?

[Jiawei0227]

no, sgtm

[rhockenbury]

Thanks all.

/milestone clear
/close

[k8s-ci-robot]

@rhockenbury: Closing this issue.

In response to this:

Thanks all.

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.