Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure disk in-tree to CSI driver migration #1490

Closed
2 tasks
davidz627 opened this issue Jan 21, 2020 · 70 comments
Closed
2 tasks

Azure disk in-tree to CSI driver migration #1490

davidz627 opened this issue Jan 21, 2020 · 70 comments
Assignees
Labels
area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@davidz627
Copy link
Contributor

davidz627 commented Jan 21, 2020

Enhancement Description

Parent enhancement: #625
Public Migration testing CI: LINK

TODO

  • Replace design/KEP with specific one if needed
  • Link public migration testing CI
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2020
@davidz627
Copy link
Contributor Author

davidz627 commented Jan 21, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2020
@andyzhangx
Copy link
Member

andyzhangx commented Jan 22, 2020

azure disk & file won't go BETA on 1.18 since there is dependency on csi windows, if we go beta, that means all requests for built-in driver would be redirected to csi driver, while csi driver does not work on Windows, that will break azure disk & file driver on Windows

@andyzhangx
Copy link
Member

andyzhangx commented Jan 22, 2020

/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider labels Jan 22, 2020
@andyzhangx
Copy link
Member

andyzhangx commented Jan 22, 2020

@davidz627 thanks for driving this

@feiskyer
Copy link
Member

feiskyer commented Jan 22, 2020

/assign @andyzhangx

@davidz627
Copy link
Contributor Author

davidz627 commented Jan 22, 2020

@andyzhangx feel free to edit description, you are the owner of this issue now :)

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2020

@feiskyer @andyzhangx should we track this for 1.18? It looks like your description indicates you plan to go beta on this, but the linked issue indicates you're blocked by some windows things?

@jeremyrickard jeremyrickard added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 23, 2020
@feiskyer
Copy link
Member

feiskyer commented Jan 23, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 23, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 23, 2020

Thanks @feiskyer!

@fejta-bot
Copy link

fejta-bot commented Apr 22, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 27, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

Hi @feiskyer -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate to Beta in 1.19?


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@andyzhangx
Copy link
Member

andyzhangx commented May 8, 2020

Azure disk & azure file migration would go beta in 1.19, here is the PR: kubernetes/kubernetes#90896

@palnabarun
Copy link
Member

palnabarun commented May 11, 2020

Hi @andyzhangx 👋 , thank you for the update. I've updated the tracking sheet accordingly.

Let us know if there are any other PR's that you would want to track for this release.

@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@rhockenbury
Copy link

rhockenbury commented Jan 16, 2022

/stage stable
/tracked yes

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 16, 2022
@rhockenbury
Copy link

rhockenbury commented Jan 16, 2022

Hi @andyzhangx! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting stable for 1.24.

Here’s where this enhancement currently stands:

The status of this enhancement is at risk. Thanks!

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 17, 2022
@andyzhangx
Copy link
Member

andyzhangx commented Jan 18, 2022

@davidz627 could you mark the target as 1.25 as GA in this issue? Thanks.

@andyzhangx
Copy link
Member

andyzhangx commented Jan 18, 2022

@davidz627 BTW, you will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@msau42
Copy link
Member

msau42 commented Jan 19, 2022

@andyzhangx can you confirm if you want to target GA in 1.24 or 1.25?

@andyzhangx
Copy link
Member

andyzhangx commented Jan 20, 2022

@msau42 Azure disk target GA in 1.24

@msau42
Copy link
Member

msau42 commented Jan 20, 2022

You will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@andyzhangx I think it's better if you submit the PR after you have finished all the necessary testing and other GA requirements.

@andyzhangx
Copy link
Member

andyzhangx commented Jan 21, 2022

You will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@andyzhangx I think it's better if you submit the PR after you have finished all the necessary testing and other GA requirements.

@msau42 here is the PR: kubernetes/kubernetes#107681

@rhockenbury
Copy link

rhockenbury commented Jan 27, 2022

I see that #3109 has been merged. I have updated the status to tracked for enhancement freeze.

@didicodes
Copy link

didicodes commented Feb 13, 2022

Hi @andyzhangx, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

@rhockenbury
Copy link

rhockenbury commented Mar 22, 2022

Hi @andyzhangx

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like just k/k#107681 needs to be merged. Let me know if there are any other PRs that we should be tracking for 1.24 code freeze.

Let me know if you have any questions.

@rhockenbury
Copy link

rhockenbury commented Mar 29, 2022

Friendly reminder to try to merge k/k#107681 before code freeze at 01:00 UTC Wednesday 30th March 2022.

@andyzhangx
Copy link
Member

andyzhangx commented Apr 2, 2022

kubernetes/kubernetes#107681 is already merged, so we could close this issue now? @msau42

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @andyzhangx @davidz627 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@andyzhangx
Copy link
Member

andyzhangx commented May 9, 2022

thanks, I have worked out a PR: #3300

@andyzhangx
Copy link
Member

andyzhangx commented May 9, 2022

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 9, 2022

@andyzhangx: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Provider Azure automation moved this from In progress to Done May 9, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Development

No branches or pull requests