Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere in-tree to CSI driver migration #1491

Open
2 tasks
davidz627 opened this issue Jan 21, 2020 · 107 comments
Open
2 tasks

vSphere in-tree to CSI driver migration #1491

davidz627 opened this issue Jan 21, 2020 · 107 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@davidz627
Copy link
Contributor

davidz627 commented Jan 21, 2020

Enhancement Description

Parent enhancement: #625
Public Migration testing CI: LINK

TODO

  • Replace design/KEP with specific one if needed
  • Link public migration testing CI
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2020
@davidz627
Copy link
Contributor Author

davidz627 commented Jan 21, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2020

Hey @davidz627,

I see in the enhancement description you're targeting 1.18 for this. Can you confirm if this will be in 1.18? Enhancement Freeze is about a week away and we'll need to track it now if you'd like to be included? I think in #625 you indicated 1.19 for that one, are these enhancements to track at a more granular level?

Thanks!

@davidz627
Copy link
Contributor Author

davidz627 commented Jan 22, 2020

Yes, this is more granular. There is specific integration work required for each in-tree plugin - each of which is gated by a seperate feature flag and graduates at it's own rate based on set criteria. IIUC @divyenpatel and @xing-yang are leading the vSphere storage migration and AFAIK planned a 1.18 alpha so you should confirm with them.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2020

@davidz627 , as a bit of a process issue, could we get the KEP updated with the actual test plan instead of the statement that just references the design proposal?

@xing-yang
Copy link
Contributor

xing-yang commented Jan 22, 2020

@jeremyrickard we are still planning 1.18 alpha for vSphere driver. Can you track this please? Thanks.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2020

@xing-yang yep, we'll track this. The KEP will need to be updated with the actual test plan instead of the reference to the design proposal for us to get it past enhancement freeze though.

cc: @johnbelamaric @alejandrox1 @mrbobbytables

@xing-yang
Copy link
Contributor

xing-yang commented Jan 22, 2020

Thanks @jeremyrickard! Looks like @davidz627 will update the main KEP with test plan.

@davidz627
Copy link
Contributor Author

davidz627 commented Jan 23, 2020

PTAL #1499

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 23, 2020

THANK YOU SO MUCH @davidz627

@jeremyrickard jeremyrickard added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 23, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 23, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 23, 2020
@palnabarun
Copy link
Member

palnabarun commented Jan 27, 2020

@davidz627 Just a friendly reminder, we are less than 2 days away from the Enhancements Freeze (3PM Pacific Time, Tuesday, January 28th).

I see that PR to update the KEP test plans is still open. Let us know if the release team can help in any way.

@davidz627
Copy link
Contributor Author

davidz627 commented Jan 28, 2020

@palnabarun the test plan has merged

@VineethReddy02
Copy link

VineethReddy02 commented Feb 5, 2020

Hello, @davidz627, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@davidz627
Copy link
Contributor Author

davidz627 commented Feb 5, 2020

This should have new docs much like the ones already existing for migration for GCE and AWS.
/cc @xing-yang @divyenpatel
who are owning this issue

@xing-yang
Copy link
Contributor

xing-yang commented Feb 6, 2020

@VineethReddy02 @davidz627 we'll submit a doc PR soon. Thanks!

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 11, 2020

Hey there @xing-yang @divyenpatel

cc: @davidz627,

Just a friendly reminder that code freeze for 1.18 is March 05, 2020.

As we track toward code freeze, please list out/link to any PRs you are working on toward graduating this enhancement!

@VineethReddy02
Copy link

VineethReddy02 commented Feb 21, 2020

Hello @xing-yang
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

@xing-yang
Copy link
Contributor

xing-yang commented Feb 21, 2020

Hi @VineethReddy02, doc placeholder PR submitted here:
kubernetes/website#19227

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 24, 2020

Hey there @xing-yang, are there any k/k PRs that are open for this issue? As a reminder, we're getting close to code freeze next week 05 March 2020 and we'd like to track any work that is occurring for this issue.

@xing-yang
Copy link
Contributor

xing-yang commented Feb 25, 2020

Hi @jeremyrickard, we are not going to make the March 5th deadline. We will be targeting 1.19 instead. Thanks.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 9, 2020

/milestone 1.19

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 9, 2020

@jeremyrickard: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeremyrickard jeremyrickard added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 9, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 9, 2020

/milestone v1.19

@marosset
Copy link
Contributor

marosset commented Jun 14, 2022

Hello @divyenpatel and @xing-yang 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@marosset
Copy link
Contributor

marosset commented Jun 14, 2022

@divyenpatel - Can you also update the milestone in the kep.yaml and in the initial message of this issue?

milestone:
alpha: "v1.18"
beta: "v1.19"
stable: "v1.26"

This enhancement is targeting beta in v1.25 correct?

Thanks!

@xing-yang
Copy link
Contributor

xing-yang commented Jun 24, 2022

@marosset This enhancement moved to Beta (with feature gate off-by-default) in v1.19. We are targeting Beta (with feature gate on-by-default) in v1.25. KEP #3366 is merged.
So what we have in kep.yaml should be correct.

@krol3
Copy link

krol3 commented Jul 6, 2022

Hello @divyenpatel 👋, 1.25 Release Docs shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

@rhockenbury
Copy link

rhockenbury commented Jul 21, 2022

👋 Hey @divyenpatel and @xing-yang,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

I didn't see any PRs (open or merged) in k/k to move to beta with feature gate on-by-default. Let me know if I missed it.

As always, we are here to help should questions come up. Thanks!!

@xing-yang
Copy link
Contributor

xing-yang commented Jul 24, 2022

@rhockenbury Thanks for the reminder! The PR that enables the feature gate by default is already merged: kubernetes/kubernetes#103523

@rhockenbury
Copy link

rhockenbury commented Jul 25, 2022

Great! I've updated the tracking sheet to mark this KEP as tracked for v1.25.

@krol3
Copy link

krol3 commented Jul 27, 2022

Hello @divyenpatel wave, 1.25 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

Hi @xing-yang a reminder about documentation

@xing-yang
Copy link
Contributor

xing-yang commented Aug 2, 2022

Hi @krol3, here's the doc PR: kubernetes/website#35551

@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 7, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Sep 7, 2022

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Sep 7, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Sep 7, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@xing-yang xing-yang added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 14, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 18, 2022

Hello @divyenpatel and @xing-yang 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, please plan to merge #3513 before enhancements freeze to meet all the criteria.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

With #3513 merged, this enhancement is now tracked for the v1.26 cycle. Thanks!

@rhockenbury
Copy link

rhockenbury commented Oct 29, 2022

Hi @divyenpatel 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

As always, we are here to help should questions come up. Thanks!

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @divyenpatel! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@msau42
Copy link
Member

msau42 commented Nov 4, 2022

Hi @divyenpatel @xing-yang. I just became aware that there are some storage systems listed as supported in the vmware compatibility guide, however they seem to fail when used with the CSI driver (intree driver works). It appears to be a problem with FCD. Does csi migration convert the intree volumes to FCD? If so then I think this issue is concerning because once csi migration is GA, there is no way to turn it off. I would like to propose we delay GA until we can resolve this issue. Let me know your thoughts, thanks.

@xing-yang
Copy link
Contributor

xing-yang commented Nov 5, 2022

Hi @msau42, can you clarify what storage systems are failing when used with the CSI driver and provide logs? We can take a look and understand what is the problem.

@divyenpatel
Copy link
Member

divyenpatel commented Nov 7, 2022

Does csi migration convert the intree volumes to FCD? If so then I think this issue is concerning because once csi migration is GA, there is no way to turn it off.

Yes CSI Migration converts vmdk (intree vSphere volumes) to FCD (First Class Disk or Improved Virtual Disk).
but FCDs are still VMDKs, and have the same backingDiskURL path. Even after vmdk is converted to FCD, we can still operate on it using in-tree vSphere volume plugin. We can continue to attach/detach/delete converted volumes using legacy APIs.

Even without we GA vSphere CSI Migration flags in the Kubernetes, migration flags are already enabled by default in the Kubernetes and vSphere CSI Driver. and Volumes are getting migrated to FCD.

@msau42
Copy link
Member

msau42 commented Nov 8, 2022

We documented the various issues encountered here: kubernetes-sigs/vsphere-csi-driver#2083. It looks like they have all been resolved, so I am comfortable proceeding with the promotion to GA this release. Thanks everyone for helping to quickly resolve the issues!

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

With kubernetes/kubernetes#113336 merged, this is now marked as tracked for code freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests