Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AppProtocol to Services and Endpoints #1507

Closed
robscott opened this issue Jan 25, 2020 · 71 comments
Closed

Adding AppProtocol to Services and Endpoints #1507

robscott opened this issue Jan 25, 2020 · 71 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@robscott
Copy link
Member

robscott commented Jan 25, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 25, 2020
@robscott
Copy link
Member Author

robscott commented Jan 25, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2020
@jeremyrickard jeremyrickard added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 27, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 27, 2020

Hey @robscott I'm adding this to the v1.18 milestone per the issue description up above. Let me know if this is not correct.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 27, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 27, 2020
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 27, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Jan 29, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 29, 2020

@robscott sorry for not catching this earlier, but the KEP for adding this field doesn't include any test plans. Could you please update the KEP and submit an Exception Request

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 30, 2020

Exception request was approved.

/milestone v1.18

@VineethReddy02
Copy link

VineethReddy02 commented Feb 5, 2020

Hello, @robscott, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@robscott
Copy link
Member Author

robscott commented Feb 6, 2020

Hey @VineethReddy02, this will require some small additions to the Service and Endpoints docs. I'll have placeholder docs PR in place by Feb 28.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Feb 10, 2020

Hi @robscott !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@robscott
Copy link
Member Author

robscott commented Feb 11, 2020

Hey @kikisdeliveryservice thanks for checking in! I'm hoping to have a PR ready in the next week or so, I'll make sure it's linked when I create it.

@VineethReddy02
Copy link

VineethReddy02 commented Feb 21, 2020

Hello @robscott
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

@robscott
Copy link
Member Author

robscott commented Feb 22, 2020

Hey @VineethReddy02, thanks for the reminder! I'll work on getting that in soon.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 24, 2020

Hey @robscott,

How are you doing on this enhancement? Have you opened a PR for this yet?

@robscott
Copy link
Member Author

robscott commented Feb 24, 2020

Hey @jeremyrickard, I've got a branch that's ~90% there, hope to have a PR in shortly.

@robscott
Copy link
Member Author

robscott commented Feb 25, 2020

@jeremyrickard I have a docs PR ready for review now: kubernetes/website#19317

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 25, 2020

Hi @robscott !

As a reminder, please open a PR to update your KEP status to implemented.

Thanks

The 1.18 Enhancements Team

@palnabarun
Copy link
Member

palnabarun commented Apr 9, 2020

@robscott Ping. Can you please mark the KEP status as implemented? 🙂

@robscott
Copy link
Member Author

robscott commented Apr 9, 2020

@palnabarun @kikisdeliveryservice Sorry for the delay here! I've added a PR that will update the KEP to reflect the additional steps required for this field to reach GA: #1676. For now I've left the KEP in an implementable state, is that the right state for a KEP that is partially implemented/in progress?

@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 9, 2021
@annajung annajung added this to the v1.21 milestone Feb 9, 2021
@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2437 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

@kendallroden
Copy link
Contributor

kendallroden commented Feb 24, 2021

Hi @robscott ,
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
  • As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@kendallroden
Copy link
Contributor

kendallroden commented Mar 1, 2021

Hey @robscott :) As a reminder, please link any k/k PR(s) or k/website PR(s) so that we can track them against the March 9th Code Freeze. Until then, this enhancement will be marked as "At Risk".

@robscott
Copy link
Member Author

robscott commented Mar 4, 2021

Hey @kendallroden, Tim pointed out that we have to wait one more cycle to remove this feature gate. This can be removed from tracking for the 1.21 cycle.

@kendallroden kendallroden added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 5, 2021
@kendallroden
Copy link
Contributor

kendallroden commented Mar 5, 2021

Thanks for the update @robscott!

@JamesLaverack
Copy link
Member

JamesLaverack commented May 1, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 1, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 1, 2021
@salaxander
Copy link

salaxander commented May 11, 2021

Hey @robscott - 1.22 enhancements team here! Looks like we'll need the KEP updated to the latest template and with graduation criteria for 1.22 before enhancements freeze on 5/13. Let us know if there's anything we can do to help!

@robscott
Copy link
Member Author

robscott commented May 11, 2021

Hey @salaxander I think this KEP is already mostly up to date with the latest template. In this case, it's just been sitting while we wait to formally remove the feature gate. I don't think there's much/anything to change on the KEP since it already reached GA in v1.20. Let me know if I missed anything though.

@thockin thockin added this to New (not evaluated) in SIG-Network KEPs via automation May 22, 2021
@thockin thockin moved this from New (not evaluated) to GA (merged, gate not removed) in SIG-Network KEPs May 22, 2021
@salaxander
Copy link

salaxander commented Jun 23, 2021

Hey @robscott - Just checking in as we're just over 2 weeks away from code freeze for 1.22. Any open or merged k/k PRs we should be tracking for this (I'm guessing just a feature gate PR)? Thanks!

@robscott
Copy link
Member Author

robscott commented Jun 25, 2021

Hey @salaxander, thanks for checking in! The feature gate PR is ready for review now. Once that merges we should be able to close out this issue.

@thockin thockin removed this from GA (merged, gate not removed) in SIG-Network KEPs Jun 25, 2021
@robscott
Copy link
Member Author

robscott commented Jun 28, 2021

The final PR has merged, closing this issue. Thanks for all the help tracking this through the release cycles!

@rhockenbury rhockenbury removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Development

No branches or pull requests