Adding AppProtocol to Services and Endpoints

[robscott]

Enhancement Description

• AppProtocol is a new optional field on ports in Endpoints and Services
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1507-app-protocol
• Primary contact (assignee): @robscott
• Responsible SIGs: network
• Enhancement target (which target equals to which milestone):
  • Alpha release target (1.18)
  • Beta release target (1.19)
  • GA release target (1.20)

[robscott]

/sig network

[jeremyrickard]

Hey @robscott I'm adding this to the v1.18 milestone per the issue description up above. Let me know if this is not correct.

[jeremyrickard]

/milestone v1.18

[jeremyrickard]

/stage stable

[jeremyrickard]

@robscott sorry for not catching this earlier, but the KEP for adding this field doesn't include any test plans. Could you please update the KEP and submit an Exception Request

[jeremyrickard]

Exception request was approved.

/milestone v1.18

[VineethReddy02]

Hello, @robscott, I'm 1.18 docs lead.
Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[robscott]

Hey @VineethReddy02, this will require some small additions to the Service and Endpoints docs. I'll have placeholder docs PR in place by Feb 28.

[kikisdeliveryservice]

Hi @robscott !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

[robscott]

Hey @kikisdeliveryservice thanks for checking in! I'm hoping to have a PR ready in the next week or so, I'll make sure it's linked when I create it.

[VineethReddy02]

Hello @robscott
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

[robscott]

Hey @VineethReddy02, thanks for the reminder! I'll work on getting that in soon.

[jeremyrickard]

Hey @robscott,

How are you doing on this enhancement? Have you opened a PR for this yet?

[robscott]

Hey @jeremyrickard, I've got a branch that's ~90% there, hope to have a PR in shortly.

[robscott]

@jeremyrickard I have a docs PR ready for review now: kubernetes/website#19317

[kikisdeliveryservice]

Hi @robscott !

As a reminder, please open a PR to update your KEP status to implemented.

Thanks

The 1.18 Enhancements Team

[palnabarun]

@robscott Ping. Can you please mark the KEP status as implemented? 🙂

[robscott]

@palnabarun @kikisdeliveryservice Sorry for the delay here! I've added a PR that will update the KEP to reflect the additional steps required for this field to reach GA: #1676. For now I've left the KEP in an implementable state, is that the right state for a KEP that is partially implemented/in progress?

[annajung]

With PR #2437 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

[kendallroden]

Hi @robscott ,
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
  • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
• As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

[kendallroden]

Hey @robscott :) As a reminder, please link any k/k PR(s) or k/website PR(s) so that we can track them against the March 9th Code Freeze. Until then, this enhancement will be marked as "At Risk".

[robscott]

Hey @kendallroden, Tim pointed out that we have to wait one more cycle to remove this feature gate. This can be removed from tracking for the 1.21 cycle.

[kendallroden]

Thanks for the update @robscott!

[JamesLaverack]

/milestone v1.22

[salaxander]

Hey @robscott - 1.22 enhancements team here! Looks like we'll need the KEP updated to the latest template and with graduation criteria for 1.22 before enhancements freeze on 5/13. Let us know if there's anything we can do to help!

[robscott]

Hey @salaxander I think this KEP is already mostly up to date with the latest template. In this case, it's just been sitting while we wait to formally remove the feature gate. I don't think there's much/anything to change on the KEP since it already reached GA in v1.20. Let me know if I missed anything though.

[salaxander]

Hey @robscott - Just checking in as we're just over 2 weeks away from code freeze for 1.22. Any open or merged k/k PRs we should be tracking for this (I'm guessing just a feature gate PR)? Thanks!

[robscott]

Hey @salaxander, thanks for checking in! The feature gate PR is ready for review now. Once that merges we should be able to close out this issue.

[robscott]

The final PR has merged, closing this issue. Thanks for all the help tracking this through the release cycles!

[qingwusunny]

@robscott Sorry, I can't find an explanation for the feature AppProtocol. If you don't mind, can you tell me how to use the feature, and what is the feature's effect. Thanks