Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming Proxy Redirects [DEPRECATED] #1558

Closed
5 tasks done
tallclair opened this issue Feb 18, 2020 · 33 comments · Fixed by kubernetes/kubernetes#106830
Closed
5 tasks done

Streaming Proxy Redirects [DEPRECATED] #1558

tallclair opened this issue Feb 18, 2020 · 33 comments · Fixed by kubernetes/kubernetes#106830
Assignees
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@tallclair
Copy link
Member

tallclair commented Feb 18, 2020

Enhancement Description

Deprecation plan:

  • release 1.18
    1. Mark the --redirect-container-streaming flag as deprecated. Log a warning on use.
    2. Mark the StreamingProxyRedirects feature as deprecated. Log a warning on use.
  • release 1.19 - no changes
  • release 1.20
    1. --redirect-container-streaming can no longer be enabled. If the flag is set, log an error
      and continue as though it is unset.
  • release 1.22 (previously: 1.21) Default StreamingProxyRedirects to disabled kubernetes#101647
    1. Default StreamingProxyRedirects to disabled. If there is a >= 2 version skew between master
      and nodes, and the old nodes were enabling --redirect-container-streaming, this will break
      them
      . In this case, the StreamingProxyRedirects can still be manually enabled.
  • release 1.24 (previously: 1.22)
    1. Remove the --redirect-container-streaming flag.
    2. Remove the StreamingProxyRedirects feature.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 18, 2020
@tallclair
Copy link
Member Author

tallclair commented Feb 18, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2020
@palnabarun
Copy link
Member

palnabarun commented May 2, 2020

Hi @tallclair, -- 1.19 Enhancements Lead here. I see from the KEP that no work is planned for 1.19. I just wanted to confirm if that is still the case?

Thank you!

@tallclair
Copy link
Member Author

tallclair commented May 7, 2020

Yep, confirmed. I'll paste the rollout plan here to make raise the visibility. We do have an action coming up in
/milestone v1.20

  1. [DONE] release 1.18
    1. Mark the --redirect-container-streaming flag as deprecated. Log a warning on use.
    2. Mark the StreamingProxyRedirects feature as deprecated. Log a warning on use.
  2. release 1.19 - no changes
  3. release 1.20
    1. --redirect-container-streaming can no longer be enabled. If the flag is set, log an error
      and continue as though it is unset.
  4. release 1.22 (was: 1.21)
    1. Default StreamingProxyRedirects to disabled. If there is a >= 2 version skew between master
      and nodes, and the old nodes were enabling --redirect-container-streaming, this will break
      them
      . In this case, the StreamingProxyRedirects can still be manually enabled.
  5. release 1.24 (was: 1.22)
    1. Remove the --redirect-container-streaming flag.
    2. Remove the StreamingProxyRedirects feature.

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone May 7, 2020
@palnabarun
Copy link
Member

palnabarun commented May 11, 2020

@tallclair Thank you for the update. Also, a big shoutout for putting put all future plans in the issue as a comment.

@fejta-bot
Copy link

fejta-bot commented Aug 9, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2020
@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @tallclair

Enhancements Lead here, can you confirm whether this will have work in 1.20? (alpha/beta/GA?)

Thanks!
Kirsten

@tallclair
Copy link
Member Author

tallclair commented Sep 17, 2020

Yes, this has some work targeting v1.20. I hoisted the rollout plan to the issue description.

@tallclair tallclair self-assigned this Sep 17, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 25, 2020

So I noticed that this is a Deprecation rollout, so I'm wondering how to track this against alpha/beta/stable.. Maybe this could be beta? But I feel like I'm forcing it 🤔

WDYT @tallclair @palnabarun ?

@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 25, 2020
@tallclair
Copy link
Member Author

tallclair commented Sep 28, 2020

Yeah, I don't think alpha/beta/ga makes sense here. I don't know enough about the feature tracking process to know what the alternatives are.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 28, 2020

@tallclair let me check on this and i'll report back!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 29, 2020

After discussing, we agree it's important to track & publicize, so we made a new status so that we can track this as a drumroll deprecation! 😄

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 11, 2020

Hey @tallclair !

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline <--- Pretty sure you'll want to do this one for the deprecation
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PRs to this issue so we can track them.

Thanks!
Kirsten 😃

@reylejano
Copy link
Member

reylejano commented Oct 19, 2020

Hello @tallclair , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@tallclair
Copy link
Member Author

tallclair commented Oct 23, 2020

No docs changes needed for this one.

@annajung
Copy link
Member

annajung commented Nov 2, 2020

Hi @tallclair

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 10, 2020

Hi @tallclair

Looks like kubernetes/kubernetes#95935 is merged and that was the only PR for 1.20 - correct?

As a note: Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks!
Kirsten

@tallclair
Copy link
Member Author

tallclair commented Nov 14, 2020

Correct.

@JamesLaverack
Copy link
Member

JamesLaverack commented May 11, 2021

Hey @tallclair, 1.22 Enhancements Lead here.

While a depreciation doesn't really go through the same criteria as a graduation, there's still a few things I'd like to clarify about your KEP:

  • Can you set the latest-milestone key in your kep.yaml to be "v1.22".
  • Also in the kep.yaml file, should the state still be implementable?
  • Can you update the rollout plan in your KEP to match this issue? (i.e., specify which is coming in 1.22 and which in 1.24)

@pacoxu
Copy link
Member

pacoxu commented May 11, 2021

@JamesLaverack I opened #2707.

@pacoxu
Copy link
Member

pacoxu commented May 11, 2021

/assign

@JamesLaverack
Copy link
Member

JamesLaverack commented May 12, 2021

Also I see that SIG API Machinery is listed as a participating SIG in your KEP. Will they need to do anything towards this deprecation in 1.22, and if so are they aware of that?

@JamesLaverack JamesLaverack added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 12, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 13, 2021

With #2707 merged we're good for 1.22 enhancements freeze.

@tallclair
Copy link
Member Author

tallclair commented May 20, 2021

We need to update https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features with the state of StreamingProxyRedirects and ValidateProxyRedirects.

EDIT: kubernetes/website#28065

@pacoxu
Copy link
Member

pacoxu commented Jun 7, 2021

All items for 1.22 are done.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 18, 2021
@salaxander
Copy link

salaxander commented Aug 18, 2021

@tallclair @pacoxu - would you be able to do a PR on the KEP.yaml to change the state to implemented? At that point we should be able to close the issue.

Thanks!

@pacoxu
Copy link
Member

pacoxu commented Aug 19, 2021

@salaxander updated the status in #2878.

@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 6, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2021
@pacoxu pacoxu removed their assignment Dec 6, 2021
@pacoxu
Copy link
Member

pacoxu commented Mar 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.