Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go signature refactor to standardize options and context handling #1601

Closed
mikedanese opened this issue Mar 6, 2020 · 13 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@mikedanese
Copy link
Member

mikedanese commented Mar 6, 2020

Enhancement Description

@mikedanese mikedanese added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 6, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 6, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
@jeremyrickard jeremyrickard added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 6, 2020
@VineethReddy02
Copy link

VineethReddy02 commented Mar 9, 2020

Hi, @mikedanese Does this enhancement need any user-facing docs? If so can you please raise a placeholder PR against a dev-1.18 branch for k8s/website repo. We have already completed the docs placeholder PR deadline and today is the deadline for docs to be ready for review state.

Thanks!

@mikedanese
Copy link
Member Author

mikedanese commented Mar 9, 2020

No it does not.

@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

Hi @mikedanese, since the enhancement graduated to Stable in 1.18, can you please mark the KEP as implemented?

/reopen
(reopening the enhancement issue until the KEP is marked implemented)

@palnabarun palnabarun reopened this Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 16, 2020

@palnabarun: Reopened this issue.

In response to this:

Hi @mikedanese, since the enhancement graduated to Stable in 1.18, can you please mark the KEP as implemented?

/reopen
(reopening the enhancement issue until the KEP is marked implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 17, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Apr 29, 2020
@fejta-bot
Copy link

fejta-bot commented Jul 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2020
@palnabarun
Copy link
Member

palnabarun commented Jul 30, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 1, 2020

Hi @mikedanese

Ping on this. Can we get this marked as stable?

@fejta-bot
Copy link

fejta-bot commented Dec 30, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2020
@fejta-bot
Copy link

fejta-bot commented Jan 29, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2021
@fejta-bot
Copy link

fejta-bot commented Feb 28, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 28, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

7 participants