Container Resource based Pod Autoscaling

[arjunrn]

Enhancement Description

• One-line enhancement description (can be used as a release note): Container Resource based Pod Autoscaling
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-autoscaling/1610-container-resource-autoscaling/README.md
• Primary contact (assignee):
• Responsible SIGs: autoscaling
• Enhancement target (which target equals to which milestone):
  • Alpha release target 1.19
  • Beta release target 1.27
  • Stable release target 1.30
• Implementation: Add container based scaling to HPA kubernetes#90691 The graduation HPA container resource metrics to beta kubernetes#115467 graduate HPAContainerMetrics to stable kubernetes#123482
• Docs: Added docs about container resource metric source for HPA website#23523 graduate HPAContainerMetrics to stable website#45204
• KEP PR for beta: KEP-1610: update KEP to graduate the container resource metric to beta #3834
• KEP PR for main: KEP-1610: graduate ContainerResource to stable #4406
• k/k issue to track what we need for beta: The graduation HPA container resource metrics to beta kubernetes#115467

[arjunrn]

/sig autoscaling

[harshanarayana]

Hey there @arjunrn -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[harshanarayana]

Hey @arjunrn, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[harshanarayana]

Hey @arjunrn, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[harshanarayana]

Hey @arjunrn, any plans for the Enhancements to be included in v1.19? Please let me know so that I can update the tracking sheet to show the inclusion state.

Enhancements freeze is on May 19

Note that recently the KEP format has changed. Additionally, #1620 merged recently, adding production readiness review questions to the KEP template.
Please take this opportunity to reformat your KEP and also answer the questions added to the template in that PR.

Thanks,
🖖

[harshanarayana]

Hey @arjunrn, Unfortunately the deadline for the 1.19 Enhancement freeze has passed and the KEP is still in provisional state. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[harshanarayana]

Marking to a deferred milestone after discussing with @arjunrn

/milestone v1.20

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[arjunrn]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @arjunrn

Enhancements Lead here. Are you still planning on bringing this to alpha in 1.20?

Thanks
Kirsten

[arjunrn]

@kikisdeliveryservice Yes, I'm still working on it and hope to have the feature merged in time for 1.20

[kikisdeliveryservice]

Great thanks for the update!

[kinarashah]

Hi @arjunrn,

1.20 Enhancement shadow here 👋.

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

[arjunrn]

@kinarashah Updated the description with the implementation and docs PR links.

[kinarashah]

That's awesome, thank you for getting them up so quickly!

[eagleusb]

Hello @arjunrn 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[kikisdeliveryservice]

Hey @arjunrn

Just to confirm : This is now finished for 1.20 correct?

Just a reminder that Code Freeze is coming up tomorrow Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

[arjunrn]

@kikisdeliveryservice yes both the implementation and the docs have been merged.

[sanposhiho]

@gjtempleton Can you add /milestone v1.30 and /lead-opted-in?

[gjtempleton]

/milestone v1.30
/label lead-opted-in

[k8s-ci-robot]

@gjtempleton: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[salehsedghpour]

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Update the README.md file with the latest template. There is a new question in Scalability part in `Production Readiness Review Questionnaire that needs to be answered.
• Make sure the milestone is updated to v1.30 using /milestone v1.30 command.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sanposhiho]

@mwielgus Can you give it /milestone v1.30? Apparently, @gjtempleton doesn't have the permission and you only do?

[gjtempleton]

/milestone v1.30

[logicalhan]

Where is the KEP update PR?

[johnbelamaric]

Where is the KEP update PR?

#4406

[salehsedghpour]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[a-mccarthy]

Hi @sanposhiho,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

[drewhagen]

Hello @sanposhiho 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[sanposhiho]

@a-mccarthy We don't need a blog post for this feature since we've got the one in the past release. Thanks.

@drewhagen Sure, here it is kubernetes/website#45204

[salehsedghpour]

Hey again @sanposhiho 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[gjtempleton]

I've updated the issue description with links to the related PRs, we're currently only waiting on kubernetes/kubernetes#123482 being approved.

[strrzj]

I've updated the issue description with links to the related PRs, we're currently only waiting on kubernetes/kubernetes#123482 being approved.

[salehsedghpour]

Hello @sanposhiho 👋 , Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

• graduate HPAContainerMetrics to stable kubernetes#123482

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

[sanposhiho]

@praparn I meant it's better to file as an issue in kubernetes/kubernetes.
https://github.com/kubernetes/kubernetes/issues/new?assignees=&labels=kind%2Fbug&projects=&template=bug-report.yaml

[praparn]

@praparn I meant it's better to file as an issue in kubernetes/kubernetes. https://github.com/kubernetes/kubernetes/issues/new?assignees=&labels=kind%2Fbug&projects=&template=bug-report.yaml

Note with thanks. Will open new issue and delete this.

[sanposhiho]

Actually, I believe we can close this issue since we reach stable. Feel free to reopen if anything additionally to be done.

🎉

/close

[k8s-ci-robot]

@sanposhiho: Closing this issue.

In response to this:

Actually, I believe we can close this issue since we reach stable. Feel free to reopen if anything additionally to be done.

🎉

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.