Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Resource based Pod Autoscaling #1610

Open
arjunrn opened this issue Mar 11, 2020 · 68 comments
Open

Container Resource based Pod Autoscaling #1610

arjunrn opened this issue Mar 11, 2020 · 68 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@arjunrn
Copy link
Contributor

arjunrn commented Mar 11, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 11, 2020
@arjunrn
Copy link
Contributor Author

arjunrn commented Mar 11, 2020

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2020
@harshanarayana
Copy link

Hey there @arjunrn -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@harshanarayana
Copy link

Hey @arjunrn, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

1 similar comment
@harshanarayana
Copy link

Hey @arjunrn, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

@harshanarayana
Copy link

Hey @arjunrn, any plans for the Enhancements to be included in v1.19? Please let me know so that I can update the tracking sheet to show the inclusion state.

Enhancements freeze is on May 19

Note that recently the KEP format has changed. Additionally, #1620 merged recently, adding production readiness review questions to the KEP template.
Please take this opportunity to reformat your KEP and also answer the questions added to the template in that PR.

Thanks,
🖖

@harshanarayana
Copy link

Hey @arjunrn, Unfortunately the deadline for the 1.19 Enhancement freeze has passed and the KEP is still in provisional state. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@harshanarayana harshanarayana added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020
@harshanarayana
Copy link

Marking to a deferred milestone after discussing with @arjunrn

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone May 20, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@arjunrn
Copy link
Contributor Author

arjunrn commented Aug 18, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@kikisdeliveryservice
Copy link
Member

Hi @arjunrn

Enhancements Lead here. Are you still planning on bringing this to alpha in 1.20?

Thanks
Kirsten

@arjunrn
Copy link
Contributor Author

arjunrn commented Sep 13, 2020

@kikisdeliveryservice Yes, I'm still working on it and hope to have the feature merged in time for 1.20

@kikisdeliveryservice
Copy link
Member

Great thanks for the update!

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 13, 2020
@kinarashah
Copy link

Hi @arjunrn,

1.20 Enhancement shadow here 👋.

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

@arjunrn
Copy link
Contributor Author

arjunrn commented Oct 12, 2020

@kinarashah Updated the description with the implementation and docs PR links.

@kinarashah
Copy link

That's awesome, thank you for getting them up so quickly!

@eagleusb
Copy link

Hello @arjunrn 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Hey @arjunrn

Just to confirm : This is now finished for 1.20 correct?

Just a reminder that Code Freeze is coming up tomorrow Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

@arjunrn
Copy link
Contributor Author

arjunrn commented Nov 11, 2020

@kikisdeliveryservice yes both the implementation and the docs have been merged.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@k8s-ci-robot k8s-ci-robot removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
@sanposhiho
Copy link
Member

sanposhiho commented Mar 15, 2023

See: kubernetes/kubernetes#116326 (comment)

All of the required PRs have already been /lgtm /approveed. All required jobs are ✅ , so they should be mergeable state.
The code freeze doesn't mean that all PRs should be merged by then but means all PRs should be in the mergeable state by then.

@marosset Please get this enhancement back to v1.27.
(Or do I miss something?)

@marosset
Copy link
Contributor

/milestone v1.27
/label tracked/yes
/remove-label tracked/no

I'm adding this back into v1.27 per the following slack discussion in slack at https://kubernetes.slack.com/archives/CJH2GBF7Y/p1678843008739849

Thanks @sanposhiho!

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@sanposhiho
Copy link
Member

@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@sanposhiho
Copy link
Member

@gjtempleton Can we make it GA in v1.30?
We haven't seen any bug reports for this during the two releases and I think it meets the GA criteria.
https://github.com/kubernetes/enhancements/tree/master/keps/sig-autoscaling/1610-container-resource-autoscaling#ga

@gjtempleton
Copy link
Member

Sorry for the slow response @sanposhiho!

Aiming for GA in 1.30 seems like a good target to me.

@sanposhiho
Copy link
Member

@gjtempleton Can you add /milestone v1.30 and /lead-opted-in?

@gjtempleton
Copy link
Member

/milestone v1.30
/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@gjtempleton: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 4, 2024
@salehsedghpour
Copy link
Contributor

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the README.md file with the latest template. There is a new question in Scalability part in `Production Readiness Review Questionnaire that needs to be answered.
  • Make sure the milestone is updated to v1.30 using /milestone v1.30 command.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sanposhiho
Copy link
Member

@mwielgus Can you give it /milestone v1.30? Apparently, @gjtempleton doesn't have the permission and you only do?

@gjtempleton
Copy link
Member

/milestone v1.30

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.30 Feb 6, 2024
@logicalhan
Copy link
Member

Where is the KEP update PR?

@johnbelamaric
Copy link
Member

Where is the KEP update PR?

#4406

@salehsedghpour
Copy link
Contributor

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@a-mccarthy
Copy link

Hi @sanposhiho,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@drewhagen
Copy link
Member

Hello @sanposhiho 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@sanposhiho
Copy link
Member

@a-mccarthy We don't need a blog post for this feature since we've got the one in the past release. Thanks.

@drewhagen Sure, here it is kubernetes/website#45204

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 22, 2024

Hey again @sanposhiho 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: At Risk for Code Freeze
Development

No branches or pull requests