Container Resource based Pod Autoscaling

[arjunrn]

Enhancement Description

• One-line enhancement description (can be used as a release note): Container Resource based Pod Autoscaling
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-autoscaling/1610-container-resource-autoscaling/README.md
• Primary contact (assignee):
• Responsible SIGs: autoscaling
• Enhancement target (which target equals to which milestone):
  • Alpha release target 1.19
  • Beta release target Currently unknown
  • Stable release target Currently unknown
• Implementation: Add container based scaling to HPA kubernetes#90691 The graduation HPA container resource metrics to beta kubernetes#115467
• Docs: Added docs about container resource metric source for HPA website#23523
• KEP PR for beta: KEP-1610: update KEP to graduate the container resource metric to beta #3834
• k/k issue to track what we need for beta: The graduation HPA container resource metrics to beta kubernetes#115467

[arjunrn]

/sig autoscaling

[harshanarayana]

Hey there @arjunrn -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[harshanarayana]

Hey @arjunrn, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[harshanarayana]

Hey @arjunrn, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

[harshanarayana]

Hey @arjunrn, any plans for the Enhancements to be included in v1.19? Please let me know so that I can update the tracking sheet to show the inclusion state.

Enhancements freeze is on May 19

Note that recently the KEP format has changed. Additionally, #1620 merged recently, adding production readiness review questions to the KEP template.
Please take this opportunity to reformat your KEP and also answer the questions added to the template in that PR.

Thanks,
🖖

[harshanarayana]

Hey @arjunrn, Unfortunately the deadline for the 1.19 Enhancement freeze has passed and the KEP is still in provisional state. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

[harshanarayana]

Marking to a deferred milestone after discussing with @arjunrn

/milestone v1.20

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[arjunrn]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @arjunrn

Enhancements Lead here. Are you still planning on bringing this to alpha in 1.20?

Thanks
Kirsten

[arjunrn]

@kikisdeliveryservice Yes, I'm still working on it and hope to have the feature merged in time for 1.20

[kikisdeliveryservice]

Great thanks for the update!

[kinarashah]

Hi @arjunrn,

1.20 Enhancement shadow here 👋.

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

[arjunrn]

@kinarashah Updated the description with the implementation and docs PR links.

[kinarashah]

That's awesome, thank you for getting them up so quickly!

[eagleusb]

Hello @arjunrn 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[kikisdeliveryservice]

Hey @arjunrn

Just to confirm : This is now finished for 1.20 correct?

Just a reminder that Code Freeze is coming up tomorrow Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

[arjunrn]

@kikisdeliveryservice yes both the implementation and the docs have been merged.

[taniaduggal]

Hi @arjunrn 👋 , I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

[sanposhiho]

@taniaduggal added the placeholder PR 🙏
kubernetes/website#39929

[fsmunoz]

Hi @annajung 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

• Add container based scaling to HPA kubernetes#90691

For this enhancement, it looks like all linked PRs are merged; this is based on the assumption that the "Implementation" PR in the description is the one that is equivalente to "Beta -> Code" . Updating the description to make this explicit would make this clearer.

If the above assumption isn't correct, it could be that there are missing PRs linked above and/or they are not merged: this would change the status of this enhancement in terms of code freeze preparedness, and actions would need to be taken before the deadline.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[gjtempleton]

Hey @fsmunoz , the required PRs for this to get to beta are listed in this catchall issue: kubernetes/kubernetes#115467 and haven't yet been merged.

@arjunrn, are you able to update the implementation in the issue description to link to that issue?

[arjunrn]

@gjtempleton The PR for the graduation to beta is already listed in the issue. It's the last link. I've also added it to the implementation line.

[fsmunoz]

I've updated the status above based on the provided information, thanks!

[marosset]

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

[sanposhiho]

See: kubernetes/kubernetes#116326 (comment)

All of the required PRs have already been /lgtm /approveed. All required jobs are ✅ , so they should be mergeable state.
The code freeze doesn't mean that all PRs should be merged by then but means all PRs should be in the mergeable state by then.

@marosset Please get this enhancement back to v1.27.
(Or do I miss something?)

[marosset]

/milestone v1.27
/label tracked/yes
/remove-label tracked/no

I'm adding this back into v1.27 per the following slack discussion in slack at https://kubernetes.slack.com/archives/CJH2GBF7Y/p1678843008739849

Thanks @sanposhiho!

[sanposhiho]

For documentation updates in v1.27:

• (doc) fix: HPA container resource metrics beta graduation website#39929
• (blog) Add the blog post for the beta graduation of HPA ContainerResource type metric website#39822