Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkPolicies: Introduce a comprehensive CNI validation framework to replace existing network_policy.go validations #1611

Closed
jayunit100 opened this issue Mar 11, 2020 · 37 comments
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@jayunit100
Copy link
Member

jayunit100 commented Mar 11, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Introduce a CNI validation framework as a replacement for the network_policy.go E2E suite, and use it to curate easy to understand, high performance, comprehensive NetworkPolicy validations for CNI providers.

@jayunit100

  • Responsible SIGs:

@kubernetes/sig-network-misc

  • Enhancement target (which target equals to which milestone):
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 11, 2020
@jayunit100 jayunit100 changed the title NetworkPolicies: Reject invalid Egress rules NetworkPolicies: Introduce a CNI validation framework Mar 11, 2020
@jayunit100 jayunit100 changed the title NetworkPolicies: Introduce a CNI validation framework NetworkPolicies: Introduce a comprehensive CNI validation framework to replace existing network_policy.go validations Mar 11, 2020
@jayunit100
Copy link
Member Author

jayunit100 commented Mar 11, 2020

I think i mislabelled the issue, not an api-change. Updated to sig-network-misc.

@harshanarayana
Copy link

harshanarayana commented May 1, 2020

Hey there @jayunit100 -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@harshanarayana
Copy link

harshanarayana commented May 2, 2020

Hey @jayunit100, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

@jayunit100
Copy link
Member Author

jayunit100 commented May 8, 2020

Hi ! Yes wouldlike to have this in 1.19. Thanks @harshanarayana

@harshanarayana
Copy link

harshanarayana commented May 9, 2020

Hey @jayunit100 Thanks very much for confirming the status. I've updated the tracker accordingly and marking this with proper milestones.

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 9, 2020
@harshanarayana harshanarayana added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 9, 2020
@harshanarayana
Copy link

harshanarayana commented May 12, 2020

Hey @jayunit100 I was wondering if you can help me with a clarification regarding the graduation criteria with regards to the KEP?

Since the KEP is missing information specific to the k8s versions and this is a test architecting redesign, will the entire specification of the KEP be implemented in v1.19 or part of will be carried over to the coming releases? This will help me mark the stage for the Enhancement accordingly in the tracker.

Regards, Harsha

@harshanarayana
Copy link

harshanarayana commented May 14, 2020

/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label May 14, 2020
@jayunit100
Copy link
Member Author

jayunit100 commented May 15, 2020

thanks harsha, yup, per our conv yesterday, we'll be able to get this to 1.19, and the current WIP implementation is here https://github.com/vmware-tanzu/antrea/blob/master/hack/netpol/pkg/main/main.go

@liggitt liggitt removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 21, 2020
@zestrells
Copy link

zestrells commented May 25, 2020

Hi @jayunit100 - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@harshanarayana
Copy link

harshanarayana commented May 27, 2020

Hey @jayunit100, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that you have already opened for this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

@wojtek-t
Copy link
Member

wojtek-t commented May 27, 2020

@jayunit100 - can you please

  1. transform the KEP to the new format (should be simple, just extracting metadata to kep.yaml: see template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template )
  2. fill in PRR questionaire and assign me as PRR approver (I'm taking all network PRRs this cycle)

@zestrells
Copy link

zestrells commented Jun 8, 2020

Hi @jayunit100 - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

@harshanarayana
Copy link

harshanarayana commented Jun 12, 2020

Hey @jayunit100, Hope things are good.

The code freeze deadline for the Enhancement is Thursday, June 25. So, I am following up on my previous updates about the k/k that needs to be tracked. Can you please point me in the direction of any PR against that which needs to be tracked for this enhancement?

Have a wonderful day. 🖖

@harshanarayana
Copy link

harshanarayana commented Jun 16, 2020

Hi, @jayunit100

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

@jayunit100
Copy link
Member Author

jayunit100 commented Jun 17, 2020

hi folks, i somehow missed this. reading up now.

@jayunit100
Copy link
Member Author

jayunit100 commented Jun 17, 2020

So, the PR is here , it has not been rebased yet https://github.com/kubernetes/kubernetes/pull/91592/files . Im going to sync with a few folks today to see if we will be able to get it in as planned. will sync with jerickar tomorrow as well to confirm all this.

The basic functionality is all set, but want to confirm we can make the timeeline.

@jayunit100
Copy link
Member Author

jayunit100 commented Jun 17, 2020

@wojtek-t , so, with the kep-nnnn thing, are you saying i should file a PR to fix the original kep to match the new format?

@savitharaghunathan
Copy link
Member

savitharaghunathan commented Jun 19, 2020

Hi @jayunit100, 1.19 Docs lead here. Today June 19 is the deadline for docs placeholder PR. Can you provide an update on docs status, please? Thanks!

@jayunit100
Copy link
Member Author

jayunit100 commented Jun 22, 2020

Hi ! It wont need a docs placeholder, from conversation i just hadd with @mrbobbytables ... but i think we will slip this to 1.20 anyways.

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 30, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

As per: #1568 (review)

Marking this a fully tracked since it's straight to GA, implementable and the KEP is literally about tests.

@jayunit100
Copy link
Member Author

jayunit100 commented Oct 1, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 11, 2020

Hi @jayunit100

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PRs (which you've been doing, thank you!) as well as docs PRs to this issue so we can track them.

Thanks!
Kirsten

@kcmartin
Copy link

kcmartin commented Oct 22, 2020

Hello @jayunit100 , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

It looked as if it did not require docs, based on the comments above, but if I'm mistaken, please follow the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 10, 2020

Hey @jayunit100

I see that kubernetes/kubernetes#91592 is still open but looks like it's almost finished. Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks,
Kirsten

@jayunit100
Copy link
Member Author

jayunit100 commented Nov 10, 2020

yeah, it appears that its done, and we just need to get the final lgtm on it.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Hi @jayunit100

I see that your PR has no approvals yet, do you still plan on getting this in today?

Thanks
Kirsten

@jayunit100
Copy link
Member Author

jayunit100 commented Nov 12, 2020

ahhhh, probably not... cc unless @bowei has a block of time to look at it :)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

Hi @jayunit100

Code Freeze is now in effect and your PR does not have sufficient approvals and has not yet merged. If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Nov 13, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 13, 2020
@fejta-bot
Copy link

fejta-bot commented Feb 11, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2021
@fejta-bot
Copy link

fejta-bot commented Mar 13, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 13, 2021
@jayunit100
Copy link
Member Author

jayunit100 commented Mar 14, 2021

Ths has been completed thanks!
Guess I need to make sure next release
We mark the enhancement correctly

@fejta-bot
Copy link

fejta-bot commented Apr 13, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 13, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thockin thockin removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 9, 2022
@thockin thockin added this to New, not evaluated in SIG-Network KEPs via automation Sep 9, 2022
@thockin thockin moved this from New, not evaluated to Alpha gated (code is merged) in SIG-Network KEPs Sep 9, 2022
@thockin thockin moved this from Alpha gated (code is merged) to No gates in SIG-Network KEPs Sep 9, 2022
@thockin thockin moved this from No gates to GA (merged, gate removed) in SIG-Network KEPs Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
SIG-Network KEPs
GA (merged, gate removed)
Development

No branches or pull requests