-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Transition from Beta #1635
Comments
/assign @deads2k I am updating the enhancements team tracking sheet. David, just to confirm you still plan on getting this in for 1.19? |
/sig api-machinery |
If this |
Hi @deads2k - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :) |
Oh, by the way, I started drafting a blog post about this. |
Hi @deads2k - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks! |
(I'd expect to see a PR updating https://kubernetes.io/docs/reference/using-api/deprecation-policy/ and possibly also https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-versioning) |
This is a policy about how long something can be in the system before being deprecated. It actually doesn't change anything about the deprecation policy described in that document. I don't think this needs user-facing documentation. It's more of a policy for the development process. That is, everything in the versioning and deprecation policy documents stay the same. What changes is how the decision is made as to when to deprecate an API that is languishing. Previously, it was arbitrary; now, there is a policy. When it actually is deprecated, those documents kick in, just as they are today. Functionally, I believe @deads2k is adding some metadata to the APIs to provide a "deprecated as of release X" indicator. This would then be used by #1693 which absolutely needs docs. |
Hi @deads2k To follow-up on the email sent to k-dev on Monday, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19 Best,
|
I don't see a need for user facing documentation about the requirement either.
|
Hi @deads2k 👋, I see that kubernetes/kubernetes#90983 was filed in relation to this enhancement. However, there has been no progress on that PR since some time. Do you think that the PR will be merged by the Code Freeze on Thursday, July 9th? Thank you. 🙂 Code Freeze begins on Thursday, July 9th EOD PST |
kubernetes/kubernetes#90983. This particular PR can be delayed until 1.20 because there are no versions to stop serving in 1.19. The rest of the required pieces have landed and the deprecation clocks have all been set. This in combination with the warning KEP will clearly notify users of the risk. |
@deads2k I opened a WIP pull request to announce the new policy in a blog post: kubernetes/website#21274 It sounds like this KEP is looking likely to move forward. If that is right let me know and I'll put more work into the announcement / look for people to collaborate on details. Update: I revised it. |
Hi @deads2k Enhancements Lead here. Is there any further work intended for this in 1.20? I am unclear as to whether this is stable yet or not. Could you please clarify the state? Thanks! |
Will this be done in 1.20? Enhancements Freeze is October 6th, so please let me know. Given the context, this doesn't seem like it needs test plans or graduation criteria, correct? We'd just need to track this and have some sort of docs /comms update? Thanks, |
Would be good to see docs updates around the deprecation policy - see #1635 (comment) |
Maybe on https://kubernetes.dev/ now that's a thing? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This was implemented back in 1.19 and has not changed since. The automatic removal made it slightly easier to enforce, the policy is the same. I've updated the KEP to show the individual steps to mechnically make the transition in #2293 . Closing since this is done. /close |
@deads2k: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
opened kubernetes/website#36663 |
LOG-5613: Refactor logging API to make GCP account an enum
Require Transition from Beta
// +k8s:prerelease-lifecycle-gen:introduced=1.8
. The deprecation (three releases later) and the removal (three releases after that) are automatically created in generated code to reduce toil.The text was updated successfully, but these errors were encountered: