Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taint Based Eviction #166

Open
davidopp opened this issue Jan 20, 2017 · 108 comments
Open

Taint Based Eviction #166

davidopp opened this issue Jan 20, 2017 · 108 comments

Comments

@davidopp
Copy link
Member

@davidopp davidopp commented Jan 20, 2017

Feature Description

@davidopp davidopp added this to the v1.6 milestone Jan 20, 2017
@davidopp davidopp mentioned this issue Jan 30, 2017
0 of 22 tasks complete
@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented Feb 28, 2017

This is finished except for documentation.

NoExecute taint effect is now in Beta (as part of moving taints/tolerations to Beta), and taint-based eviction for node problems is in Alpha.

The PRs involved were:

@idvoretskyi

This comment has been minimized.

Copy link
Member

@idvoretskyi idvoretskyi commented Mar 6, 2017

@davidopp @gmarek @kevin-wangzefeng please, provide us with the release notes and documentation PR (or links) at the features spreadsheet.

@davidopp davidopp added stage/alpha and removed stage/beta labels Mar 11, 2017
@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented Mar 11, 2017

@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented Mar 30, 2017

@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented Apr 26, 2017

Regarding "taint-based eviction for node problems is in Alpha": nobody is available to move it to beta in 1.7, so it will stay in alpha in 1.7.

@gyliu513

This comment has been minimized.

Copy link
Member

@gyliu513 gyliu513 commented Apr 27, 2017

@davidopp I can help on this and target for 1.7, one question is that I saw kubernetes/kubernetes#40355 is already enabled by default, so can you please explain more for what do you mean by move this to beta in 1.7?

@gmarek

This comment has been minimized.

Copy link
Member

@gmarek gmarek commented Apr 27, 2017

@gyliu513 - taint controller is enabled by default, but using taints instead of direct evictions in case of node problems isn't. To move it to beta there's at least one thing to be done (except renaming stuff from alpha to bete), which is to rewrite/write new NodeController unit tests, as they currently assume direct evictions. There are some very basic tests for taint-based evictions, but they should be drastically extended (e.g. cover all master-disruption logic).

@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented Apr 27, 2017

I think we can only do this in 1.7 if @gmarek has the bandwidth to do all the reviews and define what we need to do to move it to beta. (Sounds like he's already done most of the second thing above.)

@gmarek do you have time?

@gmarek

This comment has been minimized.

Copy link
Member

@gmarek gmarek commented Apr 27, 2017

Yes, I can find time for reviews and I can find time to think through what needs to be done, if there's someone willing to work on it.

@gyliu513

This comment has been minimized.

Copy link
Member

@gyliu513 gyliu513 commented Apr 27, 2017

@davidopp @gmarek I will be the volunteer for this, can you please assign this to me? @gmarek will go through this feature and propose sth to you

@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented Apr 28, 2017

assigned

@gmarek

This comment has been minimized.

Copy link
Member

@gmarek gmarek commented Apr 28, 2017

@gyliu513 OK - let me know if you need some directions.

@davidopp davidopp modified the milestones: v1.7, v1.6 Apr 29, 2017
@idvoretskyi

This comment has been minimized.

Copy link
Member

@idvoretskyi idvoretskyi commented May 3, 2017

@davidopp @gmarek I've updated the feature description to fit the new template. Please, fill the empty fields in the new template (their actual state was unclear).

@idvoretskyi idvoretskyi moved this from Done to Action required in Kubernetes 1.7 features May 3, 2017
@davidopp

This comment has been minimized.

Copy link
Member Author

@davidopp davidopp commented May 5, 2017

Move to Beta is goal for 1.7.

@gyliu513

This comment has been minimized.

Copy link
Member

@gyliu513 gyliu513 commented May 5, 2017

@gmarek I want to split the work to two tasks:

  1. Rename from alpha to beta.
  2. Update unit test for node controller to cover more cases.

Comments?

@damemi damemi mentioned this issue Jan 13, 2020
4 of 4 tasks complete
@Huang-Wei

This comment has been minimized.

Copy link
Member

@Huang-Wei Huang-Wei commented Jan 13, 2020

I see that this enhancement predates the KEP process. Just a nit here, in order to be able to track this enhancement, we need a merged KEP, in an implementable state and with test plans and graduation criteria.

/cc @damemi ^^ Could you please update the KEP as well? Thanks.

@palnabarun

This comment has been minimized.

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Jan 21, 2020

@palnabarun yes, and this is the parent issue for the tasks that need to be done: kubernetes/kubernetes#87161

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Jan 21, 2020

@damemi Awesome! I see that the KEP now satisfies all criteria for the Enhancements Freeze.

Thank you for all the efforts. :)

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Jan 21, 2020

I went ahead and updated the issue comment with the link to the KEP.

@skilxn-go

This comment has been minimized.

Copy link
Contributor

@skilxn-go skilxn-go commented Jan 27, 2020

@damemi Hi, is the progress of moving #1450 from scheduling to node still move on? Will it be done before v1.18 KEP freeze?

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Jan 27, 2020

@skilxn-go I opened a PR to move the KEP here: #1510

@skilxn-go

This comment has been minimized.

Copy link
Contributor

@skilxn-go skilxn-go commented Jan 27, 2020

Thanks, got it

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Feb 5, 2020

Hi @damemi, just a friendly reminder that the Code Freeze will go into effect on Thursday 5th March.

Can you please link all the k/k PRs or any other PRs which should be tracked for this enhancement?

Thank You :)

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Feb 5, 2020

Hi @palnabarun, we have an umbrella issue which links to the issues/PRs that are in the works for this: kubernetes/kubernetes#87161

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Feb 5, 2020

Thank you @damemi for updating this. :)

@sethmccombs

This comment has been minimized.

Copy link

@sethmccombs sethmccombs commented Feb 6, 2020

Hey @damemi -

Seth here, Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

@ingvagabund

This comment has been minimized.

Copy link
Contributor

@ingvagabund ingvagabund commented Feb 26, 2020

@sethmccombs IIUC, given I have the doc PR opened against dev-1.18 branch (kubernetes/website#19302), there's no need to update any sheet, right?

@sethmccombs

This comment has been minimized.

Copy link

@sethmccombs sethmccombs commented Feb 26, 2020

@ingvagabund you got it, I'll update the Enhancement tracking sheet!

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Mar 3, 2020

Hi @damemi, this a reminder that we are just two days away from Code Freeze on 5th March.

By the Code Freeze, all the relevant PR's should be merged else you would need to file an exception request.

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Mar 3, 2020

@palnabarun I've updated the 3 PRs that this is waiting on to see if they will merge by code freeze.

  1. kubernetes/kubernetes#88152
  2. kubernetes/kubernetes#87487
  3. kubernetes/website#19302
@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Mar 3, 2020

@palnabarun actually before those 3 can merge, we need to get the KEP move approved: #1510

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Mar 5, 2020

@damemi I see that the PR's are blocked on approvals at the moment. Do you think they would make it before the deadline?

Today EOD is the Code Freeze

Please file an exception if you think the PR's might slip the deadline.

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Mar 5, 2020

I think we will need more time to get the approvals, what's the process to file an exception?

@jeremyrickard

This comment has been minimized.

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Mar 5, 2020

@jeremyrickard thanks, exception filed

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Mar 6, 2020

@damemi The exception request was approved. :)

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Mar 23, 2020

Hi @damemi, since this enhancement graduated to Stable this release 🚀, the status can now be set to be Implemented.

Can you please update the status? After that, we will close this issue.

@damemi

This comment has been minimized.

Copy link
Contributor

@damemi damemi commented Mar 23, 2020

@palnabarun sure, opened that here: #1625

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Mar 23, 2020

Thank you @damemi :)

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
enhancements: support real-time kernels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.