Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up recursive SELinux label change #1710

Open
jsafrane opened this issue Apr 23, 2020 · 53 comments
Open

Speed up recursive SELinux label change #1710

jsafrane opened this issue Apr 23, 2020 · 53 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@jsafrane
Copy link
Member

jsafrane commented Apr 23, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): Speed up container startup by mounting volumes with the correct SELInux label instead of changing each file on the volumes recursively.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling

  • Primary contact (assignee): @jsafrane

  • Responsible SIGs: sig-storage, sig-node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.19
    • Beta release target (x.y)
    • Stable release target (x.y)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 23, 2020
@jsafrane
Copy link
Member Author

jsafrane commented Apr 28, 2020

/sig storage
/sig node

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 28, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

Hey @jsafrane -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@palnabarun
Copy link
Member

palnabarun commented May 18, 2020

Hi @jsafrane,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

@jsafrane -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@palnabarun palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020
@jsafrane
Copy link
Member Author

jsafrane commented May 20, 2020

@palnabarun hey, we've just merged the KEP yesterday, at the last moment. I admit I did not pay attention to this enhancement issue and focused on the design. Do I really need an exception just to restore the milestone?

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

Do I really need an exception just to restore the milestone?

Yes, an exception would be needed. Here is the process on how to file and exception request.

@palnabarun
Copy link
Member

palnabarun commented May 22, 2020

@jsafrane -- Your exception request was approved. I have updated the tracking sheet accordingly.

@palnabarun
Copy link
Member

palnabarun commented May 22, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 22, 2020
@palnabarun palnabarun added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 22, 2020
@palnabarun
Copy link
Member

palnabarun commented May 22, 2020

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 22, 2020
@zestrells
Copy link

zestrells commented May 25, 2020

Hi @jsafrane - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@jsafrane
Copy link
Member Author

jsafrane commented May 26, 2020

@zestrells, yes, documentation will be needed. I can't edit the tracking sheet, can you please note it there?

@harshanarayana
Copy link

harshanarayana commented May 27, 2020

Hey @jsafrane, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that you have already opened for this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

@zestrells
Copy link

zestrells commented Jun 8, 2020

Hi @jsafrane - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

@harshanarayana
Copy link

harshanarayana commented Jun 9, 2020

Hey @jsafrane, This is just a reminder that the code freeze for the enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that is already open against this enhancement that needs to be tracked.

Have a wonderful day. 🖖

@jsafrane
Copy link
Member Author

jsafrane commented Jun 15, 2020

API PR: kubernetes/kubernetes#91838
WIP Docs: kubernetes/website#21773

@harshanarayana
Copy link

harshanarayana commented Jun 16, 2020

Hi, @jsafrane

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

@harshanarayana
Copy link

harshanarayana commented Jul 8, 2020

Hi @jsafrane ,

This is just a follow up to my earlier messages on the upcoming deadlines. The code freeze deadline is Thursday, July 9th EOD PST and I noticed that the k/k PRs are still in flight.

For the enhancement to be included into v1.19 this PR needs to be merged before the code freeze deadline.

Please refer to the Exception Process documentation in case if there is a need for one.

@harshanarayana
Copy link

harshanarayana commented Jul 9, 2020

/milestone clear
/milestone v1.20

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone Jul 9, 2020
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 30, 2022

Hello @jsafrane 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands: (updated on June 9, 2022)

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jsafrane
Copy link
Member Author

jsafrane commented Jun 9, 2022

@Priyankasaggu11929 I updated the KEP with a new template and updated the test plan. Let me know if there is anything missing.
(Do you have a script that checks / generates the checklist above? Can I run it by myself?)

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 9, 2022

Thanks for the update @jsafrane 🙂

Do you have a script that checks / generates the checklist above? Can I run it by myself?

No yet, the team do a manual check through the KEPs :)

With the KEP PR #3348 merged now, this enhancements is all good for the upcoming enhancements freeze 🚀

For note, the status of the enhancement is now marked as tracked.

@krol3
Copy link

krol3 commented Jul 6, 2022

Hello @jsafrane 👋, 1.25 Release Docs shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

@rhockenbury
Copy link

rhockenbury commented Jul 21, 2022

👋 Hey @jsafrane,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze:
[ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
[ ] All PRs are fully merged by the code freeze deadline.

Looks like there is one PR in k/k for alpha for this enhancement. Let me know if I missed any other PRs that need to be tracked.

As always, we are here to help should questions come up. Thanks!!

@rhockenbury
Copy link

rhockenbury commented Jul 27, 2022

Gentle reminder that we are about a week from code freeze, and all k/k PRs need to be merged before code freeze for this enhancement to be included in v1.25. Please also let me know if there are any other PRs we should be tracking.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@jsafrane
Copy link
Member Author

jsafrane commented Aug 3, 2022

I asked for an exception, I got API approval 1 hour after feature freeze.

@jsafrane
Copy link
Member Author

jsafrane commented Aug 3, 2022

Added placeholder real doc PR: kubernetes/website#35667

@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 4, 2022
@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.25 milestone Aug 4, 2022
@jsafrane
Copy link
Member Author

jsafrane commented Aug 8, 2022

Doc for CSI driver vendors: kubernetes-csi/docs#524

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@jsafrane
Copy link
Member Author

jsafrane commented Sep 26, 2022

Not sure if it's needed, the feature was alpha in 1.25 and stays so in 1.26
/label lead-opted-in

@jsafrane jsafrane added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 26, 2022
@jsafrane jsafrane modified the milestones: v1.25, v1.26 Sep 26, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 26, 2022

Will there be any major changes to the alpha implementation in v1.26? If not, we don't need to track it as part of 1.26.

@rhockenbury
Copy link

rhockenbury commented Sep 27, 2022

Spoke over Slack - enhancements team will not track this for 1.26

/label tracked/no
/remove-label lead-opted-in
/milestone clear

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 27, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests