Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Manager #1769

Closed
cezaryzukowski opened this issue May 12, 2020 · 61 comments
Closed

Memory Manager #1769

cezaryzukowski opened this issue May 12, 2020 · 61 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@cezaryzukowski
Copy link
Contributor

cezaryzukowski commented May 12, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 12, 2020

@cezaryzukowski: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented May 12, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2020
@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented May 12, 2020

/kind kep
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory kind/feature Categorizes issue or PR as related to a new feature. labels May 12, 2020
@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented May 12, 2020

/milestone v1.19

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 12, 2020

@cezaryzukowski: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

palnabarun commented May 12, 2020

Hey there @cezaryzukowski @bg-chun -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

As an additional note, #1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled since the KEP PR is in flight.

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks! 🙂


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

@cezaryzukowski @bg-chun -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@palnabarun palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020
@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @cezaryzukowski @bg-chun !

Enhancements Lead here, do you still intend to do any work on this (alpha/beta/stable) for 1.20?

Thanks!
Kirsten

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented Sep 14, 2020

Hi @kikisdeliveryservice, yes w plan Alpha for v1.20 as a target.
Should we update the description above?

PS We planned Alpha for v1.19, but we couldn't make it.

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 14, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 14, 2020

Thanks for the update @cezaryzukowski !

As a reminder the KEP PR should also include a kep.yaml file, please see here for the templates:
https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

If you could also update the description to reflect alpha in 1.20 that would be great.

Best,
Kirsten

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Hi @cezaryzukowski @bg-chun

As a reminder Enhancements Freeze is next week ** Tuesday October 6th**. By that time your completed KEP PR will need to merge.

If you have any questions, please let me know

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 2, 2020

Update: the PR merged! 👍

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented Oct 6, 2020

@kikisdeliveryservice Many thanks for your support.

Do we need to do anything else beyond "KEP merged" to have this feature in v1.20?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 6, 2020

Hi @cezaryzukowski at the moment, no. 😄 But you do have to keep to all of the remaining milestone deadlines such as Code Freeze (Nov 12th) and Test Freeze(Nov 23rd) as well as the Docs Placeholder PR deadline of Nov 6th.

As you go forward, also please link all PRs related to this enhancement on this issue.

Lmk if you have any questions!!! I'll be here 😄 and will remind you of upcoming important dates.

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented Oct 7, 2020

Hi @kikisdeliveryservice

That's grand, we know the exact schedule.

With respect to "Docs Placeholder PR", is there any template or guideline on how to prepare the docs?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 7, 2020

Hi @cezaryzukowski !

So the placeholder PR is very simple. See: https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr. This tells the docs team that you intend on adding feature documentation. Later on you'll add that full documentation and work with the docs team. You just need to do the placeholder by Nov. 6th but the sooner the better =)

Also, going forward, please link the placeholder PR and any k/k PRs back to this issue so the team can track them.

If you have any questions, let me know 😸

Just to recap:
Upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze
Monday, Nov 23rd: Week 11 - Test Freeze

Thanks!
Kirsten

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented May 27, 2021

@PI-Victor @jrsapi Sorry for not replying. Thanks, I will create placeholder till July 9.

@pacoxu
Copy link
Member

pacoxu commented Jun 3, 2021

kubernetes/kubernetes#101947 is PR to promote this feature to beta.

@ehashman
Copy link
Member

ehashman commented Jun 18, 2021

Looks like kubernetes/kubernetes#101030 is a prereq before we can merge the feature flag update.

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @cezaryzukowski,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR's is all that is needed for the implementation of this enhancement for the 1.22 milestone?

Thanks!

@cynepco3hahue
Copy link
Contributor

cynepco3hahue commented Jun 24, 2021

Yes, it all PRs that are mandatory for 1.22. Thanks for the check!

@ehashman
Copy link
Member

ehashman commented Jun 28, 2021

Both PRs have now merged.

@cynepco3hahue
Copy link
Contributor

cynepco3hahue commented Jun 29, 2021

Both PRs have now merged.

A lot of thanks!

@jrsapi
Copy link

jrsapi commented Jul 4, 2021

Thanks @cynepco3hahue, for confirming the PRs. Code freeze starts this Thursday, and this KEP is marked tracked for the milestone.
A reminder that the Docs placeholder deadline is on July 9th. Here are instructions on opening a PR in dev-1.22 branch.

@PI-Victor
Copy link
Member

PI-Victor commented Jul 6, 2021

Hello @cezaryzukowski 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@cezaryzukowski Friendly reminder about the upcoming docs placeholder PR on Fri July 9, 11:59 PM PDT. Please don't forget to open a docs placeholder PR by then.

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented Jul 7, 2021

@PI-Victor No worries, I will create it today. Cheers.

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented Jul 8, 2021

Docs placeholder: kubernetes/website#28851

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Dec 17, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2021
@cynepco3hahue
Copy link
Contributor

cynepco3hahue commented Dec 19, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Mar 19, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 18, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 18, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 18, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 18, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests