Memory Manager #1769

cezaryzukowski · 2020-05-12T12:44:32Z

k8s-ci-robot · 2020-05-12T12:45:54Z

@cezaryzukowski: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cezaryzukowski · 2020-05-12T12:47:06Z

/sig node

cezaryzukowski · 2020-05-12T12:52:43Z

/kind kep
/kind feature

cezaryzukowski · 2020-05-12T12:53:25Z

/milestone v1.19

k8s-ci-robot · 2020-05-12T12:53:27Z

@cezaryzukowski: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

palnabarun · 2020-05-12T19:21:51Z

Hey there @cezaryzukowski @bg-chun -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

The KEP PR must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

As an additional note, #1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled since the KEP PR is in flight.

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks! 🙂

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun · 2020-05-20T02:38:39Z

@cezaryzukowski @bg-chun -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

fejta-bot · 2020-08-18T03:01:45Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

palnabarun · 2020-09-01T14:29:54Z

/remove-lifecycle stale

kikisdeliveryservice · 2020-09-11T21:55:09Z

Hi @cezaryzukowski @bg-chun !

Enhancements Lead here, do you still intend to do any work on this (alpha/beta/stable) for 1.20?

Thanks!
Kirsten

cezaryzukowski · 2020-09-14T09:12:49Z

Hi @kikisdeliveryservice, yes w plan Alpha for v1.20 as a target.
Should we update the description above?

PS We planned Alpha for v1.19, but we couldn't make it.

kikisdeliveryservice · 2020-09-14T19:13:11Z

Thanks for the update @cezaryzukowski !

As a reminder the KEP PR should also include a kep.yaml file, please see here for the templates:
https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

If you could also update the description to reflect alpha in 1.20 that would be great.

Best,
Kirsten

/milestone v1.20

kikisdeliveryservice · 2020-09-30T21:06:33Z

Hi @cezaryzukowski @bg-chun

As a reminder Enhancements Freeze is next week ** Tuesday October 6th**. By that time your completed KEP PR will need to merge.

If you have any questions, please let me know

Best,
Kirsten

kikisdeliveryservice · 2020-10-02T20:16:09Z

Update: the PR merged! 👍

cezaryzukowski · 2020-10-06T07:43:16Z

@kikisdeliveryservice Many thanks for your support.

Do we need to do anything else beyond "KEP merged" to have this feature in v1.20?

kikisdeliveryservice · 2020-10-06T16:44:31Z

Hi @cezaryzukowski at the moment, no. 😄 But you do have to keep to all of the remaining milestone deadlines such as Code Freeze (Nov 12th) and Test Freeze(Nov 23rd) as well as the Docs Placeholder PR deadline of Nov 6th.

As you go forward, also please link all PRs related to this enhancement on this issue.

Lmk if you have any questions!!! I'll be here 😄 and will remind you of upcoming important dates.

cezaryzukowski · 2020-10-07T10:04:18Z

Hi @kikisdeliveryservice

That's grand, we know the exact schedule.

With respect to "Docs Placeholder PR", is there any template or guideline on how to prepare the docs?

kikisdeliveryservice · 2020-10-07T18:14:46Z

Hi @cezaryzukowski !

So the placeholder PR is very simple. See: https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr. This tells the docs team that you intend on adding feature documentation. Later on you'll add that full documentation and work with the docs team. You just need to do the placeholder by Nov. 6th but the sooner the better =)

Also, going forward, please link the placeholder PR and any k/k PRs back to this issue so the team can track them.

If you have any questions, let me know 😸

Just to recap:
Upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze
Monday, Nov 23rd: Week 11 - Test Freeze

Thanks!
Kirsten

Tal-or · 2024-10-28T16:51:23Z

Hello @rashansmith

I opened a placeholder PR kubernetes/website#48578
Will continue the work during this week.

Tal-or · 2024-10-28T16:56:06Z

Thank you @jenshu for the reminder.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

kubelet: memorymanager: metrics: add metrics about static allocation kubernetes#121778

memorymanager: fix the bug of numa node grouping change kubernetes#113090

memorymanager: fix checkpoint file comparison kubernetes#127074

I do not have permission to edit the original issue description. we're tracking the recent work here:
#1769 (comment)

If you anticipate missing code freeze, you can file an exception request in advance.

@ffromani WDYT?

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

At this point there's none.

jenshu · 2024-10-28T17:23:04Z

I do not have permission to edit the original issue description. we're tracking the recent work here:
#1769 (comment)

@Tal-or thanks, I've updated the issue description to add the missing PR

ffromani · 2024-10-28T20:33:58Z

If you anticipate missing code freeze, you can file an exception request in advance.

@ffromani WDYT?

Too early to tell. Let's reconvene after sig-node meeting 2024/Oct/29

WIP. Initial commit in order to have a feature blog placeholder PR see: kubernetes/enhancements#1769 (comment) Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or · 2024-11-04T07:49:48Z

Bump the open tasks here again for visibility since I cannot edit the issue's description:
The following issues need to be addressed in order to consider this work complete (GA-ready):

Memory manager UnexpectedAdmissionError kubernetes#120733
- Fix: memorymanager: avoid violating NUMA node memory allocation rule kubernetes#123443
- Actively handled: Yes - Waiting for review
kubelet: memorymanager static policy startup error kubernetes#113130
- Fix: memorymanager: fix checkpoint file comparison kubernetes#127074
- Actively handled: Yes
kubelet: when memoryManager are enabled, kubelet fails to restart occasionally kubernetes#113035
- Fix: memorymanager: fix the bug of numa node grouping change kubernetes#113090
- Actively handled: No
  - Reason: Marked as duplicate of kubelet: memorymanager static policy startup error kubernetes#113130
blog: Memory Manager goes GA website#48578 - A blog PR
node: kubelet: memmgr: Memory Manager to GA kubernetes#128517 - A PR to finalize the changes for MemoryManager graduation
kubelet memory manager GA graduation website#48494 - A docs PR

Docs update for the Kubelet Memory Manager GA graduation Issue: kubernetes/enhancements#1769 Signed-off-by: Francesco Romani <fromani@redhat.com>

Tal-or · 2024-11-07T13:44:09Z

Hello @rashansmith,

The blog is ready for review: kubernetes/website#48578

jenshu · 2024-11-08T02:38:58Z

Hello @Tal-or 👋, v1.32 Enhancements team here.

With all the implementation (code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

Tal-or · 2024-11-10T12:08:58Z

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

Thank you @jenshu,

Filed a PR: #4959

Tal-or · 2024-11-24T11:49:42Z

Hello @rashansmith,

Wanted to make sure the blog: kubernetes/website#48578 review is not missed for this release cycle.
If anything else is needed from my side, please let me know

haircommander · 2024-12-04T18:49:32Z

/reopen

A github workflow autoclosed when I set to done 🙃 sorry for the noise

k8s-ci-robot · 2024-12-04T18:49:38Z

@haircommander: Reopened this issue.

In response to this:

/reopen

A github workflow autoclosed when I set to done 🙃 sorry for the noise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Docs update for the Kubelet Memory Manager GA graduation Issue: kubernetes/enhancements#1769 Signed-off-by: Francesco Romani <fromani@redhat.com>

dipesh-rawat · 2025-01-12T22:29:58Z

Hi @Tal-or, 👋 1.33 Enhancements lead here,

Now that this KEP has graduated to stable in v1.32, could we update the KEP status in kep.yaml (here) from implementable to implemented? Once the PR for the status change is merged, we should also close this issue.

dipesh-rawat · 2025-01-12T22:30:06Z

/remove-label lead-opted-in

k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 12, 2020

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2020

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory kind/feature Categorizes issue or PR as related to a new feature. labels May 12, 2020

palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020

k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020

Tal-or added a commit to Tal-or/website that referenced this issue Oct 29, 2024

blog: Memory Manager goes GA

2dd86cc

WIP. Initial commit in order to have a feature blog placeholder PR see: kubernetes/enhancements#1769 (comment) Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or mentioned this issue Nov 3, 2024

node: kubelet: memmgr: Memory Manager to GA kubernetes/kubernetes#128517

Merged

ffromani added a commit to ffromani/website that referenced this issue Nov 5, 2024

node: memmgr: docs: Kubelet Memory Manager GA graduation

749a093

Docs update for the Kubelet Memory Manager GA graduation Issue: kubernetes/enhancements#1769 Signed-off-by: Francesco Romani <fromani@redhat.com>

ffromani added a commit to ffromani/website that referenced this issue Nov 5, 2024

node: memmgr: docs: Kubelet Memory Manager GA graduation

a238b30

Docs update for the Kubelet Memory Manager GA graduation Issue: kubernetes/enhancements#1769 Signed-off-by: Francesco Romani <fromani@redhat.com>

ffromani added a commit to ffromani/website that referenced this issue Nov 6, 2024

node: memmgr: docs: Kubelet Memory Manager GA graduation

d6a0b39

Docs update for the Kubelet Memory Manager GA graduation Issue: kubernetes/enhancements#1769 Signed-off-by: Francesco Romani <fromani@redhat.com>

haircommander moved this from Tracked to Implemented in SIG Node 1.32 KEPs planning Nov 7, 2024

jenshu moved this from At risk for code freeze to Tracked for code freeze in 1.32 Enhancements Tracking Nov 8, 2024

This was referenced Nov 10, 2024

memmanager:cleanup: drop Experimental prefix kubernetes/kubernetes#128727

Merged

KEP-1769:memorymanager: mark stable as implemented #4959

Merged

haircommander moved this from Implemented to Done in SIG Node 1.32 KEPs planning Dec 4, 2024

haircommander closed this as completed by moving to Done in SIG Node 1.32 KEPs planning Dec 4, 2024

k8s-ci-robot reopened this Dec 4, 2024

k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025

dipesh-rawat removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 12, 2025

swatisehgal mentioned this issue Jan 22, 2025

Memory Manager is GA now #5072

Merged

k8s-ci-robot closed this as completed in #5072 Feb 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Memory Manager #1769

Memory Manager #1769

cezaryzukowski commented May 12, 2020 •

edited by haircommander

Loading

k8s-ci-robot commented May 12, 2020

cezaryzukowski commented May 12, 2020

cezaryzukowski commented May 12, 2020

cezaryzukowski commented May 12, 2020

k8s-ci-robot commented May 12, 2020

palnabarun commented May 12, 2020

palnabarun commented May 20, 2020

fejta-bot commented Aug 18, 2020

palnabarun commented Sep 1, 2020

kikisdeliveryservice commented Sep 11, 2020

cezaryzukowski commented Sep 14, 2020

kikisdeliveryservice commented Sep 14, 2020

kikisdeliveryservice commented Sep 30, 2020 •

edited

Loading

kikisdeliveryservice commented Oct 2, 2020

cezaryzukowski commented Oct 6, 2020

kikisdeliveryservice commented Oct 6, 2020

cezaryzukowski commented Oct 7, 2020 •

edited

Loading

kikisdeliveryservice commented Oct 7, 2020 •

edited

Loading

Tal-or commented Oct 28, 2024

Tal-or commented Oct 28, 2024

jenshu commented Oct 28, 2024

ffromani commented Oct 28, 2024

Tal-or commented Nov 4, 2024 •

edited

Loading

Tal-or commented Nov 7, 2024

jenshu commented Nov 8, 2024

Tal-or commented Nov 10, 2024 •

edited

Loading

Tal-or commented Nov 24, 2024

haircommander commented Dec 4, 2024

k8s-ci-robot commented Dec 4, 2024

dipesh-rawat commented Jan 12, 2025

dipesh-rawat commented Jan 12, 2025

Memory Manager #1769

Memory Manager #1769

Comments

cezaryzukowski commented May 12, 2020 • edited by haircommander Loading

Enhancement Description

k8s-ci-robot commented May 12, 2020

cezaryzukowski commented May 12, 2020

cezaryzukowski commented May 12, 2020

cezaryzukowski commented May 12, 2020

k8s-ci-robot commented May 12, 2020

palnabarun commented May 12, 2020

palnabarun commented May 20, 2020

fejta-bot commented Aug 18, 2020

palnabarun commented Sep 1, 2020

kikisdeliveryservice commented Sep 11, 2020

cezaryzukowski commented Sep 14, 2020

kikisdeliveryservice commented Sep 14, 2020

kikisdeliveryservice commented Sep 30, 2020 • edited Loading

kikisdeliveryservice commented Oct 2, 2020

cezaryzukowski commented Oct 6, 2020

kikisdeliveryservice commented Oct 6, 2020

cezaryzukowski commented Oct 7, 2020 • edited Loading

kikisdeliveryservice commented Oct 7, 2020 • edited Loading

Tal-or commented Oct 28, 2024

Tal-or commented Oct 28, 2024

jenshu commented Oct 28, 2024

ffromani commented Oct 28, 2024

Tal-or commented Nov 4, 2024 • edited Loading

Tal-or commented Nov 7, 2024

jenshu commented Nov 8, 2024

Tal-or commented Nov 10, 2024 • edited Loading

Tal-or commented Nov 24, 2024

haircommander commented Dec 4, 2024

k8s-ci-robot commented Dec 4, 2024

dipesh-rawat commented Jan 12, 2025

dipesh-rawat commented Jan 12, 2025

cezaryzukowski commented May 12, 2020 •

edited by haircommander

Loading

kikisdeliveryservice commented Sep 30, 2020 •

edited

Loading

cezaryzukowski commented Oct 7, 2020 •

edited

Loading

kikisdeliveryservice commented Oct 7, 2020 •

edited

Loading

Tal-or commented Nov 4, 2024 •

edited

Loading

Tal-or commented Nov 10, 2024 •

edited

Loading