Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto remove PVCs created by StatefulSet #1847

Open
kk-src opened this issue Jun 6, 2020 · 80 comments
Open

Auto remove PVCs created by StatefulSet #1847

kk-src opened this issue Jun 6, 2020 · 80 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@kk-src
Copy link

kk-src commented Jun 6, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Auto remove PVCs created by StatefulSet

  • Kubernetes Enhancement Proposal: KEP-1847: Auto remove PVCs created by StatefulSet.

  • Primary contact (assignee): @mattcary

  • Responsible SIGs: @sig-apps (with collaboration by @sig-storage)

  • Enhancement target (which target equals to which milestone):

    • Alpha release target 1.23
    • Beta release target 1.26
    • Stable release target TBD

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Resolves kubernetes/kubernetes#55045

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 6, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 6, 2020

@kk-src: The label(s) sig/sig-storage cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kk-src
Copy link
Author

kk-src commented Jun 6, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 6, 2020
@kk-src
Copy link
Author

kk-src commented Jun 6, 2020

/assign

@pacoxu
Copy link
Member

pacoxu commented Jun 19, 2020

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 19, 2020

@pacoxu: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

@kubernetes/sig-storage-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor

xing-yang commented Jun 19, 2020

CC @dsu-igeek

@kk-src
Copy link
Author

kk-src commented Jun 19, 2020

Having discussions with @dsu-igeek @msau42 @mattcary
Should have a KEP with the proposal in shortly.

@fejta-bot
Copy link

fejta-bot commented Sep 17, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 21, 2020

Hi @kk-src

Enhancements Lead here. Will there be any work for this in 1.20?

Also, as a reminder to be included in a release:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

Thanks
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 24, 2020

As per #1915 (comment)

marking this is as tracked.

Please note that Enhancements Freeze is October 6th, by which time to be included in the milestone:
The KEP must be merged in an implementable state (not yet merged & provisional)
The KEP must have test plans (missing)
The KEP must have graduation criteria (missing)

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 24, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 24, 2020
@mikejoh
Copy link

mikejoh commented Sep 29, 2020

Hi @kk-src 👋!

I'm one of the Enhancement shadows for the 1.20 release cycle. This is a friendly reminder that the Enhancement freeze is roughly one week from now on the 6th of October. I'm repeating the requirements needed by then:

  • The KEP must be merged in an implementable state.
    • It's provisional at the moment.
  • The KEP must have test plans.
    • Missing in the KEP.
  • The KEP must have graduation criteria.
    • Also missing in the KEP.

Let us know if you have any questions etc.!

Thanks!

@mikejoh
Copy link

mikejoh commented Oct 5, 2020

As a reminder, the Enhancements Freeze is Tomorrow October 6th EOD PST. All KEPs and updates must be merged by that time. After October 6th, you will need to request an Exception to be included in the 1.20 Release.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 7, 2020

Hi @kk-src

Enhancements Freeze is now in effect. Unfortunately, your KEP PR has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best,
Kirsten
1.20 Enhancements Lead

@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Oct 7, 2020
@kk-src
Copy link
Author

kk-src commented Oct 9, 2020

/remove-lifecycle stale

@fejta-bot
Copy link

fejta-bot commented Jan 7, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@rhockenbury
Copy link

rhockenbury commented Jul 21, 2022

👋 Hey @kk-src,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze:
[ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
[ ] All PRs are fully merged by the code freeze deadline.

Looks like there is one PR in k/k for the graduation for this enhancement to beta. Let me know if I missed any other PRs that need to be tracked.

As always, we are here to help should questions come up. Thanks!!

@mattcary
Copy link
Contributor

mattcary commented Jul 21, 2022

Hi @rhockenbury ---

I'm the primary on this issue now, kk-src has moved on to other things. I don't seem to be able to edit the issue description.

Here are the k/k PRs for graduation of this feature:

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@mattcary
Copy link
Contributor

mattcary commented Sep 20, 2022

@soltysh @janetkuo @kow3ns

Could this issue be added to the 1.26 tracking board?

The current status is to promote to beta in 1.26. I am the primary contact for this issue now. Unfortunately, I don't seem to be able to edit this issue description, lmk if the issue can be transferred over to me.

@rhockenbury
Copy link

rhockenbury commented Sep 20, 2022

/label lead-opted-in
/milestone v1.26
/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 20, 2022
@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 20, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 20, 2022

Hello @mattcary 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to open a PR to update the KEP readme and KEP.yaml to meet the criteria above.

The status of this enhancement is marked as at risk. Thanks.

@mattcary
Copy link
Contributor

mattcary commented Sep 21, 2022

Thx, a KEP update is in progress. Based on feedback from the last cycle, I'm tweaking the metrics and will g et a PRR review.

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

This is now marked as tracked for the v1.26 cycle. Thanks.

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

Hi @mattcary 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any open k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked.

As always, we are here to help should questions come up. Thanks!

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @mattcary! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 7, 2022

Hey @kk-src and @mattcary,

As the Code freeze is a day away, just wanted to confirm that there are no open PRs in the K/K repo or any repo in general for this enhancement? So that the enhancement can be marked tracked.

@mattcary
Copy link
Contributor

mattcary commented Nov 7, 2022

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 8, 2022

Hi, I need to get the feature gate promotion PR submitted, that's all: kubernetes/kubernetes#111300 I'm working on that now.

Please try to get this megred before Code freeze.

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests