Make Kubernetes aware of the LoadBalancer behaviour

[Sh4d1]

Enhancement Description

• Make Kubernetes aware of the LoadBalancer behaviour
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1860-kube-proxy-IP-node-binding
• Primary contact (assignee): @Sh4d1
• Responsible SIGs: sig-network, sig-cloudprovider
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y)

kubernetes/kubernetes#119937
kubernetes/kubernetes#120068

• Beta release target (x.y)
• Stable release target (x.y)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

[Sh4d1]

/sig network

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[Sh4d1]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @Sh4d1

1.20 Enhancements Lead here. This KEP still seems to be a draft (it's provisional) but wanted to check-in to see if you thought this would be graduating alpha in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have an issue in the milestone

Best,
Kirsten

[kikisdeliveryservice]

Note: this provisional kep was implemented without having a compliant kep or indicating to the enhancements team that it would be in the 1.20 milestone.

[jeremyrickard]

Hey @Sh4d1 and @thockin,

👋 1.20 release lead here. We're really close to code freeze at this point (Thursday) and it seems like this KEP fell through the cracks and the process.

Based on this comment in the PR above: kubernetes/kubernetes#92312 (comment) can we not land this in 1.20 and instead target 1.21?

There are few things w/ the KEP that really should be address:

• It's provisional still
• There is no test plan
• There is no graduation criteria

Looks like there is also a PR to update the KEP https://github.com/kubernetes/enhancements/pull/2134/files that addresses this stuff, however it also marks it as implemented and targets 1.21. Typically, we set to implemented only after the release.

Can we circle back around on this and agree that we should try to land this in 1.21 at this point? We've already got a lot of content for the release so far (sig-docs has their work cut out for themselves!!!), we're two days out from code freeze, we have these disconnects mentioned above?

[Sh4d1]

@jeremyrickard just opened kubernetes/kubernetes#96454 to revert it, sorry again!
And updated #2134 to set it as implentable instead of implemented

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Sh4d1]

/reopen

[k8s-ci-robot]

@Sh4d1: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[choerl-sys11]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[choerl-sys11]

/remove-lifecycle stale

[RyanAoh]

Hi @thockin, are you currently working on this? If not, I can try to submit a PR. I have already made some commits in my code.

[thockin]

I have some half-cooked branch, but have not had time to really followup. Feel free to start on it if you like, but this KEP is not going into 1.28

[thockin]

xref kubernetes/kubernetes#97681 as a starting point

[npolshakova]

Hi @RyanAoh, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancements and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[RyanAoh]

cc @thockin #4114 has been merged.

[RyanAoh]

@npolshakova The enhancement was ready. Now need the lead-opted-in label by @thockin

[sreeram-venkitesh]

Hello @RyanAoh 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[harshitasao]

Hi @Sh4d1 👋, v1.29 Docs Shadow here
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[sreeram-venkitesh]

Hey again @RyanAoh 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs has been merged before code freeze. Please update the issue description with the PR. Currently marking the KEP as tracked for code freeze.

• Make Kubernetes aware of the LoadBalancer behaviour kubernetes#119937

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[RyanAoh]

@sreeram-venkitesh I can't update the issue description since I'm not the author for this. Just comment here.
All PRs related to this kep:

• Make Kubernetes aware of the LoadBalancer behaviour kubernetes#119937
• follow up on " Merged Make Kubernetes aware of the LoadBalancer behaviour" kubernetes#120068

and the one for doc:

• add doc for feature LoadBalancerIPMode website#43476

[RyanAoh]

Or do I need to open a new issue for it？

[sreeram-venkitesh]

@RyanAoh This is fine, you don't need to open a different issue. Thanks for the quick update!

[kcmartin]

Hi @RyanAoh ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar