Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally Disable NodePorts for Service Type=LoadBalancer #1864

Closed
andrewsykim opened this issue Jun 17, 2020 · 45 comments
Closed

Optionally Disable NodePorts for Service Type=LoadBalancer #1864

andrewsykim opened this issue Jun 17, 2020 · 45 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Jun 17, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Allow users to disable node ports for Service Type=LoadBalancer. This is useful for bare metal / on-prem environments that rely on VIP based LB implementations.

  • Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
    https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1864-disable-lb-node-ports

  • Primary contact (assignee): @andrewsykim

  • Responsible SIGs: Network / Cloud Provider

  • Enhancement target (which target equals to which milestone):

    • Stable release target 1.24

Allow users to optionally opt-out of node port allocation for Service Type=LoadBalancer. This is useful for VIP-based load balancers that don't require node port and the node port should be blocked for regulatory / compliance reasons.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 17, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Jun 17, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 17, 2020
@thockin thockin added this to Proposed in Test-sig-network Sep 4, 2020
@thockin thockin moved this from Proposed to To Do in Test-sig-network Sep 4, 2020
@thockin thockin moved this from To Do to Accepted in Test-sig-network Sep 4, 2020
@fejta-bot
Copy link

fejta-bot commented Sep 15, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 21, 2020

Hi @andrewsykim

Will there be any work on this in 1.20?

Thanks!
Kirsten

@andrewsykim
Copy link
Member Author

andrewsykim commented Sep 21, 2020

Yes, @uablrek has a PR open for this already kubernetes/kubernetes#92744, just waiting for an API review

@kikisdeliveryservice kikisdeliveryservice added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 21, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 21, 2020

Thanks @andrewsykim !!

Going forward, please ensure that active issues don't go stale and are properly milestoned as the Release Team tracks Enhancements via these issues. 😺

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 21, 2020
@kinarashah
Copy link

kinarashah commented Oct 11, 2020

Hi @andrewsykim,

1.20 Enhancement shadow here 👋.

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

@kcmartin
Copy link

kcmartin commented Oct 22, 2020

Hello @andrewsykim, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@kcmartin
Copy link

kcmartin commented Nov 2, 2020

Hi @andrewsykim

The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze
Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Hey @andrewsykim

I know you know this 😆 but: just a reminder that Code Freeze is coming up tomorrow on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

We are just waiting on kubernetes/kubernetes#92744 right?

Thanks!
Kirsten

@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Nov 13, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

Hi @andrewsykim

Code Freeze is now in effect. Your PR is still unmerged, but has full approval. It needs a final rebase so that it can merge. If you can please rebase and get another LGTM ASAP that would be great.

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

The PR was successfully merged this morning - thanks @thockin @andrewsykim & @uablrek for handling this so quickly!!

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@mehabhalodiya
Copy link

mehabhalodiya commented Nov 18, 2021

@salaxander @Priyankasaggu11929 Please remove this from 1.23 milestone.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Nov 18, 2021

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Nov 18, 2021
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 18, 2021
@andrewsykim
Copy link
Member Author

andrewsykim commented Dec 10, 2021

/assign @uablrek

@uablrek
Copy link

uablrek commented Dec 13, 2021

@aojea @andrewsykim What are the administrative steps needed for this? Or where can I read about it? I can handle the code update (remove the feature-gate), no problem, but I suppose there are other things also.

@aojea
Copy link
Member

aojea commented Dec 13, 2021

I think that we only need the code changes locking the feature to GA and removing the checks for the feature gate 88347e7#diff-20224f0a524bdeb13a406c1ed860c13c8cbfdc5631b572603cbce4a2f12291ea

@uablrek
Copy link

uablrek commented Dec 14, 2021

PR for the feature-gate; kubernetes/kubernetes#107027

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in SIG-Network KEPs Jan 6, 2022
@thockin thockin added this to the v1.23 milestone Jan 6, 2022
@andrewsykim andrewsykim added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 27, 2022
@thockin thockin modified the milestones: v1.23, v1.26 Feb 16, 2022
@thockin
Copy link
Member

thockin commented Feb 16, 2022

Reminder: Remove gate in 1.26, milestone updated

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 6, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 27, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2022
@uablrek
Copy link

uablrek commented Jul 31, 2022

Reminder: Remove gate in 1.26, milestone updated

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@thockin thockin moved this from GA (merged, gate not removed) to GA (merged, gate removed) in SIG-Network KEPs Sep 21, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Complete!

@thockin thockin closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
SIG-Network KEPs
GA (merged, gate removed)
Test-sig-network
  
Accepted
Development

No branches or pull requests