-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally Disable NodePorts for Service Type=LoadBalancer #1864
Comments
/sig network |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Hi @andrewsykim Will there be any work on this in 1.20? Thanks! |
Yes, @uablrek has a PR open for this already kubernetes/kubernetes#92744, just waiting for an API review |
Thanks @andrewsykim !! Going forward, please ensure that active issues don't go stale and are properly milestoned as the Release Team tracks Enhancements via these issues. 😺 /milestone v1.20 |
Hi @andrewsykim, 1.20 Enhancement shadow here 👋. Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them. Thank you! |
Hello @andrewsykim, 1.20 Docs shadow here. Does this enhancement work planned for 1.20 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Hi @andrewsykim The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the Also, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track. |
Hey @andrewsykim I know you know this 😆 but: just a reminder that Code Freeze is coming up tomorrow on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required. We are just waiting on kubernetes/kubernetes#92744 right? Thanks! |
Hi @andrewsykim Code Freeze is now in effect. Your PR is still unmerged, but has full approval. It needs a final rebase so that it can merge. If you can please rebase and get another LGTM ASAP that would be great. Best, |
The PR was successfully merged this morning - thanks @thockin @andrewsykim & @uablrek for handling this so quickly!! |
@salaxander @Priyankasaggu11929 Please remove this from 1.23 milestone. |
/milestone clear |
/assign @uablrek |
@aojea @andrewsykim What are the administrative steps needed for this? Or where can I read about it? I can handle the code update (remove the feature-gate), no problem, but I suppose there are other things also. |
I think that we only need the code changes locking the feature to GA and removing the checks for the feature gate 88347e7#diff-20224f0a524bdeb13a406c1ed860c13c8cbfdc5631b572603cbce4a2f12291ea |
PR for the feature-gate; kubernetes/kubernetes#107027 |
Reminder: Remove gate in 1.26, milestone updated |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Complete! |
Enhancement Description
One-line enhancement description (can be used as a release note):
Allow users to disable node ports for Service Type=LoadBalancer. This is useful for bare metal / on-prem environments that rely on VIP based LB implementations.
Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1864-disable-lb-node-ports
Primary contact (assignee): @andrewsykim
Responsible SIGs: Network / Cloud Provider
Enhancement target (which target equals to which milestone):
Allow users to optionally opt-out of node port allocation for Service Type=LoadBalancer. This is useful for VIP-based load balancers that don't require node port and the node port should be blocked for regulatory / compliance reasons.
The text was updated successfully, but these errors were encountered: