Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Feature: Disable AcceleratorUsage Metrics #1867

Closed
RenaudWasTaken opened this issue Jun 18, 2020 · 37 comments
Closed

Kubelet Feature: Disable AcceleratorUsage Metrics #1867

RenaudWasTaken opened this issue Jun 18, 2020 · 37 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@RenaudWasTaken
Copy link
Member

RenaudWasTaken commented Jun 18, 2020

Enhancement Description

/kind feature
/sig node
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 18, 2020
@RenaudWasTaken RenaudWasTaken changed the title Kubelet Feature: DisableAcceleratorUsageMetrics Kubelet Feature: Disable AcceleratorUsage Metrics Jun 18, 2020
@palnabarun
Copy link
Member

palnabarun commented Jul 21, 2020

Hi @RenaudWasTaken 👋 -- the exception request was approved. 💯

I have added the enhancement to the tracking sheet. It is marked At Risk because the implementation PR is yet to be milestoned to v1.19. Please ensure that the PR is appropriately milestoned and gets merged.

Please let us know if you need any help. Thanks! 🙂

@palnabarun
Copy link
Member

palnabarun commented Jul 21, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 21, 2020
@palnabarun
Copy link
Member

palnabarun commented Jul 21, 2020

/stage alpha

@palnabarun palnabarun added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 21, 2020
@palnabarun
Copy link
Member

palnabarun commented Jul 21, 2020

PS: Updated the issue comment with a link to the KEP.

@savitharaghunathan
Copy link
Member

savitharaghunathan commented Jul 21, 2020

Hi @RenaudWasTaken 👋 , 1.19 Docs Lead here. Do this feature require any new documentation or changes to existing ones?

@RenaudWasTaken
Copy link
Member Author

RenaudWasTaken commented Jul 21, 2020

Hello @savitharaghunathan!

It does require a small paragraph to be added, I'll have a PR ready in an hour!

@RenaudWasTaken
Copy link
Member Author

RenaudWasTaken commented Jul 21, 2020

Done! kubernetes/website#22628

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.19 milestone Sep 11, 2020
@kikisdeliveryservice kikisdeliveryservice removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @RenaudWasTaken

Enhancements Lead here. Just confirming you are intending to work on beta for 1.21 and that no work for 1.20 is planned?

Thanks!
Kirsten

@RenaudWasTaken
Copy link
Member Author

RenaudWasTaken commented Sep 14, 2020

Hello!

After feedback from sig-node during the kep process, we were planning to graduate this feature to beta during the 1.20 release.

I'll be putting up another docs PR as well as a PR to mark this feature beta. No further work should be needed.

Thanks for following up on this!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 14, 2020

Hi @RenaudWasTaken !!

Thanks for the update! Could you please update your kep to reflect beta for 1.20 as well as the description in this issue?

Thanks!
Kirsten

Update: just realized that you already said you'll PR to mark as beta 😆 sorry!!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 14, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 14, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 29, 2020

Hi @RenaudWasTaken

Gentle ping: your kep.yaml should be updated to reflect beta for 1.20. Note: Enhancements Freeze is October 6th.

Thanks,
Kirsten

@RenaudWasTaken
Copy link
Member Author

RenaudWasTaken commented Oct 27, 2020

Addressed here: kubernetes/website#24755

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 10, 2020

Hey @RenaudWasTaken

Work on this for 1.20 is already finished but if that's not the case: Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks
Kirsten

@RenaudWasTaken
Copy link
Member Author

RenaudWasTaken commented Nov 10, 2020

Prs were merged yesterday and today!

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@fejta-bot
Copy link

fejta-bot commented Apr 7, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2021
@pacoxu
Copy link
Member

pacoxu commented Apr 8, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2021
@fejta-bot
Copy link

fejta-bot commented Jul 7, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 6, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 6, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 5, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 5, 2021

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Member

pacoxu commented Jan 19, 2022

DisableAcceleratorUsageMetrics is beta since 1.20. (Now it is 1.24 release cycle.)
Do we have a plan to mark the feature gate as GA?
I have a task kubernetes/kubernetes#99183 to make a similar feature gate to disable process metrics from cadvisor.

@ganga1980
Copy link

ganga1980 commented Jun 28, 2022

DisableAcceleratorUsageMetrics is beta since 1.20. (Now it is 1.24 release cycle.) Do we have a plan to mark the feature gate as GA? I have a task kubernetes/kubernetes#99183 to make a similar feature gate to disable process metrics from cadvisor.

@RenaudWasTaken , @pacoxu , I cant find exact timelines when the DisableAcceleratorMetrics feature gate goes to GA. Are you guys aware date (or month) at which this feature gate planned to go?

@pacoxu
Copy link
Member

pacoxu commented Jun 29, 2022

The feature was graduated to GA for almost 2 years. I think it is time to graduate it to GA.
As the plan in this pr and KEP, we should already GA this feature in v1.22.

@pacoxu
Copy link
Member

pacoxu commented Jun 29, 2022

/reopen
as the feature is still not GAed.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 29, 2022

@pacoxu: Reopened this issue.

In response to this:

/reopen
as the feature is still not GAed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jun 29, 2022
@ganga1980
Copy link

ganga1980 commented Jun 29, 2022

/reopen as the feature is still not GAed.

yes, this is not GAed yet. Anytime lines when this feature gate will be moved to GA?

@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 29, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

10 participants