Kubelet Feature: Disable AcceleratorUsage Metrics

[RenaudWasTaken]

Enhancement Description

• One-line enhancement description (can be used as a release note): Deprecate the AcceleratorUsageMetrics that kubelet provides
• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR): https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1867-disable-accelerator-usage-metrics
• Primary contact (assignee): @RenaudWasTaken @dashpole
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.19
  • Beta release target (x.y): 1.20
  • Stable release target (x.y): 1.22

/kind feature
/sig node
/stage alpha

[palnabarun]

Hi @RenaudWasTaken 👋 -- the exception request was approved. 💯

I have added the enhancement to the tracking sheet. It is marked At Risk because the implementation PR is yet to be milestoned to v1.19. Please ensure that the PR is appropriately milestoned and gets merged.

Please let us know if you need any help. Thanks! 🙂

[palnabarun]

/milestone v1.19

[palnabarun]

/stage alpha

[palnabarun]

PS: Updated the issue comment with a link to the KEP.

[savitharaghunathan]

Hi @RenaudWasTaken 👋 , 1.19 Docs Lead here. Do this feature require any new documentation or changes to existing ones?

[RenaudWasTaken]

Hello @savitharaghunathan!

It does require a small paragraph to be added, I'll have a PR ready in an hour!

[RenaudWasTaken]

Done! kubernetes/website#22628

[kikisdeliveryservice]

Hi @RenaudWasTaken

Enhancements Lead here. Just confirming you are intending to work on beta for 1.21 and that no work for 1.20 is planned?

Thanks!
Kirsten

[RenaudWasTaken]

Hello!

After feedback from sig-node during the kep process, we were planning to graduate this feature to beta during the 1.20 release.

I'll be putting up another docs PR as well as a PR to mark this feature beta. No further work should be needed.

Thanks for following up on this!

[kikisdeliveryservice]

Hi @RenaudWasTaken !!

Thanks for the update! Could you please update your kep to reflect beta for 1.20 as well as the description in this issue?

Thanks!
Kirsten

Update: just realized that you already said you'll PR to mark as beta 😆 sorry!!

[kikisdeliveryservice]

/milestone v1.20

[kikisdeliveryservice]

Hi @RenaudWasTaken

Gentle ping: your kep.yaml should be updated to reflect beta for 1.20. Note: Enhancements Freeze is October 6th.

Thanks,
Kirsten

[kikisdeliveryservice]

Hey @RenaudWasTaken

Work on this for 1.20 is already finished but if that's not the case: Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks
Kirsten

[RenaudWasTaken]

Prs were merged yesterday and today!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[pacoxu]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[k8s-triage-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pacoxu]

DisableAcceleratorUsageMetrics is beta since 1.20. (Now it is 1.24 release cycle.)
Do we have a plan to mark the feature gate as GA?
I have a task kubernetes/kubernetes#99183 to make a similar feature gate to disable process metrics from cadvisor.

[ganga1980]

DisableAcceleratorUsageMetrics is beta since 1.20. (Now it is 1.24 release cycle.) Do we have a plan to mark the feature gate as GA? I have a task kubernetes/kubernetes#99183 to make a similar feature gate to disable process metrics from cadvisor.

@RenaudWasTaken , @pacoxu , I cant find exact timelines when the DisableAcceleratorMetrics feature gate goes to GA. Are you guys aware date (or month) at which this feature gate planned to go?

[pacoxu]

The feature was graduated to GA for almost 2 years. I think it is time to graduate it to GA.
As the plan in this pr and KEP, we should already GA this feature in v1.22.

[pacoxu]

/reopen
as the feature is still not GAed.

[k8s-ci-robot]

@pacoxu: Reopened this issue.

In response to this:

/reopen
as the feature is still not GAed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ganga1980]

/reopen as the feature is still not GAed.

yes, this is not GAed yet. Anytime lines when this feature gate will be moved to GA?

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.