Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Service CIDRs #1880

Open
7 of 8 tasks
aojea opened this issue Jun 30, 2020 · 83 comments
Open
7 of 8 tasks

Multiple Service CIDRs #1880

aojea opened this issue Jun 30, 2020 · 83 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@aojea
Copy link
Member

aojea commented Jun 30, 2020

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 30, 2020
@kikisdeliveryservice
Copy link
Member

Hi @aojea

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@aojea
Copy link
Member Author

aojea commented Sep 14, 2020

seems this change requires more discussion, no plans yet

@kikisdeliveryservice
Copy link
Member

Thanks! Please let us know if anything changes 😺

@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 14, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 12, 2021
@ehashman
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2021
@aojea
Copy link
Member Author

aojea commented Jan 14, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 14, 2021
@aojea aojea changed the title Supported Service Subnet Sizes Services API for ClusterIP and NodePort Allocations Jan 24, 2021
@aojea aojea changed the title Services API for ClusterIP and NodePort Allocations Services ClusterIP and NodePort Allocations API Jan 24, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 24, 2021
@thockin thockin removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 1, 2021
@thockin thockin moved this from New (not evaluated) to Pre-Alpha (code not merged) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 1, 2021
@aojea aojea moved this from Pre-Alpha (code not merged) to New, not evaluated in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 1, 2021
@aojea aojea moved this from New, not evaluated to Evaluated, not committed in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 1, 2021
@aojea aojea moved this from Evaluated, not committed to Pre-Alpha (code not merged) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 1, 2021
@dcbw
Copy link
Member

dcbw commented Jun 10, 2021

[sig-network 2021-06-10] Waiting on Tim/others to review Antonio's PoC repo...

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@thockin thockin added this to the v1.31 milestone May 23, 2024
@aojea aojea added stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels May 24, 2024
@aojea
Copy link
Member Author

aojea commented May 28, 2024

Targeting beta with disable by default

@tjons
Copy link

tjons commented Jun 5, 2024

Hello @aojea 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • Merge the KEP readme using the latest template into the k/enhancements repo. Please ensure you pay careful attention to this question as I noticed it was missing in your KEP PR.
  • Mark the KEP status as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@aojea
Copy link
Member Author

aojea commented Jun 5, 2024

@tjons can you please check the PR #4645 is ok? I can't find the missing sections of the template you are referring to

@sreeram-venkitesh
Copy link
Member

/stage beta

@sreeram-venkitesh sreeram-venkitesh removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 5, 2024
@tjons
Copy link

tjons commented Jun 5, 2024

@aojea this question, under scalability, is now required: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template#can-enabling--using-this-feature-result-in-resource-exhaustion-of-some-node-resources-pids-sockets-inodes-etc: Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)? Otherwise, your KEP looks good, just needs to be merged and marked as implementable

@aojea
Copy link
Member Author

aojea commented Jun 5, 2024

@aojea this question, under scalability, is now required: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template#can-enabling--using-this-feature-result-in-resource-exhaustion-of-some-node-resources-pids-sockets-inodes-etc: Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)

fixed, thanks for the quick response

@Princesso
Copy link

Hello @aojea 👋, 1.31 Docs Lead here.
Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!

@dipesh-rawat
Copy link
Member

Hi @aojea 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze in few hours, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #1880 (comment) that are addressed as part of PR #4645 which still needs to be merged.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Jun 14, 2024

Hi @aojea 👋, 1.31 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

@sreeram-venkitesh
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Jun 14, 2024
@thockin
Copy link
Member

thockin commented Jun 14, 2024

I will file an exception on behalf of @aojea who is unavailable right now (Friday night local time). I think the only thing blocking is one corner-case that we want to address, but it is a small race and we don't want to go out with it.

@mbianchidev
Copy link
Member

Hey @sreeram-venkitesh can you let me know if this enhancement makes it in this release?
Chaning the status on the board also works. Thanks a ton :)

@thockin
Copy link
Member

thockin commented Jun 18, 2024

The exception was approved. We are working on the revised kept language today and yesterday.

@sreeram-venkitesh
Copy link
Member

@mbianchidev: +1 to what Tim said, exception was approved.

@thockin thockin added this to the v1.31 milestone Jun 18, 2024
@thockin
Copy link
Member

thockin commented Jun 18, 2024

The revised KEP has been merged

@sreeram-venkitesh
Copy link
Member

@thockin Is there anything else that needs to be merged? If no I can mark this KEP as tracked.

@thockin
Copy link
Member

thockin commented Jun 19, 2024

We haggled over some future milestones, but I think the language for this KEP for this release is done. Thanks for the extra few days!

@sreeram-venkitesh
Copy link
Member

@aojea @thockin The KEP is marked as tracked for enhancements freeze! Thanks!

@Princesso
Copy link

Hello @aojea 👋, 1.31 Docs Lead here. Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

Hi @thockin @aojea, gentle reminder to raise a draft Doc PR before Thursday, June 27, 2024, 18:00 PDT, if this enhancement requires documentation for v1.31.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@mbianchidev
Copy link
Member

Hello @aojea and @thockin

It's Matteo from the v1.31 Communications Team 😄

We'd love for you to opt in to write a feature blog about this enhancement on dynamic IPs availability for Services!
A reason why you might want to write a blog for this feature is that it is graduating to beta and it is interesting for our users.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Let me know if you need any support for the blog, thanks!

@tjons
Copy link

tjons commented Jul 8, 2024

Hi @aojea @thockin - 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I am tracking the following PRs, both of which look good:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

This enhancement is now marked as tracked for code freeze for the {current release} Code Freeze!
As always, we are here to help if any questions come up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Net New
Status: Tracked
Status: Tracked for Code Freeze
Status: Tracked for Code Freeze
Obsolete: SIG-Network KEPs (see https...
Alpha gated (code is merged)
Status: 03 Beta
Development

No branches or pull requests