Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure file in-tree to CSI driver migration #1885

Open
andyzhangx opened this issue Jul 6, 2020 · 54 comments
Open

Azure file in-tree to CSI driver migration #1885

andyzhangx opened this issue Jul 6, 2020 · 54 comments
Assignees
Labels
area/provider/azure Issues or PRs related to azure provider lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Jul 6, 2020

Enhancement Description

Parent enhancement: #625

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig cloud-provider
/area provider/azure
/sig storage
/assign

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jul 6, 2020
@msau42
Copy link
Member

msau42 commented Sep 25, 2020

@andyzhangx do you plan to target beta for this in 1.20?

@andyzhangx
Copy link
Member Author

andyzhangx commented Sep 27, 2020

yes, here is the detailed plan: kubernetes-sigs/azurefile-csi-driver#115

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

Hi @andyzhangx

The design doc that you linked for this Enhancement is using an old format, please update to use the current KEP format here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Also please note that Enhancements Freeze is October 6th and by that time we expect that:

The KEP must be merged in an implementable state (the format you are using has no such state)
The KEP must have test plans (can you specify which need to be done for beta https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#testing)
The KEP must have graduation criteria (The schedule is stale and references milestones that has already passed: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#implementation-schedule)

Thanks
Kirsten

@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Sep 27, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 27, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Hi @andyzhangx

Enhancements Freeze is October 6th. Can you please respond to the above query and update the doc as requested?

Thanks!
Kirsten

@msau42
Copy link
Member

msau42 commented Oct 2, 2020

Hi @kikisdeliveryservice, this is the KEP we're using to track all the different csi migration implementations https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 5, 2020

Hi @msau42 I spoke to @palnabarun earlier today and got the background. I marked this tracked and good to go for 1.20 👍

@kendallroden
Copy link
Contributor

kendallroden commented Oct 12, 2020

Hey @andyzhangx !

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

@somtochiama
Copy link
Member

somtochiama commented Oct 21, 2020

Hello @andyzhangx, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@somtochiama
Copy link
Member

somtochiama commented Oct 31, 2020

Hi @andyzhangx
The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

Thank you

@kikisdeliveryservice kikisdeliveryservice added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Nov 5, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

Hi @andyzhangx

Code Freeze is now in effect. Your PR is still unmerged, with no approvals and has a hold. If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 13, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Nov 13, 2020
@annajung
Copy link
Member

annajung commented Jan 25, 2021

Hi @andyzhangx, 1.21 Enhancements Lead here.
This enhancement has been opt-in for the 1.21 release without a KEP link. However, I was able to locate the CSI migration KEP under sig storage. Could you confirm that https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration is the correct one that's associated with this issue?

@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 27, 2021

Hi @andyzhangx, 1.21 Enhancements Lead here.
This enhancement has been opt-in for the 1.21 release without a KEP link. However, I was able to locate the CSI migration KEP under sig storage. Could you confirm that https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration is the correct one that's associated with this issue?

@annajung yes, thanks, we resolved the blocking issue, and Azure file in-tree to CSI driver migration would go beta in 1.21.

@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 28, 2021
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@xing-yang
Copy link
Contributor

xing-yang commented May 23, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 23, 2022
@xing-yang xing-yang added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 23, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 3, 2022
@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 6, 2022

Hello @andyzhangx 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage stable for 1.25 release

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Referring to above conversations I have noted that the graduation criteria and test-plan is inherited by this parent KEP (correct me if thats not true)

So it looks like for this one, we would need to update the following:

  • Please update the Issue description with the correct URL for the Kubernetes Enhancement Proposal
  • According to the latest KEP template add a dedicated Design Details section and move the Test plan and Graduation sub-sections under this section
  • The KEP needs updating it's Test Plan Section to incorporate more details as stated in the updated detailed test plan
  • Update the kep.yaml to reflect the latest milestone & stage information
  • Update the production readiness review to move to the stable stage

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@andyzhangx
Copy link
Member Author

andyzhangx commented Jun 8, 2022

we are targeting CSI migration GA on 1.25, here is the k/k PR: kubernetes/kubernetes#110458

@xing-yang
Copy link
Contributor

xing-yang commented Jun 10, 2022

Moving to 1.26 per comment here: kubernetes/kubernetes#110458 (comment)

@Priyankasaggu11929 Priyankasaggu11929 added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 10, 2022

Thanks for the clarification ^ @xing-yang. 👍

@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 14, 2022

Hey @andyzhangx @xing-yang 👋
Just for note: Enhancements Freeze is now extended to next week till Thursday June 23, 2022 🚀
So we now have one more week :)

@xing-yang
Copy link
Contributor

xing-yang commented Jun 24, 2022

Thanks @Atharva-Shinde! We are still targeting GA in 1.26.

@rhockenbury rhockenbury removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 11, 2022
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 12, 2022
@andyzhangx
Copy link
Member Author

andyzhangx commented Sep 15, 2022

I have set Stable release target 1.26

@rhockenbury rhockenbury added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 18, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 18, 2022

Hello @andyzhangx 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

With #3360 merged, this enhancement is now tracked for the v1.26 cycle. Thanks!

@rhockenbury
Copy link

rhockenbury commented Oct 29, 2022

Hi @andyzhangx 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like we'll need a PR to graduate this feature to stable.

As always, we are here to help should questions come up. Thanks!

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @andyzhangx ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@katmutua
Copy link

katmutua commented Nov 7, 2022

@andyzhangx are the merged parent enhancement docs sufficient to cover changes made by this enhancement? If so will mark docs as completed and merged.

@andyzhangx
Copy link
Member Author

andyzhangx commented Nov 8, 2022

@andyzhangx are the merged parent enhancement docs sufficient to cover changes made by this enhancement? If so will mark docs as completed and merged.

@katmutua with this PR(kubernetes/kubernetes#113160) merged, I think we could mark as completed and merged.

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

With kubernetes/kubernetes#113160 merged, I have this marked as tracked for code freeze.

@krol3
Copy link

krol3 commented Nov 20, 2022

The doc PR for the release 1.26 here
cc: @katmutua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests