Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJobs (previously ScheduledJobs) #19

Closed
16 tasks done
soltysh opened this issue Jul 4, 2016 · 145 comments
Closed
16 tasks done

CronJobs (previously ScheduledJobs) #19

soltysh opened this issue Jul 4, 2016 · 145 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@soltysh
Copy link
Contributor

soltysh commented Jul 4, 2016

Enhancement Description

@soltysh soltysh self-assigned this Jul 4, 2016
@soltysh
Copy link
Contributor Author

soltysh commented Jul 4, 2016

@erictune fyi

@idvoretskyi idvoretskyi modified the milestone: v1.4 Jul 18, 2016
@philips
Copy link
Contributor

philips commented Jul 22, 2016

@soltysh On what SIG can I discuss this feature? I want to have a longer discussion about third-party resources for this feature and why we feel it needs to be built into core.

@erictune
Copy link
Member

erictune commented Jul 22, 2016

Let's use SIG-Apps for now. There has not been a lot of discussion of controllers there, that I have seen, but lets try and see how it goes.

@gtaylor
Copy link

gtaylor commented Jul 27, 2016

Is this being considered for exclusion from the core? I had thought the proposal was already accepted.

@soltysh
Copy link
Contributor Author

soltysh commented Jul 27, 2016

@gtaylor nothing has been decided yet. Currently it'll be part of alpha group in batch, what will happen when this migrates to more stable is not yet known.

@davidopp
Copy link
Member

davidopp commented Jul 28, 2016

My understanding was that this was accepted into core, while job workflow was rejected for core. In fact we had originally planned to have it in 1.3.

@soltysh
Copy link
Contributor Author

soltysh commented Jul 28, 2016

@davidopp my comment was based on the discussion we've previously had with @philips @erictune here. Although, personally I'd prefer SJ stay in the core 😎

@davidopp
Copy link
Member

davidopp commented Jul 29, 2016

@soltysh I interpreted the comment as implying that it would be in core (based on the mention of alpha/beta and the statement "If someone were to produce a third-party version of scheduledJob, well before 1.4, and show that was comparably useful, that would be persuasive argument for the latter path" where the latter path was ThirdParty).

@erictune
Copy link
Member

erictune commented Jul 29, 2016

@davidopp that comment was made when I thought SJ would be Beta in 1.4. Now it is going to Alpha in 1.4. The philosophy was that we can cancel an alpha feature for whatever reason, but we should have a pretty high bar for cancelling a beta feature.

@erictune
Copy link
Member

erictune commented Jul 29, 2016

Also, to all working on SJ: we should continue work at full speed, despite the above conversation. Much of the work will apply either way, and we need to get some kind of feature out to users so they can give feedback.

@soltysh
Copy link
Contributor Author

soltysh commented Jul 29, 2016

All SJ work is at full speed, the only remaining problem (hopefully) is to have kubernetes/kubernetes#29187 in. I'm hoping to discuss this issue with @smarterclayton today or over the weekend and have it merged so next week we should see one after the other SJ PRs being merged.

@idvoretskyi idvoretskyi added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Aug 4, 2016
@eghobo
Copy link

eghobo commented Aug 10, 2016

@soltysh: it looks like #29187 was merged, does it mean next 1.4 alpha release will have SJ ready to play?

@soltysh
Copy link
Contributor Author

soltysh commented Aug 10, 2016

@eghobo that's the plan.

@erictune
Copy link
Member

erictune commented Aug 17, 2016

This needs docs in k8s.io, but it looks like code is in. Awesome!

@davidopp
Copy link
Member

davidopp commented Aug 17, 2016

+100

@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

@soltysh are docs considered done or are you adding more examples / tutorials? If docs are done we can check the docs box

@soltysh
Copy link
Contributor Author

soltysh commented Sep 5, 2016

@janetkuo I usually mark them done once they merge. With that in mind I've checked the one against branch 1.4, the other will wait for merge.

@soltysh
Copy link
Contributor Author

soltysh commented Nov 9, 2016

Since this was renamed to CronJobs I'll update the title to reflect that change as well.

@soltysh soltysh changed the title ScheduledJobs CronJobs (previously ScheduledJobs) Nov 9, 2016
@ConorNevin
Copy link

ConorNevin commented Nov 16, 2016

Is this going to be in beta for 1.5?

@soltysh
Copy link
Contributor Author

soltysh commented Nov 16, 2016

@ConorNevin unfortunately not, see the beta requirements in the issue description what we need to address first to promote it to beta. Sorry 😞 Help with fixing those is highly encouraged though 😃

@soltysh
Copy link
Contributor Author

soltysh commented Jun 28, 2021

@JamesLaverack all PRs as outlined in the description, just checked we're all good 👍

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 18, 2021
@salaxander
Copy link

salaxander commented Aug 19, 2021

Hey @soltysh - Could you open a PR on the KEP to mark the status as implemented? At that point we can close out the issue.

Thanks!!

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Aug 31, 2021

Per https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable#release-122 we'll remove the old controller. But the old controller code hasn't been cleaned up. Is there a plan? @soltysh

@soltysh
Copy link
Contributor Author

soltysh commented Sep 1, 2021

Hey @soltysh - Could you open a PR on the KEP to mark the status as implemented? At that point we can close out the issue.

@salaxander opened #2925 fixing it

The issue can't be closed, yet. We need to get rid of the old controller in 1.23 as the last element.

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Sep 1, 2021
@salaxander salaxander added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 1, 2021
@salaxander
Copy link

salaxander commented Sep 1, 2021

Hey @soltysh - 1.23 enhancements lead here! Are we just tracking the removal of the old controller for this release? We've got a PRR freeze in effect starting tomorrow, but that shouldn't impact this

@soltysh
Copy link
Contributor Author

soltysh commented Sep 2, 2021

That's my thinking as well, the feature is off, we're just removing the ability to turn it on as pointed out in https://github.com/kubernetes/kubernetes/blob/2a88664eccdf02cd01777b48171873a028117737/pkg/features/kube_features.go#L841 so that's not requiring PRR.

@jlbutler
Copy link

jlbutler commented Sep 22, 2021

Hi @soltysh! 1.23 Docs team here.

This enhancement issue is listed as 'None required' for docs in the tracking sheet. I wanted to confirm we don't have any changes related to this (feature gate docs, deprecation/removal notes, etc)?

If not, please confirm and all good on our end. Otherwise, please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Thanks!

@chrisnegus
Copy link

chrisnegus commented Nov 2, 2021

Hi @soltysh! I'm a 1.23 docs release team shadow. I'm checking that there is no documentation needed for this feature.

CronJobControllerv2 is mentioned in the following K8s docs: Feature Gates and CronJob, Please confirm that the text in those places does not need to change. If changes are needed, please create a PR placeholder for the changes before Thu November 18, 11:59 PM PDT. Thanks!

@soltysh
Copy link
Contributor Author

soltysh commented Nov 3, 2021

@chrisnegus since we're removing the feature gate in kubernetes/kubernetes#104470 I've opened kubernetes/website#30344

@chrisnegus
Copy link

chrisnegus commented Nov 3, 2021

Thanks @soltysh! Does that cover the extent of changes you want to make? Is it ready to review?

@soltysh
Copy link
Contributor Author

soltysh commented Nov 3, 2021

@chrisnegus yes, this is mostly cleaning bits after the old controller.

@soltysh
Copy link
Contributor Author

soltysh commented Nov 8, 2021

Since the doc's folks recommended not changing the feature gate table, this is all ready now.
@chrisnegus this can be closed when we release 1.23

@chrisnegus
Copy link

chrisnegus commented Nov 10, 2021

Since the doc's folks recommended not changing the feature gate table, this is all ready now. @chrisnegus this can be closed when we release 1.23

Thanks @soltysh !

@gracenng
Copy link
Member

gracenng commented Jan 9, 2022

Enhancements graduated to stable, implemented status in KEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests