Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient watch resumption after kube-apiserver reboot #1904

Closed
wojtek-t opened this issue Jul 23, 2020 · 30 comments · Fixed by #3301
Closed

Efficient watch resumption after kube-apiserver reboot #1904

wojtek-t opened this issue Jul 23, 2020 · 30 comments · Fixed by #3301
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Jul 23, 2020

Enhancement Description

/sig api-machinery
/sig scalability
/milestone v1.20

@wojtek-t wojtek-t self-assigned this Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Jul 23, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 12, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Hi @wojtek-t

Enhancements Lead here. Updated the description above to link directly to the merged KEP, updated tracking sheet and tags to reflect alpha in 1.20.

Let me know if you need anything or if anything changes.

Thanks,
Kirsten

@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 13, 2020

@kikisdeliveryservice - yes, I'm targetting Alpha in 1.20

@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 13, 2020

Thanks for already adding tags!

@MorrisLaw
Copy link
Member

MorrisLaw commented Oct 12, 2020

Hi @wojtek-t ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Regards,
Jeremy

@reylejano
Copy link
Member

reylejano commented Oct 19, 2020

Hello @wojtek-t , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 20, 2020

@reylejano-rxm - we don't need any documents for it.

@annajung
Copy link
Member

annajung commented Nov 2, 2020

Hi @wojtek-t

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 8, 2020

We're fine - it's Alpha-ready.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@lavalamp
Copy link
Member

lavalamp commented Jan 13, 2021

/milestone v1.21

I'm assuming we want to go beta in 1.21?

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 13, 2021
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 13, 2021

Thanks Daniel - yes, that's my plan.
I will try to send a KEP update for beta later this week.

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 14, 2021

Send out #2267 for review

@annajung annajung added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@wojtek-t
Copy link
Member Author

wojtek-t commented Jul 27, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 25, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2021
@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 25, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2021
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 12, 2022
@gracenng gracenng modified the milestones: v1.21, v1.24 Jan 12, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 17, 2022

Hello @wojtek-t 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.
For note, This enhancement is targeting for stage stable for 1.24, (correct me if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like, the enhancement is good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked. Please update this issue description with appropriate stages as well. Thank you!

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 17, 2022

Updated issue description - other than that it sounds fine.

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @wojtek-t 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@wojtek-t
Copy link
Member Author

wojtek-t commented Feb 15, 2022

@mehabhalodiya - this was marked by mistake - this doesn't require docs. Can you please update the update the spreadsheet that it's not needed?

@wojtek-t wojtek-t added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Feb 15, 2022
@mehabhalodiya
Copy link

mehabhalodiya commented Feb 16, 2022

@wojtek-t We had a discussion for Need Docs or No Docs required over Slack for this enhancement.

@sftim suggested:

we'd need an update to https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ to record that the feature is now GA, so I think we do need a docs change.

Also, @PI-Victor agreed with Tim, saying:

if the feature is now moved to GA, in the features list gates table md file, all the information regarding that feature gate should be moved down into the table below (Feature gates for graduated or deprecated features). https://github.com/kubernetes/website/blob/main/content/en/docs/reference/command-line-tools-reference/feature-gates.md
e.g.: https://github.com/kubernetes/website/pull/31283/files

Thus, considering the above pointers we are moving this enhancement to Needs Docs status.
Please follow this comment.
Thank you 🙂

@wojtek-t
Copy link
Member Author

wojtek-t commented Feb 17, 2022

I opened kubernetes/website#31770 for docs change.

@rhockenbury
Copy link

rhockenbury commented Mar 22, 2022

Hi @wojtek-t

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like all k/k PRs have been merged. Are there any other PRs that you think we should be tracking that would be subject to the 1.24 code freeze?

Let me know if you have any questions.

@wojtek-t
Copy link
Member Author

wojtek-t commented Mar 22, 2022

@rhockenbury - everything is done - it's good to go.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @wojtek-t 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.