Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Type=LoadBalancer Class #1959

Closed
andrewsykim opened this issue Aug 31, 2020 · 57 comments
Closed

Service Type=LoadBalancer Class #1959

andrewsykim opened this issue Aug 31, 2020 · 57 comments
Assignees
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Aug 31, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Introduce a new Service annotation service.kubernetes.io/load-balancer-class that allows multiple implementations of Service Type=LoadBalancer in a cluster.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 31, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Aug 31, 2020

/sig cloud-provider

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 31, 2020

@andrewsykim: The label(s) sig/ cannot be applied, because the repository doesn't have them

In response to this:

/sig cloud-provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 31, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Aug 31, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Aug 31, 2020
@thockin thockin added this to Proposed in Test-sig-network Sep 4, 2020
@thockin thockin moved this from Proposed to To Do in Test-sig-network Sep 4, 2020
@thockin thockin moved this from To Do to Proposed in Test-sig-network Sep 4, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @andrewsykim

Enhancements Lead here. Can you confirm that this is for stable in 1.20? As a note, there also doesn't seem to be a KEP attached.

Thanks
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

Hi @andrewsykim

Any updates on this for 1.20? There is no KEP on this issue.

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have an issue in the milestone

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Oct 7, 2020
@fejta-bot
Copy link

fejta-bot commented Jan 5, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 6, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2021
@andrewsykim andrewsykim changed the title Service Type=LoadBalancer Class Annotation Service Type=LoadBalancer Class Jan 26, 2021
@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 26, 2021
@annajung annajung added this to the v1.21 milestone Jan 26, 2021
@annajung
Copy link
Member

annajung commented Jan 28, 2021

Hi @andrewsykim, 1.21 Enhancements Lead here

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

Starting 1.21, all KEP must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this and a file under https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-network.

Thank you!

@annajung
Copy link
Member

annajung commented Feb 7, 2021

Hi @andrewsykim

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is NOT tracking any open PR for a KEP update. Please make sure to work on missing requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the KEP requirements by the freeze will require an exception.

@andrewsykim
Copy link
Member Author

andrewsykim commented Feb 8, 2021

PRR update #2442

@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2442 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

@annajung
Copy link
Member

annajung commented Feb 16, 2021

Hi @andrewsykim

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@mvortizr
Copy link

mvortizr commented Feb 20, 2021

/assign

@annajung
Copy link
Member

annajung commented Mar 1, 2021

Hi @andrewsykim

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Feb 1, 2022

Hello, @andrewsykim, just saw that this enhancement is expected to be included in the 1.24 release.

Could you please submit the enhancement issue into the 1.24 tracking sheet so the enhancements team can keep track of it?
Thank you so much!

@gracenng gracenng added this to the v1.24 milestone Feb 3, 2022
@gracenng
Copy link
Member

gracenng commented Feb 3, 2022

All good for 1.24 Enhancements Freeze

@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @andrewsykim 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@andrewsykim
Copy link
Member Author

andrewsykim commented Feb 14, 2022

^ @XudongLiuHarold

@XudongLiuHarold
Copy link
Member

XudongLiuHarold commented Feb 14, 2022

Thanks @andrewsykim ! hi @chrisnegus , I will take care of it from here😄.

@chrisnegus
Copy link

chrisnegus commented Feb 16, 2022

Thanks @XudongLiuHarold !

@XudongLiuHarold
Copy link
Member

XudongLiuHarold commented Feb 21, 2022

draft PR for k/website repo: kubernetes/website#31815

@chrisnegus
Copy link

chrisnegus commented Feb 23, 2022

Thanks for filing the docs PR @XudongLiuHarold !

@gracenng
Copy link
Member

gracenng commented Mar 15, 2022

Hi @andrewsykim 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

@andrewsykim
Copy link
Member Author

andrewsykim commented Mar 15, 2022

PR is here kubernetes/kubernetes#107979, thanks

@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @andrewsykim 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@gracenng
Copy link
Member

gracenng commented Mar 24, 2022

Marking this as tracked for Code Freeze 🥳

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @andrewsykim 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 9, 2022
@thockin thockin modified the milestones: v1.24, v1.26 Jun 20, 2022
@thockin
Copy link
Member

thockin commented Jun 20, 2022

TODO: remove the gate in 1.26

@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 18, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2022
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 19, 2022

Since the gate is to be removed in 1.26 keeping this issue open until then

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2022
@andrewsykim
Copy link
Member Author

andrewsykim commented Sep 19, 2022

PR to remove the feature gate: kubernetes/kubernetes#112577

@thockin thockin moved this from GA (merged, gate not removed) to GA (merged, gate removed) in SIG-Network KEPs Sep 21, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Complete!

@thockin thockin closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
SIG-Network KEPs
GA (merged, gate removed)
Test-sig-network
  
Proposed
Development

No branches or pull requests