Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to size memory backed volumes #1967

Closed
8 tasks done
derekwaynecarr opened this issue Sep 3, 2020 · 27 comments
Closed
8 tasks done

Support to size memory backed volumes #1967

derekwaynecarr opened this issue Sep 3, 2020 · 27 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Sep 3, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 3, 2020
@derekwaynecarr
Copy link
Member Author

derekwaynecarr commented Sep 3, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 3, 2020
@derekwaynecarr derekwaynecarr self-assigned this Sep 3, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Hi @derekwaynecarr !

Enhancements Lead here. You've seemed have linked a PR instead of your KEP (https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1967-size-memory-backed-volumes) I've updated the description to fix.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Related PR kubernetes/kubernetes#94444

@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 12, 2020
@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Sep 12, 2020
@kikisdeliveryservice kikisdeliveryservice added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 12, 2020
@MorrisLaw
Copy link
Member

MorrisLaw commented Oct 12, 2020

Hey @derekwaynecarr ,

Another friendly reminder that since this Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

Also, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you,
Jeremy

@annajung
Copy link
Member

annajung commented Oct 19, 2020

Hello @derekwaynecarr 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@annajung
Copy link
Member

annajung commented Nov 1, 2020

Hi @derekwaynecarr

The docs placeholder deadline is this Friday. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@MorrisLaw
Copy link
Member

MorrisLaw commented Nov 10, 2020

Hi @derekwaynecarr

Just a friendly reminder the code freeze deadline is this Thursday. Please make sure to have any code merged in before the deadline.

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Double checked with Derek and this is completed for code freeze.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@derekwaynecarr
Copy link
Member Author

derekwaynecarr commented Feb 8, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 8, 2021
@annajung annajung added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 8, 2021
@mvortizr
Copy link

mvortizr commented Feb 20, 2021

/assign

@arunmk
Copy link

arunmk commented Feb 20, 2021

Hi @derekwaynecarr, @mvortizr,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@arunmk
Copy link

arunmk commented Mar 2, 2021

Hi @derekwaynecarr @mvortizr ,

Enhancements team does not have a linked PR to track for the upcoming code freeze. Could you please link a PR to this KEP so that we may track it.

We are currently marking this KEP as 'At Risk' for the upcoming code freeze on 3/9.

Thanks

@arunmk
Copy link

arunmk commented Mar 6, 2021

Hi @derekwaynecarr @mvortizr ,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Member

annajung commented Mar 10, 2021

Hi @derekwaynecarr, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

@annajung annajung removed this from the v1.21 milestone Mar 10, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 10, 2021
@ehashman
Copy link
Member

ehashman commented Apr 20, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 20, 2021
@pacoxu
Copy link
Member

pacoxu commented Apr 21, 2021

Per KEP, the Graduation Criteria from Alpha to Beta Graduation includes

  • All feedback gathered from users of memory backed volumes (expect to be minimal)
  • Adequate test signal quality for node e2e
  • Tests are in Testgrid and linked in KEP

Per kubernetes/kubernetes#100319

E2E testing was already defined and had coverage here:
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/storage/empty_dir.go#L298

As kubernetes/kubernetes#101048 1.22 is done to promote SizeMemoryBackedVolumeSizing to beta, is there anything to do in this cycle 1.22?

@ehashman
Copy link
Member

ehashman commented Apr 28, 2021

@pacoxu nope, this one just slipped. The doc update got held.

@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2021
@jrsapi
Copy link

jrsapi commented May 11, 2021

Greetings @derekwaynecarr @mvortizr!
Enhancement shadow checking in. After reviewing the KEP, there are a few things that need to be complete before the 1.22 Enhancements Freeze, which is this Thursday, 5/13.

  • Kep.yaml updated metadata for beta and approved before enhancement freeze.

Thanks!

@jrsapi
Copy link

jrsapi commented May 13, 2021

Greetings @derekwaynecarr @mvortizr!
After re-reviewing the KEP and approved PRR, this enhancement is now being tracked for the v1.22 milestone.

Thanks!

@ehashman
Copy link
Member

ehashman commented May 14, 2021

Let me revive kubernetes/website#27086 and then this will be complete for 1.22.

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @derekwaynecarr ,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 milestone?

Thanks!

@jrsapi
Copy link

jrsapi commented Jul 6, 2021

Greetings @derekwaynecarr,
A #reminder that code freeze is this Thursday, July 7th and Docs placeholder PR deadline is this Friday, July 8th. This is to update you that with kubernetes/kubernetes/101048 merged and k/website PR kubernetes/website/27990 in place. This KEP is marked "Tracked" for the 1.22 milestone.

@ehashman
Copy link
Member

ehashman commented Jul 7, 2021

@jrsapi it seems that my PR for the docs was made redundant, @tengqm already made the changes. No remaining work for beta.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Dec 17, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jan 16, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests