Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Kubelet Exec Probe Timeouts #1972

Open
andrewsykim opened this issue Sep 8, 2020 · 30 comments
Open

Fixing Kubelet Exec Probe Timeouts #1972

andrewsykim opened this issue Sep 8, 2020 · 30 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Sep 8, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Fix kubelet exec probe timeouts not being respected.

@andrewsykim
@SergeyKanzhelev

  • Responsible SIGs:

SIG Node

  • Enhancement target (which target equals to which milestone):
    • Stable release target v1.20

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 8, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Sep 8, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Hi @andrewsykim

Enhancements lead here 👋

Just to be sure: this is intended to go directly to stable in 1.20?

Thanks!
Kirsten

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Sep 14, 2020

Just to be sure: this is intended to go directly to stable in 1.20?

That's the plan we discussed at SIG Node meeting

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 14, 2020

Perfect - thanks for the update @SergeyKanzhelev !

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Sep 14, 2020
@kendallroden
Copy link
Contributor

kendallroden commented Sep 28, 2020

Hi @SergeyKanzhelev, wanted to check in on the status of this enhancement. In order for this to be considered for the 1.20 release, the KEP needs to be fully completed and merged by the Enhancements Freeze on 10/6.

Feel free to reach out with any questions or updates!

Thanks,

Kendall
1.20 Enhancements Team

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Sep 28, 2020

thank you for the ping. I must have an update tomorrow.

@kendallroden
Copy link
Contributor

kendallroden commented Oct 12, 2020

Hey @SergeyKanzhelev!

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

@kcmartin
Copy link

kcmartin commented Oct 22, 2020

Hello @SergeyKanzhelev , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 22, 2020

I will look at it this week

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 22, 2020

Started: kubernetes/website#24692

@kcmartin
Copy link

kcmartin commented Nov 2, 2020

Hi @SergeyKanzhelev

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Hi @SergeyKanzhelev

kubernetes/kubernetes#94115 has merged and this is done for code freeze. Marking as done unless there is some other work in progress.

Thanks!
Kirsten

@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@annajung
Copy link
Member

annajung commented Jan 7, 2021

Hi @SergeyKanzhelev 1.21 Enhancement Lead here.

Can you update the kep.yaml to reflect a status of implemented:

Once that merges, we can close out this issue.

@annajung
Copy link
Member

annajung commented Jan 26, 2021

Hi, I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2022

@SergeyKanzhelev: Reopened this issue.

In response to this:

/reopen
/assign

following up on https://kubernetes.slack.com/archives/C0BP8PW9G/p1642316499054100. I'll send the PR proposing to update the KEP status later today.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gracenng gracenng modified the milestones: v1.20, v1.24 Jan 19, 2022
@gracenng
Copy link
Member

gracenng commented Jan 30, 2022

Hi @SergeyKanzhelev , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd.
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria -- deprecation
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

There's no update for this enhancement since last checkin and we're not tracking any PR. Please link them ASAP
Current status is at risk

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jan 31, 2022

@SergeyKanzhelev what's the update here?

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Feb 1, 2022

@SergeyKanzhelev what's the update here?

Sorry, everything is happening at the same time. Submitted: #3201 Can you pleas take a look?

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

Hi @SergeyKanzhelev , you mentioned PRR and got PRR approval in the PR but did not include a PRR file

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

The Enhancements Freeze is now in effect and this enhancement is removed from the release. Please create a PRR file
Please feel free to file an exception.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Feb 4, 2022
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Feb 4, 2022

@gracenng at this stage it is just a formality? What file should I add? This PR adding the PRR questioner was approved by @johnbelamaric #3201

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

Hi @SergeyKanzhelev , you are missing a PRR file to document the approval (see examples)

@k8s-triage-robot
Copy link

k8s-triage-robot commented May 5, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jun 4, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 4, 2022
@jackfrancis
Copy link

jackfrancis commented Jun 6, 2022

/remove-lifecycle rotten

cc @andrewsykim @SergeyKanzhelev in case we want to queue this up for 1.25

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 6, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 4, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 4, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 4, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2022
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 4, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
No open projects
Development

No branches or pull requests