Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows privileged containers #1981

Open
29 of 35 tasks
ambguo opened this issue Sep 11, 2020 · 77 comments
Open
29 of 35 tasks

Support for Windows privileged containers #1981

ambguo opened this issue Sep 11, 2020 · 77 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@ambguo
Copy link
Contributor

ambguo commented Sep 11, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 11, 2020
@ambguo
Copy link
Contributor Author

ambguo commented Sep 11, 2020

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2020
@ambguo
Copy link
Contributor Author

ambguo commented Sep 11, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 11, 2020
@ambguo
Copy link
Contributor Author

ambguo commented Sep 11, 2020

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 11, 2020
@ambguo
Copy link
Contributor Author

ambguo commented Sep 11, 2020

/stage alpha
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 11, 2020

@ambguo: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/stage alpha
/milestone v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@immuzz
Copy link

immuzz commented Sep 11, 2020

/stage alpha
/milestone v1.20

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 11, 2020

@immuzz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/stage alpha
/milestone v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@immuzz
Copy link

immuzz commented Sep 11, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Hi all,

Enhancements Lead here. Will just update the milestone for you 😄

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Sep 12, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Just as a note when you convert your KEP don't forget to also include the kep.yaml

Both templates that you will need can be found here:
https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Please also update the description when you make the PR and please link any other PRs so that this enhancement can be tracked to the milestone.

Hope that helps.

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 12, 2020
@marosset marosset added this to In Progress (v1.20) in SIG-Windows Sep 18, 2020
@kinarashah
Copy link

kinarashah commented Sep 24, 2020

Hi @ambguo,

Enhancement shadow for 1.20 release here 👋.

Just wanted to check if you had a chance to convert KEP according to the template posted above (https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template).

Please note that the Enhancement freeze deadline for KEPs to be included in 1.20 milestone is Tuesday, October 6.

Your proposal looks great 😄, could you please include the following when you make the KEP PR:

  • Add test plans
  • Update graduation criteria (you've already mentioned those, but if you could update/confirm it for 1.20, that'd be great!)
  • Update state to implementable

Thank you!

@kinarashah
Copy link

kinarashah commented Oct 2, 2020

Thank you @ambguo for actively working on the KEP PR!

Here's the status update based on the freeze requirements:

Requirement Status Comments
Test Plan missing test plans for alpha
Graduation Criteria confirm milestone to 1.20 for alpha here. Beta's set to 1.20+.
Implementable State add KEP yaml with state implementable as mentioned here. If you're looking for an example, hopefully this recently merged sig node kep yaml gives you an idea.
Merged

Just a friendly reminder that we'd need all of them with status to be included in 1.20 milestone by Enhancement Freeze deadline Tuesday, October 6.

Ping me anytime on slack (kinarashah) or here if you have any questions 😄.

Thank you!!

@kinarashah
Copy link

kinarashah commented Oct 2, 2020

/milestone v1.21

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 2, 2020

@kinarashah: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 2, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Oct 2, 2020
@kinarashah
Copy link

kinarashah commented Oct 2, 2020

Spoke with @marosset and @ambguo, this will be tracked alpha for 1.21 milestone and KEP PR would be merged in provisional status for now.

@michmike
Copy link
Contributor

michmike commented Oct 2, 2020

@marosset i thought we are doing privileged containers as alpha for v1.20, not 1.21

@ambguo
Copy link
Contributor Author

ambguo commented Oct 2, 2020

@michmike from our discussion on Tuesday, we are looking into ways to address the pod networking issues mentioned. We are still investigating ways to address the challenges, so will not be able to pursue the alpha release in 1.20 since APIs may require changes depending on the solution.

@dchen1107 dchen1107 added this to the v1.26 milestone Jun 16, 2022
@dchen1107
Copy link
Member

dchen1107 commented Jun 16, 2022

From @marosset "some significant/breaking changes to how volume mounts get set up but those changes won't be available until containerd v1.7 which is expected to release in Oct 2022." In this case, we removed the feature from 1.25 milestone. Thanks!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 17, 2022
@marosset marosset removed this from Backlog (v1.25) in SIG-Windows Aug 18, 2022
@marosset marosset added lead-opted-in Denotes that an issue has been opted in to a release and removed lead-opted-in Denotes that an issue has been opted in to a release labels Sep 1, 2022
@mboersma
Copy link

mboersma commented Sep 2, 2022

/label lead-opted-in

(@marosset asked me to try this.)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 2, 2022

@mboersma: Can not set label lead-opted-in: Must be member in one of these teams: [sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

(@marosset asked me to try this.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset
Copy link
Contributor

marosset commented Sep 2, 2022

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 2, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 18, 2022

Hello @marosset 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

Looks like this enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury rhockenbury added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 19, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

This is now marked as tracked and is all set for enhancements freeze. Thanks.

@sftim
Copy link
Contributor

sftim commented Oct 10, 2022

I recommend cracking on with early work on a docs update so that these are GA quality (or have PRs open to make them be) by the appropriate review deadline.

@marosset
Copy link
Contributor

marosset commented Oct 18, 2022

I recommend cracking on with early work on a docs update so that these are GA quality (or have PRs open to make them be) by the appropriate review deadline.

I started a draft docs PR (linked in initial issue description) and will add more updates as soon as I finish up the e2e coverage that is listed as graduation criteria for this enhancement.

@sftim
Copy link
Contributor

sftim commented Oct 18, 2022

Thanks for that early start!

@marosset
Copy link
Contributor

marosset commented Oct 18, 2022

blog placeholder PR - kubernetes/website#37370

@rhockenbury
Copy link

rhockenbury commented Oct 29, 2022

Hi @marosset 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

As always, we are here to help should questions come up. Thanks!

@krol3
Copy link

krol3 commented Nov 3, 2022

Hello @marosset 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@marosset
Copy link
Contributor

marosset commented Nov 3, 2022

Hello @marosset 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@krol3 I have a placeholder docs PR open and linked in the issue description :)

@krol3
Copy link

krol3 commented Nov 7, 2022

Hi @marosset ! how are you? I see a PR placeholder for the blog, I think we need an update in the documentation too.
For example update to stable, beta here:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features
cc @reylejano

@marosset
Copy link
Contributor

marosset commented Nov 7, 2022

Hi @marosset ! how are you? I see a PR placeholder for the blog, I think we need an update in the documentation too. For example update to stable, beta here: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features cc @reylejano

I've got 2 place-holder PRs open against k/website for this feature
kubernetes/website#37340 - is for documentation updates
kubernetes/website#37370 - is for a blog

Let me know if there is anything else needed at this time. I'm going to work on both of these after 1.26 code-freeze.

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

With kubernetes/kubernetes#113476 merged, I have this marked as tracked for code freeze.

@krol3
Copy link

krol3 commented Nov 10, 2022

Hello @marosset 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
Status: In Progress
Development

No branches or pull requests